From: Lennart Poettering <mzxreary@0pointer.de>
To: Tejun Heo <tj@kernel.org>
Cc: Li Zefan <lizf@cn.fujitsu.com>,
LKML <linux-kernel@vger.kernel.org>,
Cgroups <cgroups@vger.kernel.org>,
Kay Sievers <kay.sievers@vrfy.org>
Subject: Re: [PATCH 2/2] cgroup: add xattr support
Date: Thu, 19 Jan 2012 02:49:28 +0100 [thread overview]
Message-ID: <20120119014928.GH29242@tango.0pointer.de> (raw)
In-Reply-To: <20120118174732.GG30664@google.com>
On Wed, 18.01.12 09:47, Tejun Heo (tj@kernel.org) wrote:
>
> Hello,
>
> On Wed, Jan 18, 2012 at 04:27:18PM +0800, Li Zefan wrote:
> > Furthermore, I noticed tmpfs also implemented xattr support, and we
> > should be able to share most of the code, which makes the cost for
> > having this feature smaller.
>
> Yes, maybe, but tmpfs doesn't have any special semantics attached to
> files. It's supposed to store opaque data from userland. Regardless
> of code complexity, I just don't think this is a good idea. What if
> we later want to attach certain config meaning to or export statistics
> via xattrs? That would be quite unusual and require strong rationale
> but at least fall in the similar usage as with the rest of the fs.
If you plan to export kernel data to userspace via xattrs, then you
should probably place that in the system.xxx xattr namespace, not in
the user.xxx or trusted.xxx namespaces which are the only ones which can
be manipulated by userspace.
See attr(5) for more information about the four available xattr
namespaces.
In other words: kernel exported xattrs should never collide with xattrs
set by userspace.
Lennart
--
Lennart Poettering - Red Hat, Inc.
next prev parent reply other threads:[~2012-01-19 1:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-16 8:06 [PATCH 1/2] cgroup: revise how we re-populate root directory Li Zefan
2012-01-16 8:07 ` [PATCH 2/2] cgroup: add xattr support Li Zefan
2012-01-17 17:53 ` Tejun Heo
2012-01-18 8:27 ` Li Zefan
2012-01-18 17:47 ` Tejun Heo
2012-01-19 1:49 ` Lennart Poettering [this message]
2012-01-18 21:28 ` Kay Sievers
2012-01-18 21:36 ` Tejun Heo
2012-01-19 1:47 ` Lennart Poettering
2012-01-19 2:20 ` Tejun Heo
2012-01-19 2:40 ` Tejun Heo
2012-01-21 3:02 ` Lennart Poettering
2012-01-21 4:00 ` Hugh Dickins
2012-01-21 2:59 ` Lennart Poettering
2012-01-18 7:23 ` [PATCH 1/2] cgroup: revise how we re-populate root directory Sha
2012-01-18 7:59 ` Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120119014928.GH29242@tango.0pointer.de \
--to=mzxreary@0pointer.de \
--cc=cgroups@vger.kernel.org \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).