From: Tejun Heo <tj@kernel.org>
To: Lennart Poettering <mzxreary@0pointer.de>
Cc: Kay Sievers <kay.sievers@vrfy.org>,
Li Zefan <lizf@cn.fujitsu.com>,
LKML <linux-kernel@vger.kernel.org>,
Cgroups <cgroups@vger.kernel.org>
Subject: Re: [PATCH 2/2] cgroup: add xattr support
Date: Wed, 18 Jan 2012 18:20:05 -0800 [thread overview]
Message-ID: <20120119022005.GG21533@google.com> (raw)
In-Reply-To: <20120119014727.GG29242@tango.0pointer.de>
Hello, Lennart, Li.
Two things.
* Probably I'm missing something but isn't the systemd cgroup
hierarchy already managed by systemd? If so, I don't see how
managing tmpfs on the side would noticeably make things more
fragile. It would take a bit more care after, for example, restart
but it shouldn't be too complex, no?
* FS attributes already being used for userland information seems like
a good argument, but we shouldn't add separate specialized xattr
implementation to different pseudo filesystems. For it to be
acceptable, it should be a libfs thing easily applicable to any
pseudo FS and definitely shouldn't be using kmem for storage.
Thanks.
--
tejun
next prev parent reply other threads:[~2012-01-19 2:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-16 8:06 [PATCH 1/2] cgroup: revise how we re-populate root directory Li Zefan
2012-01-16 8:07 ` [PATCH 2/2] cgroup: add xattr support Li Zefan
2012-01-17 17:53 ` Tejun Heo
2012-01-18 8:27 ` Li Zefan
2012-01-18 17:47 ` Tejun Heo
2012-01-19 1:49 ` Lennart Poettering
2012-01-18 21:28 ` Kay Sievers
2012-01-18 21:36 ` Tejun Heo
2012-01-19 1:47 ` Lennart Poettering
2012-01-19 2:20 ` Tejun Heo [this message]
2012-01-19 2:40 ` Tejun Heo
2012-01-21 3:02 ` Lennart Poettering
2012-01-21 4:00 ` Hugh Dickins
2012-01-21 2:59 ` Lennart Poettering
2012-01-18 7:23 ` [PATCH 1/2] cgroup: revise how we re-populate root directory Sha
2012-01-18 7:59 ` Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120119022005.GG21533@google.com \
--to=tj@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=mzxreary@0pointer.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).