Re: [RFC] syscalls, x86: Add __NR_kcmp syscall

From: Cyrill Gorcunov <gorcunov@gmail.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Pavel Emelyanov <xemul@parallels.com>,
	KOSAKI Motohiro <kosaki.motohiro@gmail.com>
Cc: david@lang.hm, Alexey Dobriyan <adobriyan@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Andrey Vagin <avagin@openvz.org>, Ingo Molnar <mingo@elte.hu>,
	Thomas Gleixner <tglx@linutronix.de>,
	Glauber Costa <glommer@parallels.com>,
	Andi Kleen <andi@firstfloor.org>, Tejun Heo <tj@kernel.org>,
	Matt Helsley <matthltc@us.ibm.com>,
	Pekka Enberg <penberg@kernel.org>,
	Eric Dumazet <eric.dumazet@gmail.com>,
	Vasiliy Kulikov <segoon@openwall.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Valdis.Kletnieks@vt.edu
Subject: Re: [RFC] syscalls, x86: Add __NR_kcmp syscall
Date: Fri, 20 Jan 2012 13:02:25 +0400	[thread overview]
Message-ID: <20120120090225.GD2786@moon> (raw)
In-Reply-To: <20120120084008.GD1954@moon>

On Fri, Jan 20, 2012 at 12:40:08PM +0400, Cyrill Gorcunov wrote:
...
> +
> +static __init int kcmp_cookie_init(void)
> +{
> +	int i, j;
> +
> +	for (i = 0; i < KCMP_TYPES; i++) {
> +		for (j = 0; j < 2; j++) {
> +			get_random_bytes(&cookies[i][j], sizeof(cookies[i][j]));
> +
> +			if (cookies[i][j])
> +				continue;
> +
> +			/*
> +			 * This is impossible case but just to be sure.
> +			 */
> +			cookies_valid = false;
> +			WARN_ONCE(1, "Can't get random bytes for k-pointers\n");
> +		}
> +	}
> +
> +	cookies_valid = true;

darn, this string of course should be on top,
i'll update don't complain on this nit.

> +
> +	return 0;
> +}

	Cyrill