From: ebiederm@xmission.com (Eric W. Biederman)
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
Alexey Dobriyan <adobriyan@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
Pavel Emelyanov <xemul@parallels.com>,
Andrey Vagin <avagin@openvz.org>, Ingo Molnar <mingo@elte.hu>,
Thomas Gleixner <tglx@linutronix.de>,
Glauber Costa <glommer@parallels.com>,
Andi Kleen <andi@firstfloor.org>, Tejun Heo <tj@kernel.org>,
Matt Helsley <matthltc@us.ibm.com>,
Pekka Enberg <penberg@kernel.org>,
Eric Dumazet <eric.dumazet@gmail.com>,
Vasiliy Kulikov <segoon@openwall.com>,
Andrew Morton <akpm@linux-foundation.org>,
Valdis.Kletnieks@vt.edu
Subject: Re: [RFC] syscalls, x86: Add __NR_kcmp syscall
Date: Tue, 17 Jan 2012 13:40:53 -0800 [thread overview]
Message-ID: <m1fwfe9fdm.fsf@fess.ebiederm.org> (raw)
In-Reply-To: <20120117211521.GP16213@moon> (Cyrill Gorcunov's message of "Wed, 18 Jan 2012 01:15:21 +0400")
Cyrill Gorcunov <gorcunov@gmail.com> writes:
> On Tue, Jan 17, 2012 at 10:47:37AM -0800, H. Peter Anvin wrote:
>> On 01/17/2012 06:44 AM, Cyrill Gorcunov wrote:
>> > On Tue, Jan 17, 2012 at 04:38:14PM +0200, Alexey Dobriyan wrote:
>> >> On 1/17/12, Cyrill Gorcunov <gorcunov@gmail.com> wrote:
>> >>> +#define KCMP_EQ 0
>> >>> +#define KCMP_LT 1
>> >>> +#define KCMP_GT 2
>> >>
>> >> LT and GT are meaningless.
>> >>
>> >
>> > I found symbolic names better than open-coded values. But sure,
>> > if this is problem it could be dropped.
>> >
>> > Or you mean that in general anything but 'equal' is useless?
>> >
>>
>> Why on Earth would user space need to know which order in memory certain
>> kernel objects are?
>>
>> Keep in mind that this is *exactly* the kind of information which makes
>> rootkits easier.
>>
>
> Hmm, indeed this might help narrow down the target address I fear. So
> after some conversation with Pavel I think we can try to live with just
> one result -- is objects are at same location in kernel memory or not.
> The updated version is below. Please review if you get a chance. Thanks
> a lot for comments!
Seriously?
Or is this a case where you get something in then when people start
seriously using it and the performance is sucks badly you go back to
something like the current system call?
How are you going to ensure the performance does not degrade badly when
looking across a large number of processes?
Eric
next prev parent reply other threads:[~2012-01-17 21:38 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-17 14:27 [RFC] syscalls, x86: Add __NR_kcmp syscall Cyrill Gorcunov
2012-01-17 14:38 ` Alexey Dobriyan
2012-01-17 14:44 ` Cyrill Gorcunov
2012-01-17 18:47 ` H. Peter Anvin
2012-01-17 21:15 ` Cyrill Gorcunov
2012-01-17 21:40 ` Eric W. Biederman [this message]
2012-01-18 5:07 ` Pavel Emelyanov
2012-01-17 21:35 ` Eric W. Biederman
2012-01-18 8:01 ` Cyrill Gorcunov
2012-01-18 9:12 ` KOSAKI Motohiro
2012-01-18 9:19 ` Pavel Emelyanov
2012-01-18 9:23 ` KOSAKI Motohiro
2012-01-18 11:57 ` Cyrill Gorcunov
2012-01-18 16:46 ` KOSAKI Motohiro
2012-01-18 17:20 ` Cyrill Gorcunov
2012-01-18 22:05 ` david
2012-01-18 22:49 ` Cyrill Gorcunov
2012-01-18 23:29 ` Eric W. Biederman
2012-01-19 6:55 ` Cyrill Gorcunov
2012-01-20 3:16 ` Eric W. Biederman
2012-01-20 8:40 ` Cyrill Gorcunov
2012-01-20 9:02 ` Cyrill Gorcunov
2012-01-20 14:51 ` H. Peter Anvin
2012-01-20 16:29 ` Cyrill Gorcunov
2012-01-20 16:57 ` H. Peter Anvin
2012-01-20 18:19 ` Cyrill Gorcunov
2012-01-20 18:22 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1fwfe9fdm.fsf@fess.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=avagin@openvz.org \
--cc=eric.dumazet@gmail.com \
--cc=glommer@parallels.com \
--cc=gorcunov@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthltc@us.ibm.com \
--cc=mingo@elte.hu \
--cc=penberg@kernel.org \
--cc=segoon@openwall.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).