* [PATCH 1/6] hda_intel: Add Lynx Point HD Audio Controller DeviceIDs
@ 2012-01-24 0:24 Seth Heasley
2012-01-24 9:45 ` [alsa-devel] " David Henningsson
0 siblings, 1 reply; 7+ messages in thread
From: Seth Heasley @ 2012-01-24 0:24 UTC (permalink / raw)
To: tiwai, alsa-devel, perex; +Cc: linux-kernel, james.d.ralston, seth.heasley
This patch adds the HD Audio DeviceIDs for the Intel Lynx Point PCH.
Signed-off-by: Seth Heasley <seth.heasley@intel.com>
---
sound/pci/hda/hda_intel.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
index 0852e20..adb4fa7 100644
--- a/sound/pci/hda/hda_intel.c
+++ b/sound/pci/hda/hda_intel.c
@@ -148,6 +148,7 @@ MODULE_SUPPORTED_DEVICE("{{Intel, ICH6},"
"{Intel, PCH},"
"{Intel, CPT},"
"{Intel, PPT},"
+ "{Intel, LPT},"
"{Intel, PBG},"
"{Intel, SCH},"
"{ATI, SB450},"
@@ -2989,6 +2990,10 @@ static DEFINE_PCI_DEVICE_TABLE(azx_ids) = {
{ PCI_DEVICE(0x8086, 0x1e20),
.driver_data = AZX_DRIVER_PCH | AZX_DCAPS_SCH_SNOOP |
AZX_DCAPS_BUFSIZE},
+ /* Lynx Point */
+ { PCI_DEVICE(0x8086, 0x8c20),
+ .driver_data = AZX_DRIVER_PCH | AZX_DCAPS_SCH_SNOOP |
+ AZX_DCAPS_BUFSIZE},
/* SCH */
{ PCI_DEVICE(0x8086, 0x811b),
.driver_data = AZX_DRIVER_SCH | AZX_DCAPS_SCH_SNOOP |
--
1.7.4.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [alsa-devel] [PATCH 1/6] hda_intel: Add Lynx Point HD Audio Controller DeviceIDs
2012-01-24 0:24 [PATCH 1/6] hda_intel: Add Lynx Point HD Audio Controller DeviceIDs Seth Heasley
@ 2012-01-24 9:45 ` David Henningsson
2012-01-24 9:54 ` Takashi Iwai
0 siblings, 1 reply; 7+ messages in thread
From: David Henningsson @ 2012-01-24 9:45 UTC (permalink / raw)
To: Seth Heasley; +Cc: tiwai, alsa-devel, perex, james.d.ralston, linux-kernel
On 01/24/2012 01:24 AM, Seth Heasley wrote:
> This patch adds the HD Audio DeviceIDs for the Intel Lynx Point PCH.
Thanks. As we asked for oak trail: can you confirm you prefer DMA
Position buffers for detecting current playback/recording position, over
using the LPIB register?
Also; these types of quirks should have a line "Cc: stable@kernel.org"
added to their commit messages, that will make it automatically be
applied to some of the older kernels in due time.
>
> Signed-off-by: Seth Heasley<seth.heasley@intel.com>
> ---
> sound/pci/hda/hda_intel.c | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
> index 0852e20..adb4fa7 100644
> --- a/sound/pci/hda/hda_intel.c
> +++ b/sound/pci/hda/hda_intel.c
> @@ -148,6 +148,7 @@ MODULE_SUPPORTED_DEVICE("{{Intel, ICH6},"
> "{Intel, PCH},"
> "{Intel, CPT},"
> "{Intel, PPT},"
> + "{Intel, LPT},"
> "{Intel, PBG},"
> "{Intel, SCH},"
> "{ATI, SB450},"
> @@ -2989,6 +2990,10 @@ static DEFINE_PCI_DEVICE_TABLE(azx_ids) = {
> { PCI_DEVICE(0x8086, 0x1e20),
> .driver_data = AZX_DRIVER_PCH | AZX_DCAPS_SCH_SNOOP |
> AZX_DCAPS_BUFSIZE},
> + /* Lynx Point */
> + { PCI_DEVICE(0x8086, 0x8c20),
> + .driver_data = AZX_DRIVER_PCH | AZX_DCAPS_SCH_SNOOP |
> + AZX_DCAPS_BUFSIZE},
> /* SCH */
> { PCI_DEVICE(0x8086, 0x811b),
> .driver_data = AZX_DRIVER_SCH | AZX_DCAPS_SCH_SNOOP |
--
David Henningsson, Canonical Ltd.
http://launchpad.net/~diwic
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [alsa-devel] [PATCH 1/6] hda_intel: Add Lynx Point HD Audio Controller DeviceIDs
2012-01-24 9:45 ` [alsa-devel] " David Henningsson
@ 2012-01-24 9:54 ` Takashi Iwai
2012-02-07 0:13 ` Heasley, Seth
0 siblings, 1 reply; 7+ messages in thread
From: Takashi Iwai @ 2012-01-24 9:54 UTC (permalink / raw)
To: David Henningsson
Cc: Seth Heasley, alsa-devel, perex, james.d.ralston, linux-kernel
At Tue, 24 Jan 2012 10:45:36 +0100,
David Henningsson wrote:
>
> On 01/24/2012 01:24 AM, Seth Heasley wrote:
> > This patch adds the HD Audio DeviceIDs for the Intel Lynx Point PCH.
>
> Thanks. As we asked for oak trail: can you confirm you prefer DMA
> Position buffers for detecting current playback/recording position, over
> using the LPIB register?
Yes, thanks for the notice.
I guess this won't need it since it's the successor of PPT.
But it's always good to check it for the new hardware, indeed.
Takashi
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [alsa-devel] [PATCH 1/6] hda_intel: Add Lynx Point HD Audio Controller DeviceIDs
2012-01-24 9:54 ` Takashi Iwai
@ 2012-02-07 0:13 ` Heasley, Seth
2012-02-07 4:51 ` David Henningsson
0 siblings, 1 reply; 7+ messages in thread
From: Heasley, Seth @ 2012-02-07 0:13 UTC (permalink / raw)
To: Takashi Iwai, David Henningsson
Cc: alsa-devel, perex, Ralston, James D, linux-kernel
>> > This patch adds the HD Audio DeviceIDs for the Intel Lynx Point PCH.
>>
>> Thanks. As we asked for oak trail: can you confirm you prefer DMA
>> Position buffers for detecting current playback/recording position,
>over
>> using the LPIB register?
>
>Yes, thanks for the notice.
>
>I guess this won't need it since it's the successor of PPT.
>But it's always good to check it for the new hardware, indeed.
I'm also in favor of not rocking the boat, but I'm curious what changing this would entail, and what would be the advantage or rationale for making the change?
-Seth
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [alsa-devel] [PATCH 1/6] hda_intel: Add Lynx Point HD Audio Controller DeviceIDs
2012-02-07 0:13 ` Heasley, Seth
@ 2012-02-07 4:51 ` David Henningsson
2012-02-08 0:35 ` Heasley, Seth
0 siblings, 1 reply; 7+ messages in thread
From: David Henningsson @ 2012-02-07 4:51 UTC (permalink / raw)
To: Heasley, Seth
Cc: Takashi Iwai, alsa-devel, perex, Ralston, James D, linux-kernel
On 02/07/2012 01:13 AM, Heasley, Seth wrote:
>>>> This patch adds the HD Audio DeviceIDs for the Intel Lynx Point PCH.
>>>
>>> Thanks. As we asked for oak trail: can you confirm you prefer DMA
>>> Position buffers for detecting current playback/recording position,
>> over
>>> using the LPIB register?
>>
>> Yes, thanks for the notice.
>>
>> I guess this won't need it since it's the successor of PPT.
>> But it's always good to check it for the new hardware, indeed.
>
> I'm also in favor of not rocking the boat, but I'm curious what changing this would entail, and what would be the advantage or rationale for making the change?
Reading the LPIB register, and reading the DMA position buffer, are two
different methods of reading the current playback (or recording)
position, i e which sample is currently being played back.
The problem is that some chipsets prefer one method over the other, i e,
only one of the methods work reliably. And if the other method only
breaks occasionally, this can be quite difficult to detect and track
down - we will have users complaining about their audio sometimes either
sounding distorted, maybe not working at all, or just once in a while
glitches. All of these symptoms can have many causes, so deducing that
to a broken playback position is time consuming. That's why I think it's
worth the extra question, to get it right from the start.
So...thanks in advance for looking it up for us? :-)
--
David Henningsson, Canonical Ltd.
http://launchpad.net/~diwic
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [alsa-devel] [PATCH 1/6] hda_intel: Add Lynx Point HD Audio Controller DeviceIDs
2012-02-07 4:51 ` David Henningsson
@ 2012-02-08 0:35 ` Heasley, Seth
2012-02-08 8:30 ` Takashi Iwai
0 siblings, 1 reply; 7+ messages in thread
From: Heasley, Seth @ 2012-02-08 0:35 UTC (permalink / raw)
To: David Henningsson
Cc: Takashi Iwai, alsa-devel, perex, Ralston, James D, linux-kernel
>> I'm also in favor of not rocking the boat, but I'm curious what
>changing this would entail, and what would be the advantage or rationale
>for making the change?
>
>Reading the LPIB register, and reading the DMA position buffer, are two
>different methods of reading the current playback (or recording)
>position, i e which sample is currently being played back.
>
>The problem is that some chipsets prefer one method over the other, i e,
>only one of the methods work reliably. And if the other method only
>breaks occasionally, this can be quite difficult to detect and track
>down - we will have users complaining about their audio sometimes either
>sounding distorted, maybe not working at all, or just once in a while
>glitches. All of these symptoms can have many causes, so deducing that
>to a broken playback position is time consuming. That's why I think it's
>worth the extra question, to get it right from the start.
>
>So...thanks in advance for looking it up for us? :-)
I'm inquiring about it, but I can say that it seems to work just fine using the DMA position buffer.
-Seth
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [alsa-devel] [PATCH 1/6] hda_intel: Add Lynx Point HD Audio Controller DeviceIDs
2012-02-08 0:35 ` Heasley, Seth
@ 2012-02-08 8:30 ` Takashi Iwai
0 siblings, 0 replies; 7+ messages in thread
From: Takashi Iwai @ 2012-02-08 8:30 UTC (permalink / raw)
To: Heasley, Seth
Cc: David Henningsson, alsa-devel, perex, Ralston, James D, linux-kernel
At Wed, 8 Feb 2012 00:35:33 +0000,
Heasley, Seth wrote:
>
> >> I'm also in favor of not rocking the boat, but I'm curious what
> >changing this would entail, and what would be the advantage or rationale
> >for making the change?
> >
> >Reading the LPIB register, and reading the DMA position buffer, are two
> >different methods of reading the current playback (or recording)
> >position, i e which sample is currently being played back.
> >
> >The problem is that some chipsets prefer one method over the other, i e,
> >only one of the methods work reliably. And if the other method only
> >breaks occasionally, this can be quite difficult to detect and track
> >down - we will have users complaining about their audio sometimes either
> >sounding distorted, maybe not working at all, or just once in a while
> >glitches. All of these symptoms can have many causes, so deducing that
> >to a broken playback position is time consuming. That's why I think it's
> >worth the extra question, to get it right from the start.
> >
> >So...thanks in advance for looking it up for us? :-)
>
> I'm inquiring about it, but I can say that it seems to work just fine using the DMA position buffer.
OK, I merged the patch now as is.
Please let me know if you find a problem.
thanks,
Takashi
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2012-02-08 8:30 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-01-24 0:24 [PATCH 1/6] hda_intel: Add Lynx Point HD Audio Controller DeviceIDs Seth Heasley
2012-01-24 9:45 ` [alsa-devel] " David Henningsson
2012-01-24 9:54 ` Takashi Iwai
2012-02-07 0:13 ` Heasley, Seth
2012-02-07 4:51 ` David Henningsson
2012-02-08 0:35 ` Heasley, Seth
2012-02-08 8:30 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).