From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Liam Girdwood <lrg@ti.com>, Lars-Peter Clausen <lars@metafoo.de>
Subject: Re: [PATCH 1/3] regmap: Properly round reg_bytes and val_bytes
Date: Fri, 27 Jan 2012 16:28:37 +0000 [thread overview]
Message-ID: <20120127162837.GB18572@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1327677023-29310-1-git-send-email-w.sang@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 569 bytes --]
On Fri, Jan 27, 2012 at 04:10:21PM +0100, Wolfram Sang wrote:
> For the upcoming 2/6-format, we don't see debugfs output otherwise,
> since the current division results in 0. I'd think 10/14 is broken
> currently, too.
This looks good but could you please rebase on top of topic/core, it
conflicts with the support for padding bytes. It's not really entirely
incorrect, the bytes values aren't terribly well defined for register
sizes that aren't integer numbers of bytes as they were never intended
to be used then. The assumption did leak out into debugfs though.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-01-27 16:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-27 15:10 [PATCH 1/3] regmap: Properly round reg_bytes and val_bytes Wolfram Sang
2012-01-27 15:10 ` [PATCH 2/3] regmap: Add support for 2/6 register formating Wolfram Sang
2012-01-27 16:28 ` Mark Brown
2012-01-27 15:10 ` [PATCH 3/3] ASoC: codecs: add driver for max9768 amplifier Wolfram Sang
2012-01-27 16:25 ` Mark Brown
2012-01-30 21:54 ` [alsa-devel] " Mark Brown
2012-01-27 16:28 ` Mark Brown [this message]
2012-01-28 1:14 ` [PATCH 1/3] regmap: Properly round reg_bytes and val_bytes Wolfram Sang
2012-01-30 13:21 ` Mark Brown
2012-01-30 13:35 ` Wolfram Sang
2012-01-30 13:45 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120127162837.GB18572@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).