From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Liam Girdwood <lrg@ti.com>, Lars-Peter Clausen <lars@metafoo.de>
Subject: Re: [PATCH 1/3] regmap: Properly round reg_bytes and val_bytes
Date: Mon, 30 Jan 2012 13:21:34 +0000 [thread overview]
Message-ID: <20120130132134.GB4882@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20120128011403.GA6669@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 809 bytes --]
On Sat, Jan 28, 2012 at 02:14:03AM +0100, Wolfram Sang wrote:
> I wondered if you'd save reg_bits and val_bits there (converting to *_bytes
> when needed), you could replace all the format_x_y-functions with a few generic
> functions doing (reg << y) | val. Unsure if it is worth it...
Clearly we *can* but there's other bits (chiefly the cache code once we
acquire the ability to do block operations from cache) which really want
stuff to be 8 bit aligned. I deliberately chose to make things byte
aligned so we have to think about this stuff before we do things that
make byte aligned stuff hard, it felt like if we were going to take a
complexity hit we probably want it to be on the odd register formats as
pretty much all of the more demanding modern devices seem to be going
for multiples of 8 bits.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-01-30 13:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-27 15:10 [PATCH 1/3] regmap: Properly round reg_bytes and val_bytes Wolfram Sang
2012-01-27 15:10 ` [PATCH 2/3] regmap: Add support for 2/6 register formating Wolfram Sang
2012-01-27 16:28 ` Mark Brown
2012-01-27 15:10 ` [PATCH 3/3] ASoC: codecs: add driver for max9768 amplifier Wolfram Sang
2012-01-27 16:25 ` Mark Brown
2012-01-30 21:54 ` [alsa-devel] " Mark Brown
2012-01-27 16:28 ` [PATCH 1/3] regmap: Properly round reg_bytes and val_bytes Mark Brown
2012-01-28 1:14 ` Wolfram Sang
2012-01-30 13:21 ` Mark Brown [this message]
2012-01-30 13:35 ` Wolfram Sang
2012-01-30 13:45 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120130132134.GB4882@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).