From: Greg KH <gregkh@suse.de>
To: Anton Vorontsov <anton.vorontsov@linaro.org>
Cc: "Arve Hjønnevåg" <arve@android.com>,
"KOSAKI Motohiro" <kosaki.motohiro@gmail.com>,
"San Mehat" <san@google.com>, "Colin Cross" <ccross@android.com>,
"Oleg Nesterov" <oleg@redhat.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
linux-kernel@vger.kernel.org, kernel-team@android.com,
linaro-kernel@lists.linaro.org
Subject: Re: [PATCH 1/3] procfs: Export next_tgid(), move it to kernel/pid.c
Date: Sun, 29 Jan 2012 18:22:42 -0800 [thread overview]
Message-ID: <20120130022242.GA5805@suse.de> (raw)
In-Reply-To: <20120130011323.GA30274@oksana.dev.rtsoft.ru>
On Mon, Jan 30, 2012 at 05:13:23AM +0400, Anton Vorontsov wrote:
> We'd like to use this function in the android low memory killer driver, so
> let's export it.
Why is it needed?
I _REALLY_ don't want to add any exports to any part of the kernel for
the android low memory stuff. That is because it is not something that
should be touching anything else, especially as numerous people disagree
with what it does and how it does it.
Instead, you should be spending the time and effort to properly
implement this, as has been discussed numerous times, the last one a
mere few weeks ago when someone tried adding the nokia-specific low
memory killer/notifier code.
So no, sorry, I will not take these patches, unless you come up with
some very good justifications why.
greg k-h
next prev parent reply other threads:[~2012-01-30 2:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-30 1:13 [PATCH 1/3] procfs: Export next_tgid(), move it to kernel/pid.c Anton Vorontsov
2012-01-30 2:22 ` Greg KH [this message]
2012-01-30 19:50 ` Anton Vorontsov
2012-01-30 3:26 ` Eric W. Biederman
2012-01-30 19:51 ` Anton Vorontsov
2012-01-30 13:43 ` Oleg Nesterov
2012-01-30 20:49 ` Anton Vorontsov
2012-01-31 1:51 ` Eric W. Biederman
2012-02-01 4:19 ` Anton Vorontsov
2012-02-01 4:37 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120130022242.GA5805@suse.de \
--to=gregkh@suse.de \
--cc=anton.vorontsov@linaro.org \
--cc=arve@android.com \
--cc=ccross@android.com \
--cc=ebiederm@xmission.com \
--cc=kernel-team@android.com \
--cc=kosaki.motohiro@gmail.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=san@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).