linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Christoph Lameter <cl@linux.com>
Cc: Dmitry Antipov <dmitry.antipov@linaro.org>,
	Rusty Russell <rusty@rustcorp.com.au>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	patches@linaro.org, linaro-dev@lists.linaro.org
Subject: Re: [PATCH 1/3] percpu: use ZERO_SIZE_PTR / ZERO_OR_NULL_PTR
Date: Mon, 30 Jan 2012 09:42:56 -0800	[thread overview]
Message-ID: <20120130174256.GF3355@google.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1201301121330.28693@router.home>

On Mon, Jan 30, 2012 at 11:22:14AM -0600, Christoph Lameter wrote:
> On Mon, 30 Jan 2012, Tejun Heo wrote:
> 
> > Percpu pointers are in a different address space and using
> > ZERO_SIZE_PTR directly will trigger sparse address space warning.
> > Also, I'm not entirely sure whether 16 is guaranteed to be unused in
> > percpu address space (maybe it is but I don't think we have anything
> > enforcing that).
> 
> We are already checking for NULL on free. So there is a presumption that
> these numbers are unused.

Yes, we probably don't use 16 as valid dynamic address because static
area would be larger than that.  It's just fuzzier than NULL.  And, as
I wrote in another reply, ZERO_SIZE_PTR simply doesn't contribute
anything.  Maybe we can update the allocator to always not use the
lowest 4k for either static or dynamic and add debug code to
translation macros to check for percpu addresses < 4k, but without
such changes ZERO_SIZE_PTR simply doesn't do anything.

Thanks.

-- 
tejun

  reply	other threads:[~2012-01-30 17:43 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-30  8:37 [PATCH 1/3] percpu: use ZERO_SIZE_PTR / ZERO_OR_NULL_PTR Dmitry Antipov
2012-01-30 16:15 ` Christoph Lameter
2012-01-30 17:15 ` Tejun Heo
2012-01-30 17:19   ` Tejun Heo
2012-01-30 17:22     ` Christoph Lameter
2012-01-30 17:33       ` Tejun Heo
2012-01-30 17:35         ` Christoph Lameter
2012-01-30 17:22   ` Christoph Lameter
2012-01-30 17:42     ` Tejun Heo [this message]
2012-01-30 17:52       ` Christoph Lameter
2012-01-30 17:54         ` Tejun Heo
2012-01-30 17:58           ` Christoph Lameter
2012-01-30 18:02             ` Tejun Heo
2012-01-30 18:12               ` Christoph Lameter
2012-01-30 18:16                 ` Tejun Heo
2012-01-31  4:48                   ` Rusty Russell
2012-01-30 18:13               ` Tejun Heo
2012-01-30 18:15                 ` Christoph Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120130174256.GF3355@google.com \
    --to=tj@kernel.org \
    --cc=cl@linux.com \
    --cc=dmitry.antipov@linaro.org \
    --cc=linaro-dev@lists.linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=patches@linaro.org \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).