linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH] power_supply: Fix modalias for charger-manager
@ 2012-01-11 11:23 함명주
  2012-02-01 17:40 ` Anton Vorontsov
  0 siblings, 1 reply; 3+ messages in thread
From: 함명주 @ 2012-01-11 11:23 UTC (permalink / raw)
  To: Axel Lin, linux-kernel
  Cc: Anton Vorontsov, 박경민, 김동근

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=euc-kr, Size: 1550 bytes --]

Written by Axel Lin<axel.lin@gmail.com>
> Since 43cc71eed1250755986da4c0f9898f9a635cb3bf, the platform
> modalias is prefixed with "platform:".
> Current code has the id_table, thus add MODULE_DEVICE_TABLE will
> automatically setup the modalias.
> 
> Also make charger_manager_id static as it is only used in this driver.
> 
> Signed-off-by: Axel Lin <axel.lin@gmail.com>

Thanks.

Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com>

> ---
>  drivers/power/charger-manager.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/power/charger-manager.c b/drivers/power/charger-manager.c
> index 0378d01..88fd971 100644
> --- a/drivers/power/charger-manager.c
> +++ b/drivers/power/charger-manager.c
> @@ -974,10 +974,11 @@ static int __devexit charger_manager_remove(struct platform_device *pdev)
>  	return 0;
>  }
>  
> -const struct platform_device_id charger_manager_id[] = {
> +static const struct platform_device_id charger_manager_id[] = {
>  	{ "charger-manager", 0 },
>  	{ },
>  };
> +MODULE_DEVICE_TABLE(platform, charger_manager_id);
>  
>  static int cm_suspend_prepare(struct device *dev)
>  {
> @@ -1069,4 +1070,3 @@ module_exit(charger_manager_cleanup);
>  MODULE_AUTHOR("MyungJoo Ham <myungjoo.ham@samsung.com>");
>  MODULE_DESCRIPTION("Charger Manager");
>  MODULE_LICENSE("GPL");
> -MODULE_ALIAS("charger-manager");
> -- 
> 1.7.5.4
> 
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] power_supply: Fix modalias for charger-manager
  2012-01-11 11:23 [PATCH] power_supply: Fix modalias for charger-manager 함명주
@ 2012-02-01 17:40 ` Anton Vorontsov
  0 siblings, 0 replies; 3+ messages in thread
From: Anton Vorontsov @ 2012-02-01 17:40 UTC (permalink / raw)
  To: 함명주
  Cc: Axel Lin, linux-kernel, 박경민,
	김동근

On Wed, Jan 11, 2012 at 11:23:17AM +0000, 함명주 wrote:
> Written by Axel Lin<axel.lin@gmail.com>
> > Since 43cc71eed1250755986da4c0f9898f9a635cb3bf, the platform
> > modalias is prefixed with "platform:".
> > Current code has the id_table, thus add MODULE_DEVICE_TABLE will
> > automatically setup the modalias.
> > 
> > Also make charger_manager_id static as it is only used in this driver.
> > 
> > Signed-off-by: Axel Lin <axel.lin@gmail.com>
> 
> Thanks.
> 
> Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com>

Applied, thanks!

-- 
Anton Vorontsov
Email: cbouatmailru@gmail.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] power_supply: Fix modalias for charger-manager
@ 2012-01-11  9:19 Axel Lin
  0 siblings, 0 replies; 3+ messages in thread
From: Axel Lin @ 2012-01-11  9:19 UTC (permalink / raw)
  To: linux-kernel; +Cc: MyungJoo Ham, Anton Vorontsov, Kyungmin Park, Donggeun Kim

Since 43cc71eed1250755986da4c0f9898f9a635cb3bf, the platform
modalias is prefixed with "platform:".
Current code has the id_table, thus add MODULE_DEVICE_TABLE will
automatically setup the modalias.

Also make charger_manager_id static as it is only used in this driver.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
 drivers/power/charger-manager.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/power/charger-manager.c b/drivers/power/charger-manager.c
index 0378d01..88fd971 100644
--- a/drivers/power/charger-manager.c
+++ b/drivers/power/charger-manager.c
@@ -974,10 +974,11 @@ static int __devexit charger_manager_remove(struct platform_device *pdev)
 	return 0;
 }
 
-const struct platform_device_id charger_manager_id[] = {
+static const struct platform_device_id charger_manager_id[] = {
 	{ "charger-manager", 0 },
 	{ },
 };
+MODULE_DEVICE_TABLE(platform, charger_manager_id);
 
 static int cm_suspend_prepare(struct device *dev)
 {
@@ -1069,4 +1070,3 @@ module_exit(charger_manager_cleanup);
 MODULE_AUTHOR("MyungJoo Ham <myungjoo.ham@samsung.com>");
 MODULE_DESCRIPTION("Charger Manager");
 MODULE_LICENSE("GPL");
-MODULE_ALIAS("charger-manager");
-- 
1.7.5.4




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-02-01 17:40 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-01-11 11:23 [PATCH] power_supply: Fix modalias for charger-manager 함명주
2012-02-01 17:40 ` Anton Vorontsov
  -- strict thread matches above, loose matches on Subject: below --
2012-01-11  9:19 Axel Lin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).