linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH RESEND] regulator: Remove redundant regmap_update_bits call for TPS65023_REG_CON_CTRL2
@ 2012-02-06 13:01 Axel Lin
  2012-02-06 16:40 ` Mark Brown
  0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2012-02-06 13:01 UTC (permalink / raw)
  To: linux-kernel; +Cc: Marcus Folkesson, Anuj Aggarwal, Mark Brown, Liam Girdwood

This looks like a merge mistake.  Calling regmap_update_bits once is enough.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
This resend fix a typo in the prefix of the subject.

 drivers/regulator/tps65023-regulator.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/drivers/regulator/tps65023-regulator.c b/drivers/regulator/tps65023-regulator.c
index 18d61a0..43e4902 100644
--- a/drivers/regulator/tps65023-regulator.c
+++ b/drivers/regulator/tps65023-regulator.c
@@ -491,10 +491,6 @@ static int __devinit tps_65023_probe(struct i2c_client *client,
 	regmap_update_bits(tps->regmap, TPS65023_REG_CON_CTRL2,
 			TPS65023_REG_CTRL2_CORE_ADJ, TPS65023_REG_CTRL2_CORE_ADJ);
 
-	/* Enable setting output voltage by I2C */
-	regmap_update_bits(tps->regmap, TPS65023_REG_CON_CTRL2,
-			TPS65023_REG_CTRL2_CORE_ADJ, TPS65023_REG_CTRL2_CORE_ADJ);
-
 	return 0;
 
  fail:
-- 
1.7.5.4




^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH RESEND] regulator: Remove redundant regmap_update_bits call for TPS65023_REG_CON_CTRL2
  2012-02-06 13:01 [PATCH RESEND] regulator: Remove redundant regmap_update_bits call for TPS65023_REG_CON_CTRL2 Axel Lin
@ 2012-02-06 16:40 ` Mark Brown
  0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2012-02-06 16:40 UTC (permalink / raw)
  To: Axel Lin; +Cc: linux-kernel, Marcus Folkesson, Anuj Aggarwal, Liam Girdwood

[-- Attachment #1: Type: text/plain, Size: 211 bytes --]

On Mon, Feb 06, 2012 at 09:01:14PM +0800, Axel Lin wrote:
> This looks like a merge mistake.  Calling regmap_update_bits once is enough.
> 
> Signed-off-by: Axel Lin <axel.lin@gmail.com>

Applied, thanks.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-02-06 16:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-02-06 13:01 [PATCH RESEND] regulator: Remove redundant regmap_update_bits call for TPS65023_REG_CON_CTRL2 Axel Lin
2012-02-06 16:40 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).