* Re: + proc-clean-up-proc-pid-environ-handling.patch added to -mm tree
@ 2012-02-08 15:15 Oleg Nesterov
2012-02-10 3:09 ` Cong Wang
0 siblings, 1 reply; 2+ messages in thread
From: Oleg Nesterov @ 2012-02-08 15:15 UTC (permalink / raw)
To: WANG Cong, Alexey Dobriyan, Andrew Morton; +Cc: linux-kernel
> From: Cong Wang <xiyou.wangcong@gmail.com>
> Subject: proc: clean up /proc/<pid>/environ handling
>
> Similar to e268337dfe2 ("proc: clean up and fix /proc/<pid>/mem
> handling"),
and has the same problem,
> move the check of permission to open(), this will simplify
> read() code.
but allows to kill the system trivially.
Please look at 6d08f2c7139790c268820a2e590795cb8333181a
"proc: make sure mem_open() doesn't pin the target's memory"
Oleg.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: + proc-clean-up-proc-pid-environ-handling.patch added to -mm tree
2012-02-08 15:15 + proc-clean-up-proc-pid-environ-handling.patch added to -mm tree Oleg Nesterov
@ 2012-02-10 3:09 ` Cong Wang
0 siblings, 0 replies; 2+ messages in thread
From: Cong Wang @ 2012-02-10 3:09 UTC (permalink / raw)
To: Oleg Nesterov; +Cc: Alexey Dobriyan, Andrew Morton, linux-kernel
On 02/08/2012 11:15 PM, Oleg Nesterov wrote:
>> From: Cong Wang<xiyou.wangcong@gmail.com>
>> Subject: proc: clean up /proc/<pid>/environ handling
>>
>> Similar to e268337dfe2 ("proc: clean up and fix /proc/<pid>/mem
>> handling"),
>
> and has the same problem,
>
>> move the check of permission to open(), this will simplify
>> read() code.
>
> but allows to kill the system trivially.
>
> Please look at 6d08f2c7139790c268820a2e590795cb8333181a
> "proc: make sure mem_open() doesn't pin the target's memory"
>
Thanks, I wasn't aware of that commit. I will send an updated patch soon.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-02-10 3:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-02-08 15:15 + proc-clean-up-proc-pid-environ-handling.patch added to -mm tree Oleg Nesterov
2012-02-10 3:09 ` Cong Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).