* [PATCH 2/2] autonuma: fix typo in blind balance
@ 2012-03-19 12:59 Hillf Danton
2012-03-19 17:35 ` Andrea Arcangeli
0 siblings, 1 reply; 2+ messages in thread
From: Hillf Danton @ 2012-03-19 12:59 UTC (permalink / raw)
To: Andrea Arcangeli; +Cc: LKML, Hillf Danton
Since it is certain that nid is not online in each round of for-loop,
it is replaced with given node id.
Signed-off-by: Hillf Danton <dhillf@gmail.com>
---
--- a/kernel/sched/numa.c Sat Mar 17 11:01:40 2012
+++ b/kernel/sched/numa.c Mon Mar 19 20:04:00 2012
@@ -34,7 +34,7 @@ static int autonuma_balance_blind(struct
selected_nid = cpu_nid;
nr_mm_max = 0;
- for_each_cpu_and(cpu, cpumask_of_node(nid), allowed) {
+ for_each_cpu_and(cpu, cpumask_of_node(cpu_nid), allowed) {
struct rq *rq = cpu_rq(cpu);
if (rq->curr->mm == mm)
nr_mm_max++;
--
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 2/2] autonuma: fix typo in blind balance
2012-03-19 12:59 [PATCH 2/2] autonuma: fix typo in blind balance Hillf Danton
@ 2012-03-19 17:35 ` Andrea Arcangeli
0 siblings, 0 replies; 2+ messages in thread
From: Andrea Arcangeli @ 2012-03-19 17:35 UTC (permalink / raw)
To: Hillf Danton; +Cc: LKML
On Mon, Mar 19, 2012 at 08:59:59PM +0800, Hillf Danton wrote:
> Since it is certain that nid is not online in each round of for-loop,
> it is replaced with given node id.
>
> Signed-off-by: Hillf Danton <dhillf@gmail.com>
> ---
>
> --- a/kernel/sched/numa.c Sat Mar 17 11:01:40 2012
> +++ b/kernel/sched/numa.c Mon Mar 19 20:04:00 2012
> @@ -34,7 +34,7 @@ static int autonuma_balance_blind(struct
> selected_nid = cpu_nid;
>
> nr_mm_max = 0;
> - for_each_cpu_and(cpu, cpumask_of_node(nid), allowed) {
> + for_each_cpu_and(cpu, cpumask_of_node(cpu_nid), allowed) {
> struct rq *rq = cpu_rq(cpu);
> if (rq->curr->mm == mm)
> nr_mm_max++;
Correct! gcc should have spwaned an unintialized warning too? I may
have broke it by accident with the editor after I disabled the
function. AUTONUMA_BALANCE_BLIND is not set so this function isn't
getting built right now.
I tried to keep enabled only the minimum, kind of stuff that if you
remove it, something will degrade significantly.
With the algorithms I developed before the current
sched_autonuma_balance, having autonuma_balance_blind made huge
difference, not anymore once I had something way better as a core
balancer, so then I considered autonuma_balance_blind more like an
hack and I disabled it.
I'm impressed how fast you found these two bugs, appreciated!
If you've high level opinions on the design, comments welcome.
Thanks,
Andrea
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-03-19 17:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-03-19 12:59 [PATCH 2/2] autonuma: fix typo in blind balance Hillf Danton
2012-03-19 17:35 ` Andrea Arcangeli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).