* [PATCH] xz: Enable BCJ filters on SPARC and 32-bit x86
@ 2012-03-19 18:34 Lasse Collin
0 siblings, 0 replies; 3+ messages in thread
From: Lasse Collin @ 2012-03-19 18:34 UTC (permalink / raw)
To: Linus Torvalds; +Cc: Jan Beulich, linux-kernel
From: Lasse Collin <lasse.collin@tukaani.org>
The BCJ filters were meant to be enabled already on these
archs, but the xz_wrap.sh script was buggy. Enabling the
filters should give smaller kernel images.
xz_wrap.sh will now use $SRCARCH instead of $ARCH to detect
the architecture. That way it doesn't need to care about the
subarchs (like i386 vs. x86_64) since the BCJ filters don't
care either.
Signed-off-by: Lasse Collin <lasse.collin@tukaani.org>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
I'm not sure if this should be fixed in stable kernels.
It's not a critical bug so maybe it is better to not
touch the stable kernels.
diff -uprN linux-3.3.orig/scripts/xz_wrap.sh linux-3.3/scripts/xz_wrap.sh
--- linux-3.3.orig/scripts/xz_wrap.sh 2012-03-19 01:15:34.000000000 +0200
+++ linux-3.3/scripts/xz_wrap.sh 2012-03-19 11:20:55.289074991 +0200
@@ -12,8 +12,8 @@
BCJ=
LZMA2OPTS=
-case $ARCH in
- x86|x86_64) BCJ=--x86 ;;
+case $SRCARCH in
+ x86) BCJ=--x86 ;;
powerpc) BCJ=--powerpc ;;
ia64) BCJ=--ia64; LZMA2OPTS=pb=4 ;;
arm) BCJ=--arm ;;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xz: Enable BCJ filters on SPARC and 32-bit x86
2012-04-18 16:55 Lasse Collin
@ 2012-04-18 17:05 ` H. Peter Anvin
0 siblings, 0 replies; 3+ messages in thread
From: H. Peter Anvin @ 2012-04-18 17:05 UTC (permalink / raw)
To: Lasse Collin; +Cc: Linus Torvalds, Jan Beulich, linux-kernel
On 04/18/2012 09:55 AM, Lasse Collin wrote:
> From: Lasse Collin <lasse.collin@tukaani.org>
>
> The BCJ filters were meant to be enabled already on these
> archs, but the xz_wrap.sh script was buggy. Enabling the
> filters should give smaller kernel images.
>
> xz_wrap.sh will now use $SRCARCH instead of $ARCH to detect
> the architecture. That way it doesn't need to care about the
> subarchs (like i386 vs. x86_64) since the BCJ filters don't
> care either.
>
> Signed-off-by: Lasse Collin <lasse.collin@tukaani.org>
> Acked-by: Jan Beulich <jbeulich@suse.com>
Acked-by: H. Peter Anvin <hpa@zytor.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] xz: Enable BCJ filters on SPARC and 32-bit x86
@ 2012-04-18 16:55 Lasse Collin
2012-04-18 17:05 ` H. Peter Anvin
0 siblings, 1 reply; 3+ messages in thread
From: Lasse Collin @ 2012-04-18 16:55 UTC (permalink / raw)
To: Linus Torvalds; +Cc: Jan Beulich, linux-kernel
From: Lasse Collin <lasse.collin@tukaani.org>
The BCJ filters were meant to be enabled already on these
archs, but the xz_wrap.sh script was buggy. Enabling the
filters should give smaller kernel images.
xz_wrap.sh will now use $SRCARCH instead of $ARCH to detect
the architecture. That way it doesn't need to care about the
subarchs (like i386 vs. x86_64) since the BCJ filters don't
care either.
Signed-off-by: Lasse Collin <lasse.collin@tukaani.org>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
diff -uprN linux-3.3.orig/scripts/xz_wrap.sh linux-3.3/scripts/xz_wrap.sh
--- linux-3.3.orig/scripts/xz_wrap.sh 2012-03-19 01:15:34.000000000 +0200
+++ linux-3.3/scripts/xz_wrap.sh 2012-03-19 11:20:55.289074991 +0200
@@ -12,8 +12,8 @@
BCJ=
LZMA2OPTS=
-case $ARCH in
- x86|x86_64) BCJ=--x86 ;;
+case $SRCARCH in
+ x86) BCJ=--x86 ;;
powerpc) BCJ=--powerpc ;;
ia64) BCJ=--ia64; LZMA2OPTS=pb=4 ;;
arm) BCJ=--arm ;;
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-04-18 17:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-03-19 18:34 [PATCH] xz: Enable BCJ filters on SPARC and 32-bit x86 Lasse Collin
2012-04-18 16:55 Lasse Collin
2012-04-18 17:05 ` H. Peter Anvin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).