* menuconfig looks funny since recently, i.e. USB gains on importance :)
@ 2012-03-30 10:00 Borislav Petkov
2012-03-30 10:55 ` Anatolij Gustschin
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Borislav Petkov @ 2012-03-30 10:00 UTC (permalink / raw)
To: Alan Stern, Greg Kroah-Hartman; +Cc: linux-usb, LKML
Hi guys,
Linus tree from today gives the following in menuconfig:
...
│ │ Graphics support --->
│ │ < > Sound card support --->
│ │ [*] HID Devices --->
│ │ [*] USB support --->
│ │ <*> Support for Host-side USB
│ │ [ ] USB verbose debug messages
│ │ [*] USB announce new devices
│ │ *** Miscellaneous USB options ***
│ │ [ ] USB device filesystem (DEPRECATED)
│ │ [ ] USB device class-devices (DEPRECATED)
│ │ [ ] Dynamic USB minor allocation
│ │ [*] USB runtime power management (autosuspend) and wakeup
│ │ [ ] OTG support
│ │ <*> USB Monitor
│ │ < > Support WUSB Cable Based Association (CBA)
│ │ *** USB Host Controller Drivers ***
│ │ < > Cypress C67x00 HCD support
│ │ <M> xHCI HCD (USB 3.0) support (EXPERIMENTAL)
│ │ [ ] Debugging for the xHCI host controller
│ │ <M> EHCI HCD (USB 2.0) support
│ │
│ │ [ ] Root Hub Transaction Translators
│ │ [ ] Improved Transaction Translator scheduling
│ │ < > OXU210HP HCD support
│ │ < > ISP116X HCD support
│ │ < > ISP 1760 HCD support
│ │ < > ISP1362 HCD support
│ │ <M> OHCI HCD support
...
This is the "Device Drivers" menu and all the USB-related options should
appear in the submenu "USB support" but they're merged with the "Device
Drivers" menu. Looks like someone funnied up Kconfig somewhere...
Thanks.
--
Regards/Gruss,
Boris.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: menuconfig looks funny since recently, i.e. USB gains on importance :)
2012-03-30 10:00 menuconfig looks funny since recently, i.e. USB gains on importance :) Borislav Petkov
@ 2012-03-30 10:55 ` Anatolij Gustschin
2012-03-30 11:05 ` [PATCH] Fix USB Kconfig Rupesh Gujare
2012-03-30 11:28 ` menuconfig looks funny since recently, i.e. USB gains on importance :) Jiri Kosina
2 siblings, 0 replies; 9+ messages in thread
From: Anatolij Gustschin @ 2012-03-30 10:55 UTC (permalink / raw)
To: Borislav Petkov; +Cc: Alan Stern, Greg Kroah-Hartman, linux-usb, LKML
On Fri, 30 Mar 2012 12:00:56 +0200
Borislav Petkov <bp@alien8.de> wrote:
...
> Linus tree from today gives the following in menuconfig:
Should be fixed by
http://marc.info/?l=linux-kernel&m=133245014825438&w=2
Thanks,
Anatolij
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] Fix USB Kconfig
2012-03-30 10:00 menuconfig looks funny since recently, i.e. USB gains on importance :) Borislav Petkov
2012-03-30 10:55 ` Anatolij Gustschin
@ 2012-03-30 11:05 ` Rupesh Gujare
2012-03-30 12:48 ` Borislav Petkov
2012-03-30 11:28 ` menuconfig looks funny since recently, i.e. USB gains on importance :) Jiri Kosina
2 siblings, 1 reply; 9+ messages in thread
From: Rupesh Gujare @ 2012-03-30 11:05 UTC (permalink / raw)
To: linux-kernel; +Cc: gregkh, linux-usb, Rupesh Gujare
Fix menuconfig option for USB.
Signed-off-by: Rupesh Gujare <rgujare@ozmodevices.com>
Reported-by: Borislav Petkov <bp@alien8.de>
---
drivers/usb/Kconfig | 14 +++++++-------
1 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig
index cbd8f5f..884f3fa 100644
--- a/drivers/usb/Kconfig
+++ b/drivers/usb/Kconfig
@@ -10,6 +10,13 @@ menuconfig USB_SUPPORT
This option adds core support for Universal Serial Bus (USB).
You will also need drivers from the following menu to make use of it.
+if USB_SUPPORT
+
+config USB_COMMON
+ tristate
+ default y
+ depends on USB || USB_GADGET
+
# many non-PCI SOC chips embed OHCI
config USB_ARCH_HAS_OHCI
boolean
@@ -63,13 +70,6 @@ config USB_ARCH_HAS_XHCI
boolean
default PCI
-if USB_SUPPORT
-
-config USB_COMMON
- tristate
- default y
- depends on USB || USB_GADGET
-
# Host-side USB depends on having a host controller
# NOTE: dummy_hcd is always an option, but it's ignored here ...
# NOTE: SL-811 option should be board-specific ...
--
1.7.5.4
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: menuconfig looks funny since recently, i.e. USB gains on importance :)
2012-03-30 10:00 menuconfig looks funny since recently, i.e. USB gains on importance :) Borislav Petkov
2012-03-30 10:55 ` Anatolij Gustschin
2012-03-30 11:05 ` [PATCH] Fix USB Kconfig Rupesh Gujare
@ 2012-03-30 11:28 ` Jiri Kosina
2012-03-30 12:27 ` Borislav Petkov
2 siblings, 1 reply; 9+ messages in thread
From: Jiri Kosina @ 2012-03-30 11:28 UTC (permalink / raw)
To: Borislav Petkov
Cc: Alan Stern, Greg Kroah-Hartman, linux-usb, LKML, David Daney
On Fri, 30 Mar 2012, Borislav Petkov wrote:
> Hi guys,
>
> Linus tree from today gives the following in menuconfig:
>
>
> ...
> │ │ Graphics support --->
> │ │ < > Sound card support --->
> │ │ [*] HID Devices --->
> │ │ [*] USB support --->
> │ │ <*> Support for Host-side USB
> │ │ [ ] USB verbose debug messages
> │ │ [*] USB announce new devices
> │ │ *** Miscellaneous USB options ***
> │ │ [ ] USB device filesystem (DEPRECATED)
> │ │ [ ] USB device class-devices (DEPRECATED)
> │ │ [ ] Dynamic USB minor allocation
> │ │ [*] USB runtime power management (autosuspend) and wakeup
> │ │ [ ] OTG support
> │ │ <*> USB Monitor
> │ │ < > Support WUSB Cable Based Association (CBA)
> │ │ *** USB Host Controller Drivers ***
> │ │ < > Cypress C67x00 HCD support
> │ │ <M> xHCI HCD (USB 3.0) support (EXPERIMENTAL)
> │ │ [ ] Debugging for the xHCI host controller
> │ │ <M> EHCI HCD (USB 2.0) support
> │ │
> │ │ [ ] Root Hub Transaction Translators
> │ │ [ ] Improved Transaction Translator scheduling
> │ │ < > OXU210HP HCD support
> │ │ < > ISP116X HCD support
> │ │ < > ISP 1760 HCD support
> │ │ < > ISP1362 HCD support
> │ │ <M> OHCI HCD support
> ...
>
> This is the "Device Drivers" menu and all the USB-related options should
> appear in the submenu "USB support" but they're merged with the "Device
> Drivers" menu. Looks like someone funnied up Kconfig somewhere...
Caued by 53c6bc24fdc, adding David Daney.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: menuconfig looks funny since recently, i.e. USB gains on importance :)
2012-03-30 11:28 ` menuconfig looks funny since recently, i.e. USB gains on importance :) Jiri Kosina
@ 2012-03-30 12:27 ` Borislav Petkov
2012-03-30 16:27 ` David Daney
0 siblings, 1 reply; 9+ messages in thread
From: Borislav Petkov @ 2012-03-30 12:27 UTC (permalink / raw)
To: Jiri Kosina
Cc: Alan Stern, Greg Kroah-Hartman, linux-usb, LKML, David Daney,
Anatolij Gustschin
On Fri, Mar 30, 2012 at 01:28:55PM +0200, Jiri Kosina wrote:
> Caued by 53c6bc24fdc, adding David Daney.
Thanks to all for the swift help, fixed by
http://marc.info/?l=linux-kernel&m=133245014825438&w=2
--
Regards/Gruss,
Boris.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] Fix USB Kconfig
2012-03-30 11:05 ` [PATCH] Fix USB Kconfig Rupesh Gujare
@ 2012-03-30 12:48 ` Borislav Petkov
2012-03-30 12:51 ` Rupesh Gujare
0 siblings, 1 reply; 9+ messages in thread
From: Borislav Petkov @ 2012-03-30 12:48 UTC (permalink / raw)
To: Rupesh Gujare; +Cc: linux-kernel, gregkh, linux-usb
On Fri, Mar 30, 2012 at 12:05:32PM +0100, Rupesh Gujare wrote:
> Fix menuconfig option for USB.
>
> Signed-off-by: Rupesh Gujare <rgujare@ozmodevices.com>
> Reported-by: Borislav Petkov <bp@alien8.de>
> ---
> drivers/usb/Kconfig | 14 +++++++-------
> 1 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig
> index cbd8f5f..884f3fa 100644
> --- a/drivers/usb/Kconfig
> +++ b/drivers/usb/Kconfig
> @@ -10,6 +10,13 @@ menuconfig USB_SUPPORT
> This option adds core support for Universal Serial Bus (USB).
> You will also need drivers from the following menu to make use of it.
>
> +if USB_SUPPORT
> +
> +config USB_COMMON
> + tristate
> + default y
> + depends on USB || USB_GADGET
> +
> # many non-PCI SOC chips embed OHCI
> config USB_ARCH_HAS_OHCI
> boolean
> @@ -63,13 +70,6 @@ config USB_ARCH_HAS_XHCI
> boolean
> default PCI
>
> -if USB_SUPPORT
> -
> -config USB_COMMON
> - tristate
> - default y
> - depends on USB || USB_GADGET
> -
> # Host-side USB depends on having a host controller
> # NOTE: dummy_hcd is always an option, but it's ignored here ...
> # NOTE: SL-811 option should be board-specific ...
Reportedly, there's a fix for this already, see thread at
http://marc.info/?l=linux-usb&m=133310173203793&w=2
Thanks.
--
Regards/Gruss,
Boris.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] Fix USB Kconfig
2012-03-30 12:48 ` Borislav Petkov
@ 2012-03-30 12:51 ` Rupesh Gujare
0 siblings, 0 replies; 9+ messages in thread
From: Rupesh Gujare @ 2012-03-30 12:51 UTC (permalink / raw)
To: Borislav Petkov, linux-kernel, gregkh, linux-usb
> Reportedly, there's a fix for this already, see thread at
> http://marc.info/?l=linux-usb&m=133310173203793&w=2
>
Thanks Boris,
I just realised it after sending a patch. :)
--
Regards,
Rupesh Guajre
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: menuconfig looks funny since recently, i.e. USB gains on importance :)
2012-03-30 12:27 ` Borislav Petkov
@ 2012-03-30 16:27 ` David Daney
2012-03-30 16:32 ` Greg Kroah-Hartman
0 siblings, 1 reply; 9+ messages in thread
From: David Daney @ 2012-03-30 16:27 UTC (permalink / raw)
To: Borislav Petkov, Jiri Kosina, Alan Stern, Greg Kroah-Hartman,
linux-usb, LKML, Anatolij Gustschin
On 03/30/2012 05:27 AM, Borislav Petkov wrote:
> On Fri, Mar 30, 2012 at 01:28:55PM +0200, Jiri Kosina wrote:
>> Caued by 53c6bc24fdc, adding David Daney.
>
> Thanks to all for the swift help, fixed by
> http://marc.info/?l=linux-kernel&m=133245014825438&w=2
>
That's right. One would hope Greg Kroah-Hartman would send that patch
on its way soon.
David Daney
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: menuconfig looks funny since recently, i.e. USB gains on importance :)
2012-03-30 16:27 ` David Daney
@ 2012-03-30 16:32 ` Greg Kroah-Hartman
0 siblings, 0 replies; 9+ messages in thread
From: Greg Kroah-Hartman @ 2012-03-30 16:32 UTC (permalink / raw)
To: David Daney
Cc: Borislav Petkov, Jiri Kosina, Alan Stern, linux-usb, LKML,
Anatolij Gustschin
On Fri, Mar 30, 2012 at 09:27:55AM -0700, David Daney wrote:
> On 03/30/2012 05:27 AM, Borislav Petkov wrote:
> >On Fri, Mar 30, 2012 at 01:28:55PM +0200, Jiri Kosina wrote:
> >>Caued by 53c6bc24fdc, adding David Daney.
> >
> >Thanks to all for the swift help, fixed by
> >http://marc.info/?l=linux-kernel&m=133245014825438&w=2
> >
>
> That's right. One would hope Greg Kroah-Hartman would send that
> patch on its way soon.
I will once 3.4-rc1 is out.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2012-03-30 16:33 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-03-30 10:00 menuconfig looks funny since recently, i.e. USB gains on importance :) Borislav Petkov
2012-03-30 10:55 ` Anatolij Gustschin
2012-03-30 11:05 ` [PATCH] Fix USB Kconfig Rupesh Gujare
2012-03-30 12:48 ` Borislav Petkov
2012-03-30 12:51 ` Rupesh Gujare
2012-03-30 11:28 ` menuconfig looks funny since recently, i.e. USB gains on importance :) Jiri Kosina
2012-03-30 12:27 ` Borislav Petkov
2012-03-30 16:27 ` David Daney
2012-03-30 16:32 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).