* [PATCH] KVM: MMU: use page table level macro
@ 2012-04-18 10:24 Davidlohr Bueso
2012-04-19 2:35 ` Marcelo Tosatti
0 siblings, 1 reply; 2+ messages in thread
From: Davidlohr Bueso @ 2012-04-18 10:24 UTC (permalink / raw)
To: Avi Kivity, Marcelo Tosatti; +Cc: KVM, lkml
From: Davidlohr Bueso <dave@gnu.org>
Its much cleaner to use PT_PAGE_TABLE_LEVEL than its numeric value.
Signed-off-by: Davidlohr Bueso <dave@gnu.org>
---
arch/x86/kvm/mmu.c | 2 +-
arch/x86/kvm/paging_tmpl.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
index 4cb1642..163a008 100644
--- a/arch/x86/kvm/mmu.c
+++ b/arch/x86/kvm/mmu.c
@@ -3554,7 +3554,7 @@ static bool detect_write_flooding(struct kvm_mmu_page *sp)
* Skip write-flooding detected for the sp whose level is 1, because
* it can become unsync, then the guest page is not write-protected.
*/
- if (sp->role.level == 1)
+ if (sp->role.level == PT_PAGE_TABLE_LEVEL)
return false;
return ++sp->write_flooding_count >= 3;
diff --git a/arch/x86/kvm/paging_tmpl.h b/arch/x86/kvm/paging_tmpl.h
index df5a703..34f9709 100644
--- a/arch/x86/kvm/paging_tmpl.h
+++ b/arch/x86/kvm/paging_tmpl.h
@@ -658,7 +658,7 @@ static gpa_t FNAME(get_level1_sp_gpa)(struct kvm_mmu_page *sp)
{
int offset = 0;
- WARN_ON(sp->role.level != 1);
+ WARN_ON(sp->role.level != PT_PAGE_TABLE_LEVEL);
if (PTTYPE == 32)
offset = sp->role.quadrant << PT64_LEVEL_BITS;
--
1.7.4.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] KVM: MMU: use page table level macro
2012-04-18 10:24 [PATCH] KVM: MMU: use page table level macro Davidlohr Bueso
@ 2012-04-19 2:35 ` Marcelo Tosatti
0 siblings, 0 replies; 2+ messages in thread
From: Marcelo Tosatti @ 2012-04-19 2:35 UTC (permalink / raw)
To: Davidlohr Bueso; +Cc: Avi Kivity, KVM, lkml
On Wed, Apr 18, 2012 at 12:24:29PM +0200, Davidlohr Bueso wrote:
> From: Davidlohr Bueso <dave@gnu.org>
>
> Its much cleaner to use PT_PAGE_TABLE_LEVEL than its numeric value.
>
> Signed-off-by: Davidlohr Bueso <dave@gnu.org>
> ---
> arch/x86/kvm/mmu.c | 2 +-
> arch/x86/kvm/paging_tmpl.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-04-19 2:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-18 10:24 [PATCH] KVM: MMU: use page table level macro Davidlohr Bueso
2012-04-19 2:35 ` Marcelo Tosatti
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).