From: Jonathan Nieder <jrnieder@gmail.com>
To: x86@kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, Ben Hutchings <ben@decadent.org.uk>,
Andreas Herrmann <andreas.herrmann3@amd.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Dave Jones <davej@redhat.com>
Subject: [PATCH resend v3] x86: memtest: WARN if bad RAM found
Date: Mon, 23 Apr 2012 13:26:30 -0500 [thread overview]
Message-ID: <20120423182630.GA13067@burratino> (raw)
In-Reply-To: <20120413193905.GD2387@burratino>
From: Ben Hutchings <ben@decadent.org.uk>
Date: Mon, 5 Dec 2011 04:00:58 +0000
The novice who enables CONFIG_MEMTEST may not realize that it is not a
particularly thorough test. If we find any bad bits of RAM then there
is a fair chance that there are other bad bits we fail to detect; add
a WARNING for this situation so people helping debug ensuing problems
can understand what happened.
The warning text gives advice to allow the sysadmin to run a more
thorough test and suppress the warning.
Bad RAM detected. Use memtest86+ to perform a thorough test
and the memmap= parameter to reserve the bad areas.
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
---
Jonathan Nieder wrote:
> The patch below last visited this list on 2 April, about a week and a
> half ago. No reply.
Are Ben and I the only ones who care either way about this change?
arch/x86/mm/memtest.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/x86/mm/memtest.c b/arch/x86/mm/memtest.c
index c80b9fb95734..38caeb44a218 100644
--- a/arch/x86/mm/memtest.c
+++ b/arch/x86/mm/memtest.c
@@ -30,6 +30,8 @@ static u64 patterns[] __initdata = {
static void __init reserve_bad_mem(u64 pattern, u64 start_bad, u64 end_bad)
{
+ WARN_ONCE(1, "Bad RAM detected. Use memtest86+ to perform a thorough test\n"
+ "and the memmap= parameter to reserve the bad areas.");
printk(KERN_INFO " %016llx bad mem addr %010llx - %010llx reserved\n",
(unsigned long long) pattern,
(unsigned long long) start_bad,
--
1.7.10
next prev parent reply other threads:[~2012-04-23 18:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-02 15:05 [PATCH] x86: memtest: WARN if bad RAM found Jonathan Nieder
2012-04-13 19:39 ` [PATCH resend] " Jonathan Nieder
2012-04-23 18:26 ` Jonathan Nieder [this message]
2012-04-23 20:26 ` [PATCH resend v3] " Yinghai Lu
2012-04-23 20:28 ` Jonathan Nieder
2012-04-23 22:13 ` Yinghai Lu
2012-04-24 2:50 ` [PATCH v4] " Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120423182630.GA13067@burratino \
--to=jrnieder@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andreas.herrmann3@amd.com \
--cc=ben@decadent.org.uk \
--cc=davej@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).