From: Yinghai Lu <yinghai@kernel.org>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: x86@kernel.org, Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, Ben Hutchings <ben@decadent.org.uk>,
Andreas Herrmann <andreas.herrmann3@amd.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Dave Jones <davej@redhat.com>
Subject: Re: [PATCH resend v3] x86: memtest: WARN if bad RAM found
Date: Mon, 23 Apr 2012 15:13:13 -0700 [thread overview]
Message-ID: <CAE9FiQVaThbo0oQZThc9JdEtu53CWfBvFAH6Sc9bpkwFSVAFiw@mail.gmail.com> (raw)
In-Reply-To: <20120423202839.GA14147@burratino>
On Mon, Apr 23, 2012 at 1:28 PM, Jonathan Nieder <jrnieder@gmail.com> wrote:
> Yinghai Lu wrote:
>> On Mon, Apr 23, 2012 at 11:26 AM, Jonathan Nieder <jrnieder@gmail.com> wrote:
>
>>> --- a/arch/x86/mm/memtest.c
>>> +++ b/arch/x86/mm/memtest.c
>>> @@ -30,6 +30,8 @@ static u64 patterns[] __initdata = {
>>>
>>> static void __init reserve_bad_mem(u64 pattern, u64 start_bad, u64 end_bad)
>>> {
>>> + WARN_ONCE(1, "Bad RAM detected. Use memtest86+ to perform a thorough test\n"
>>> + "and the memmap= parameter to reserve the bad areas.");
>>
>> You must be kidding : calling memtest86+ "thorough test".
>
> How about "more thorough test"? Or do you have a better
> recommendation for users?
The reason for adding early_memtest is for debug purpose.
Sometimes BIOS mess up setting, on some booting memory is ok, but
other booting the memory is not initialized properly.
in that case: preboot memtest tools is not going to help.
also preboot memtest tools and early_memtest is not stressed enough.
--- only one process is running.
Need to run memtester multiple instances to test your memory and systems.
Yinghai
next prev parent reply other threads:[~2012-04-23 22:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-02 15:05 [PATCH] x86: memtest: WARN if bad RAM found Jonathan Nieder
2012-04-13 19:39 ` [PATCH resend] " Jonathan Nieder
2012-04-23 18:26 ` [PATCH resend v3] " Jonathan Nieder
2012-04-23 20:26 ` Yinghai Lu
2012-04-23 20:28 ` Jonathan Nieder
2012-04-23 22:13 ` Yinghai Lu [this message]
2012-04-24 2:50 ` [PATCH v4] " Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAE9FiQVaThbo0oQZThc9JdEtu53CWfBvFAH6Sc9bpkwFSVAFiw@mail.gmail.com \
--to=yinghai@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=andreas.herrmann3@amd.com \
--cc=ben@decadent.org.uk \
--cc=davej@redhat.com \
--cc=hpa@zytor.com \
--cc=jrnieder@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).