* [PATCH] drivers: staging: zcache: fix Kconfig crypto dependency
@ 2012-04-24 1:33 Seth Jennings
2012-04-24 2:09 ` Konrad Rzeszutek Wilk
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Seth Jennings @ 2012-04-24 1:33 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Seth Jennings, Dan Magenheimer, Konrad Rzeszutek Wilk,
Nitin Gupta, Robert Jennings, devel, linux-kernel, linux-mm,
Autif Khan
ZCACHE is a boolean in the Kconfig. When selected, it
should require that CRYPTO be builtin (=y).
Currently, ZCACHE=y and CRYPTO=m is a valid configuration
when it should not be.
This patch changes the zcache Kconfig to enforce this
dependency.
Signed-off-by: Seth Jennings <sjenning@linux.vnet.ibm.com>
---
drivers/staging/zcache/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/zcache/Kconfig b/drivers/staging/zcache/Kconfig
index 3ed2c8f..7048e01 100644
--- a/drivers/staging/zcache/Kconfig
+++ b/drivers/staging/zcache/Kconfig
@@ -2,7 +2,7 @@ config ZCACHE
bool "Dynamic compression of swap pages and clean pagecache pages"
# X86 dependency is because zsmalloc uses non-portable pte/tlb
# functions
- depends on (CLEANCACHE || FRONTSWAP) && CRYPTO && X86
+ depends on (CLEANCACHE || FRONTSWAP) && CRYPTO=y && X86
select ZSMALLOC
select CRYPTO_LZO
default n
--
1.7.5.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] drivers: staging: zcache: fix Kconfig crypto dependency
2012-04-24 1:33 [PATCH] drivers: staging: zcache: fix Kconfig crypto dependency Seth Jennings
@ 2012-04-24 2:09 ` Konrad Rzeszutek Wilk
2012-04-24 2:27 ` Greg Kroah-Hartman
2012-04-28 0:38 ` Randy Dunlap
2 siblings, 0 replies; 7+ messages in thread
From: Konrad Rzeszutek Wilk @ 2012-04-24 2:09 UTC (permalink / raw)
To: Seth Jennings
Cc: Greg Kroah-Hartman, Dan Magenheimer, Nitin Gupta,
Robert Jennings, devel, linux-kernel, linux-mm, Autif Khan
On Mon, Apr 23, 2012 at 08:33:50PM -0500, Seth Jennings wrote:
> ZCACHE is a boolean in the Kconfig. When selected, it
> should require that CRYPTO be builtin (=y).
Hey Greg,
Please push this to your tree at your convience. linux-next
folks found this combination breaks the build ..
>
> Currently, ZCACHE=y and CRYPTO=m is a valid configuration
> when it should not be.
>
> This patch changes the zcache Kconfig to enforce this
> dependency.
>
> Signed-off-by: Seth Jennings <sjenning@linux.vnet.ibm.com>
Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> ---
> drivers/staging/zcache/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/zcache/Kconfig b/drivers/staging/zcache/Kconfig
> index 3ed2c8f..7048e01 100644
> --- a/drivers/staging/zcache/Kconfig
> +++ b/drivers/staging/zcache/Kconfig
> @@ -2,7 +2,7 @@ config ZCACHE
> bool "Dynamic compression of swap pages and clean pagecache pages"
> # X86 dependency is because zsmalloc uses non-portable pte/tlb
> # functions
> - depends on (CLEANCACHE || FRONTSWAP) && CRYPTO && X86
> + depends on (CLEANCACHE || FRONTSWAP) && CRYPTO=y && X86
> select ZSMALLOC
> select CRYPTO_LZO
> default n
> --
> 1.7.5.4
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drivers: staging: zcache: fix Kconfig crypto dependency
2012-04-24 1:33 [PATCH] drivers: staging: zcache: fix Kconfig crypto dependency Seth Jennings
2012-04-24 2:09 ` Konrad Rzeszutek Wilk
@ 2012-04-24 2:27 ` Greg Kroah-Hartman
2012-04-24 13:30 ` Seth Jennings
2012-04-28 0:38 ` Randy Dunlap
2 siblings, 1 reply; 7+ messages in thread
From: Greg Kroah-Hartman @ 2012-04-24 2:27 UTC (permalink / raw)
To: Seth Jennings
Cc: Dan Magenheimer, Konrad Rzeszutek Wilk, Nitin Gupta,
Robert Jennings, devel, linux-kernel, linux-mm, Autif Khan
On Mon, Apr 23, 2012 at 08:33:50PM -0500, Seth Jennings wrote:
> ZCACHE is a boolean in the Kconfig. When selected, it
> should require that CRYPTO be builtin (=y).
>
> Currently, ZCACHE=y and CRYPTO=m is a valid configuration
> when it should not be.
>
> This patch changes the zcache Kconfig to enforce this
> dependency.
>
> Signed-off-by: Seth Jennings <sjenning@linux.vnet.ibm.com>
> ---
> drivers/staging/zcache/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/zcache/Kconfig b/drivers/staging/zcache/Kconfig
> index 3ed2c8f..7048e01 100644
> --- a/drivers/staging/zcache/Kconfig
> +++ b/drivers/staging/zcache/Kconfig
> @@ -2,7 +2,7 @@ config ZCACHE
> bool "Dynamic compression of swap pages and clean pagecache pages"
> # X86 dependency is because zsmalloc uses non-portable pte/tlb
> # functions
> - depends on (CLEANCACHE || FRONTSWAP) && CRYPTO && X86
> + depends on (CLEANCACHE || FRONTSWAP) && CRYPTO=y && X86
Ok, this fixes one of the build problems reported, what about the other
one?
greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drivers: staging: zcache: fix Kconfig crypto dependency
2012-04-24 2:27 ` Greg Kroah-Hartman
@ 2012-04-24 13:30 ` Seth Jennings
2012-04-24 14:35 ` Greg Kroah-Hartman
0 siblings, 1 reply; 7+ messages in thread
From: Seth Jennings @ 2012-04-24 13:30 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Dan Magenheimer, Konrad Rzeszutek Wilk, Nitin Gupta,
Robert Jennings, devel, linux-kernel, linux-mm, Autif Khan
On 04/23/2012 09:27 PM, Greg Kroah-Hartman wrote:
> Ok, this fixes one of the build problems reported, what about the other
> one?
Both problems that I heard about were caused by same issue;
the issue fixed in this patch.
ZSMALLOC=m was only allowed because CRYPTO=m was allowed.
This patch requires CRYPTO=y, which also requires ZSMALLOC=y
when ZCACHE=y.
https://lkml.org/lkml/2012/4/19/588
https://lkml.org/lkml/2012/4/23/481
Thanks,
Seth
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drivers: staging: zcache: fix Kconfig crypto dependency
2012-04-24 13:30 ` Seth Jennings
@ 2012-04-24 14:35 ` Greg Kroah-Hartman
0 siblings, 0 replies; 7+ messages in thread
From: Greg Kroah-Hartman @ 2012-04-24 14:35 UTC (permalink / raw)
To: Seth Jennings
Cc: devel, Dan Magenheimer, Autif Khan, Konrad Rzeszutek Wilk,
linux-kernel, linux-mm, Robert Jennings, Nitin Gupta
On Tue, Apr 24, 2012 at 08:30:28AM -0500, Seth Jennings wrote:
> On 04/23/2012 09:27 PM, Greg Kroah-Hartman wrote:
> > Ok, this fixes one of the build problems reported, what about the other
> > one?
>
> Both problems that I heard about were caused by same issue;
> the issue fixed in this patch.
>
> ZSMALLOC=m was only allowed because CRYPTO=m was allowed.
> This patch requires CRYPTO=y, which also requires ZSMALLOC=y
> when ZCACHE=y.
>
> https://lkml.org/lkml/2012/4/19/588
>
> https://lkml.org/lkml/2012/4/23/481
Ah, ok, I didn't realize that, thanks for letting me know, I'll queue
this up later today.
greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drivers: staging: zcache: fix Kconfig crypto dependency
2012-04-24 1:33 [PATCH] drivers: staging: zcache: fix Kconfig crypto dependency Seth Jennings
2012-04-24 2:09 ` Konrad Rzeszutek Wilk
2012-04-24 2:27 ` Greg Kroah-Hartman
@ 2012-04-28 0:38 ` Randy Dunlap
2012-05-03 21:11 ` Dan Magenheimer
2 siblings, 1 reply; 7+ messages in thread
From: Randy Dunlap @ 2012-04-28 0:38 UTC (permalink / raw)
To: Seth Jennings
Cc: Greg Kroah-Hartman, devel, Dan Magenheimer, Autif Khan,
Konrad Rzeszutek Wilk, linux-kernel, linux-mm, Robert Jennings,
Nitin Gupta
On 04/23/2012 06:33 PM, Seth Jennings wrote:
> ZCACHE is a boolean in the Kconfig. When selected, it
> should require that CRYPTO be builtin (=y).
>
> Currently, ZCACHE=y and CRYPTO=m is a valid configuration
> when it should not be.
>
> This patch changes the zcache Kconfig to enforce this
> dependency.
>
> Signed-off-by: Seth Jennings <sjenning@linux.vnet.ibm.com>
Acked-by: Randy Dunlap <rdunlap@xenotime.net>
Thanks.
> ---
> drivers/staging/zcache/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/zcache/Kconfig b/drivers/staging/zcache/Kconfig
> index 3ed2c8f..7048e01 100644
> --- a/drivers/staging/zcache/Kconfig
> +++ b/drivers/staging/zcache/Kconfig
> @@ -2,7 +2,7 @@ config ZCACHE
> bool "Dynamic compression of swap pages and clean pagecache pages"
> # X86 dependency is because zsmalloc uses non-portable pte/tlb
> # functions
> - depends on (CLEANCACHE || FRONTSWAP) && CRYPTO && X86
> + depends on (CLEANCACHE || FRONTSWAP) && CRYPTO=y && X86
> select ZSMALLOC
> select CRYPTO_LZO
> default n
--
~Randy
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH] drivers: staging: zcache: fix Kconfig crypto dependency
2012-04-28 0:38 ` Randy Dunlap
@ 2012-05-03 21:11 ` Dan Magenheimer
0 siblings, 0 replies; 7+ messages in thread
From: Dan Magenheimer @ 2012-05-03 21:11 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: devel, Autif Khan, Konrad Wilk, linux-kernel, linux-mm,
Robert Jennings, Nitin Gupta, Randy Dunlap, Seth Jennings
> From: Randy Dunlap [mailto:rdunlap@xenotime.net]
> Sent: Friday, April 27, 2012 6:38 PM
> To: Seth Jennings
> Cc: Greg Kroah-Hartman; devel@driverdev.osuosl.org; Dan Magenheimer; Autif Khan; Konrad Rzeszutek
> Wilk; linux-kernel@vger.kernel.org; linux-mm@kvack.org; Robert Jennings; Nitin Gupta
> Subject: Re: [PATCH] drivers: staging: zcache: fix Kconfig crypto dependency
>
> On 04/23/2012 06:33 PM, Seth Jennings wrote:
>
> > ZCACHE is a boolean in the Kconfig. When selected, it
> > should require that CRYPTO be builtin (=y).
> >
> > Currently, ZCACHE=y and CRYPTO=m is a valid configuration
> > when it should not be.
> >
> > This patch changes the zcache Kconfig to enforce this
> > dependency.
> >
> > Signed-off-by: Seth Jennings <sjenning@linux.vnet.ibm.com>
>
>
> Acked-by: Randy Dunlap <rdunlap@xenotime.net>
Not sure if you need my approval, but I just in case you are waiting
for it:
Acked-by: Dan Magenheimer <dan.magenheimer@oracle.com>
> > ---
> > drivers/staging/zcache/Kconfig | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/staging/zcache/Kconfig b/drivers/staging/zcache/Kconfig
> > index 3ed2c8f..7048e01 100644
> > --- a/drivers/staging/zcache/Kconfig
> > +++ b/drivers/staging/zcache/Kconfig
> > @@ -2,7 +2,7 @@ config ZCACHE
> > bool "Dynamic compression of swap pages and clean pagecache pages"
> > # X86 dependency is because zsmalloc uses non-portable pte/tlb
> > # functions
> > - depends on (CLEANCACHE || FRONTSWAP) && CRYPTO && X86
> > + depends on (CLEANCACHE || FRONTSWAP) && CRYPTO=y && X86
> > select ZSMALLOC
> > select CRYPTO_LZO
> > default n
>
>
>
> --
> ~Randy
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2012-05-03 21:12 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-24 1:33 [PATCH] drivers: staging: zcache: fix Kconfig crypto dependency Seth Jennings
2012-04-24 2:09 ` Konrad Rzeszutek Wilk
2012-04-24 2:27 ` Greg Kroah-Hartman
2012-04-24 13:30 ` Seth Jennings
2012-04-24 14:35 ` Greg Kroah-Hartman
2012-04-28 0:38 ` Randy Dunlap
2012-05-03 21:11 ` Dan Magenheimer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).