[PATCH 01/02] fixed coding style issue with comments

[PATCH 01/02] fixed coding style issue with comments

[Jeffrin Jose]

Hello .

Fixed coding style issue relating to comments
in sound/usb/clock.c


>From 3bc5e14b4cf0dceb45314880233fe5a843ae048d Mon Sep 17 00:00:00 2001
From: Jeffrin Jose <ahiliation@yahoo.co.in>
Date: Sun, 29 Apr 2012 18:05:21 +0530
Subject: [PATCH 09/10] sound:Fixed a coding style issue of comments.

Fixed a coding style issue by replacing C99
style with C89 in the file sound/usb/clock.c

Signed-off-by: Jeffrin Jose <ahiliation@yahoo.co.in>
---
 sound/usb/clock.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sound/usb/clock.c b/sound/usb/clock.c
index 379baad..a3319af 100644
--- a/sound/usb/clock.c
+++ b/sound/usb/clock.c
@@ -240,7 +240,7 @@ static int set_sample_rate_v1(struct snd_usb_audio *chip, int iface,
 	crate = data[0] | (data[1] << 8) | (data[2] << 16);
 	if (crate != rate) {
 		snd_printd(KERN_WARNING "current rate %d is different from the runtime rate %d\n", crate, rate);
-		// runtime->rate = crate;
+		/* runtime->rate = crate; */
 	}
 
 	return 0;
-- 
1.7.9


-- 
software engineer
Bohr Lab
department of computer science
Rajagiri school of engineering and technology.

Re: [PATCH 01/02] fixed coding style issue with comments

[Andi Shyti]

Hi,

On Sun, Apr 29, 2012 at 06:50:14PM +0530, Jeffrin Jose wrote:
> Fixed coding style issue relating to comments

[...]

>  	if (crate != rate) {
>  		snd_printd(KERN_WARNING "current rate %d is different from the runtime rate %d\n", crate, rate);
> -		// runtime->rate = crate;
> +		/* runtime->rate = crate; */
>  	}


If you really want ti fix some style issues, you could also split
the snd_printd() line that is over 80 characters.
Moreover, this comment is not really meaningful, I would remove
it at all.

I would prefer something like

-	if (create != rate) {
+	if (create != rate)
-		snd_printd(KERN_WARNING "current rate %d is different from the runtime rate %d\n", crate, rate);
+		snd_printd(KERN_WARNING
+			"current rate %d is different from runtime rate %d\n",
+			crate, rate);
-		// runtime->rate = crate;
-  	}

Andi