From: Shawn Guo <shawn.guo@linaro.org>
To: Robert Lee <rob.lee@linaro.org>
Cc: kernel@pengutronix.de, amit.kucheria@linaro.org,
daniel.lezcano@linaro.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linaro-dev@lists.linaro.org,
patches@linaro.org, jj@chaosbits.net
Subject: Re: [PATCH v2 3/3] ARM: imx: Add imx6q cpuidle driver
Date: Wed, 2 May 2012 11:23:39 +0800 [thread overview]
Message-ID: <20120502032336.GU2194@S2101-09.ap.freescale.net> (raw)
In-Reply-To: <1335924760-796-4-git-send-email-rob.lee@linaro.org>
On Tue, May 01, 2012 at 09:12:40PM -0500, Robert Lee wrote:
> Add basic imx6q cpuidle driver. For now, only basic WFI state is
> supported. Deeper idle states will be added in the future.
>
> Signed-off-by: Robert Lee <rob.lee@linaro.org>
> ---
> arch/arm/mach-imx/cpuidle-imx6q.c | 33 +++++++++++++++++++++++++++++++++
So, this file is not needed any more, I guess.
> arch/arm/mach-imx/mach-imx6q.c | 18 ++++++++++++++++++
> 2 files changed, 51 insertions(+)
> create mode 100644 arch/arm/mach-imx/cpuidle-imx6q.c
>
> diff --git a/arch/arm/mach-imx/cpuidle-imx6q.c b/arch/arm/mach-imx/cpuidle-imx6q.c
> new file mode 100644
> index 0000000..b74557f
> --- /dev/null
> +++ b/arch/arm/mach-imx/cpuidle-imx6q.c
> @@ -0,0 +1,33 @@
> +/*
> + * Copyright 2012 Freescale Semiconductor, Inc.
> + * Copyright 2012 Linaro Ltd.
> + *
> + * The code contained herein is licensed under the GNU General Public
> + * License. You may obtain a copy of the GNU General Public License
> + * Version 2 or later at the following locations:
> + *
> + * http://www.opensource.org/licenses/gpl-license.html
> + * http://www.gnu.org/copyleft/gpl.html
> + */
> +
> +#include <linux/kernel.h>
> +#include <linux/init.h>
> +#include <linux/cpuidle.h>
> +#include <linux/export.h>
> +#include <asm/cpuidle.h>
> +#include <mach/cpuidle.h>
> +
> +static struct cpuidle_driver imx6q_cpuidle_driver = {
> + .name = "imx6q_cpuidle",
> + .owner = THIS_MODULE,
> + .en_core_tk_irqen = 1,
> + .states[0] = ARM_CPUIDLE_WFI_STATE,
> + .state_count = 1,
> +};
> +
> +int __init imx6q_cpuidle_init(void)
> +{
> + imx_cpuidle_set_driver(&imx6q_cpuidle_driver);
> +
> + return 0;
> +}
> diff --git a/arch/arm/mach-imx/mach-imx6q.c b/arch/arm/mach-imx/mach-imx6q.c
> index da6c1d9..21e2051 100644
> --- a/arch/arm/mach-imx/mach-imx6q.c
> +++ b/arch/arm/mach-imx/mach-imx6q.c
> @@ -21,6 +21,9 @@
> #include <linux/of_platform.h>
> #include <linux/phy.h>
> #include <linux/micrel_phy.h>
> +#include <linux/export.h>
> +#include <linux/cpuidle.h>
> +#include <asm/cpuidle.h>
> #include <asm/smp_twd.h>
> #include <asm/hardware/cache-l2x0.h>
> #include <asm/hardware/gic.h>
> @@ -29,6 +32,7 @@
> #include <asm/system_misc.h>
> #include <mach/common.h>
> #include <mach/hardware.h>
> +#include <mach/cpuidle.h>
The headers here are mostly sorted in names, so please ...
Regards,
Shawn
>
> void imx6q_restart(char mode, const char *cmd)
> {
> @@ -86,6 +90,19 @@ static void __init imx6q_init_machine(void)
> imx6q_pm_init();
> }
>
> +static struct cpuidle_driver imx6q_cpuidle_driver = {
> + .name = "imx6q_cpuidle",
> + .owner = THIS_MODULE,
> + .en_core_tk_irqen = 1,
> + .states[0] = ARM_CPUIDLE_WFI_STATE,
> + .state_count = 1,
> +};
> +
> +static void __init imx6q_init_late(void)
> +{
> + imx_cpuidle_init(&imx6q_cpuidle_driver);
> +}
> +
> static void __init imx6q_map_io(void)
> {
> imx_lluart_map_io();
> @@ -142,6 +159,7 @@ DT_MACHINE_START(IMX6Q, "Freescale i.MX6 Quad (Device Tree)")
> .handle_irq = imx6q_handle_irq,
> .timer = &imx6q_timer,
> .init_machine = imx6q_init_machine,
> + .init_late = imx6q_init_late,
> .dt_compat = imx6q_dt_compat,
> .restart = imx6q_restart,
> MACHINE_END
> --
> 1.7.10
>
next prev parent reply other threads:[~2012-05-02 3:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-02 2:12 [PATCH v2 0/3] Add imx cpuidle Robert Lee
2012-05-02 2:12 ` [PATCH v2 1/3] ARM: imx: Add common imx cpuidle init functionality Robert Lee
2012-05-02 3:13 ` Shawn Guo
2012-05-02 13:59 ` Rob Lee
2012-05-02 14:07 ` Shawn Guo
2012-05-02 14:09 ` Rob Lee
2012-05-02 7:27 ` Sascha Hauer
2012-05-02 19:16 ` Rob Lee
2012-05-02 20:21 ` Sascha Hauer
2012-05-02 2:12 ` [PATCH v2 2/3] ARM: imx: Add imx5 cpuidle driver Robert Lee
2012-05-02 7:33 ` Sascha Hauer
2012-05-02 20:11 ` Rob Lee
2012-05-03 6:39 ` Sascha Hauer
2012-05-02 2:12 ` [PATCH v2 3/3] ARM: imx: Add imx6q " Robert Lee
2012-05-02 3:23 ` Shawn Guo [this message]
2012-05-02 13:50 ` Rob Lee
2012-05-02 13:53 ` Shawn Guo
2012-05-02 3:03 ` [PATCH v2 0/3] Add imx cpuidle Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120502032336.GU2194@S2101-09.ap.freescale.net \
--to=shawn.guo@linaro.org \
--cc=amit.kucheria@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=jj@chaosbits.net \
--cc=kernel@pengutronix.de \
--cc=linaro-dev@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@linaro.org \
--cc=rob.lee@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).