From: Shawn Guo <shawn.guo@linaro.org>
To: Rob Lee <rob.lee@linaro.org>
Cc: kernel@pengutronix.de, amit.kucheria@linaro.org,
daniel.lezcano@linaro.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linaro-dev@lists.linaro.org,
patches@linaro.org, jj@chaosbits.net
Subject: Re: [PATCH v2 3/3] ARM: imx: Add imx6q cpuidle driver
Date: Wed, 2 May 2012 21:53:59 +0800 [thread overview]
Message-ID: <20120502135357.GC2194@S2101-09.ap.freescale.net> (raw)
In-Reply-To: <CAMXH7KHnN3YDwM6crgaFqwrgb4W=CErjgNiTPaZ8wrZ5dvKLuw@mail.gmail.com>
On Wed, May 02, 2012 at 08:50:20AM -0500, Rob Lee wrote:
> >> --- a/arch/arm/mach-imx/mach-imx6q.c
> >> +++ b/arch/arm/mach-imx/mach-imx6q.c
> >> @@ -21,6 +21,9 @@
> >> #include <linux/of_platform.h>
> >> #include <linux/phy.h>
> >> #include <linux/micrel_phy.h>
> >> +#include <linux/export.h>
> >> +#include <linux/cpuidle.h>
> >> +#include <asm/cpuidle.h>
> >> #include <asm/smp_twd.h>
> >> #include <asm/hardware/cache-l2x0.h>
> >> #include <asm/hardware/gic.h>
> >> @@ -29,6 +32,7 @@
> >> #include <asm/system_misc.h>
> >> #include <mach/common.h>
> >> #include <mach/hardware.h>
> >> +#include <mach/cpuidle.h>
> >
> > The headers here are mostly sorted in names, so please ...
> >
>
> Do you mean sorted alphabetically per group? So the last three
> includes should look like this instead?
> ...
> #include <mach/common.h>
> #include <mach/cpuidle.h>
> #include <mach/hardware.h>
> ...
Yes. And do not forget <linux/export.h> and <linux/cpuidle.h>.
--
Regards,
Shawn
next prev parent reply other threads:[~2012-05-02 13:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-02 2:12 [PATCH v2 0/3] Add imx cpuidle Robert Lee
2012-05-02 2:12 ` [PATCH v2 1/3] ARM: imx: Add common imx cpuidle init functionality Robert Lee
2012-05-02 3:13 ` Shawn Guo
2012-05-02 13:59 ` Rob Lee
2012-05-02 14:07 ` Shawn Guo
2012-05-02 14:09 ` Rob Lee
2012-05-02 7:27 ` Sascha Hauer
2012-05-02 19:16 ` Rob Lee
2012-05-02 20:21 ` Sascha Hauer
2012-05-02 2:12 ` [PATCH v2 2/3] ARM: imx: Add imx5 cpuidle driver Robert Lee
2012-05-02 7:33 ` Sascha Hauer
2012-05-02 20:11 ` Rob Lee
2012-05-03 6:39 ` Sascha Hauer
2012-05-02 2:12 ` [PATCH v2 3/3] ARM: imx: Add imx6q " Robert Lee
2012-05-02 3:23 ` Shawn Guo
2012-05-02 13:50 ` Rob Lee
2012-05-02 13:53 ` Shawn Guo [this message]
2012-05-02 3:03 ` [PATCH v2 0/3] Add imx cpuidle Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120502135357.GC2194@S2101-09.ap.freescale.net \
--to=shawn.guo@linaro.org \
--cc=amit.kucheria@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=jj@chaosbits.net \
--cc=kernel@pengutronix.de \
--cc=linaro-dev@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@linaro.org \
--cc=rob.lee@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).