* [PATCH] w1: w1_ds2408.c: quite sparse noise about using plaing integer as NULL pointer
@ 2012-05-03 0:02 H Hartley Sweeten
2012-05-03 18:02 ` Evgeniy Polyakov
0 siblings, 1 reply; 3+ messages in thread
From: H Hartley Sweeten @ 2012-05-03 0:02 UTC (permalink / raw)
To: Linux Kernel; +Cc: zbr
NULL not 0 should be used with pointers. Just remove the offending
lines since they will default to NULL anyway.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Evgeniy Polyakov <zbr@ioremap.net>
---
diff --git a/drivers/w1/slaves/w1_ds2408.c b/drivers/w1/slaves/w1_ds2408.c
index 7c8cdb8..8e813ee 100644
--- a/drivers/w1/slaves/w1_ds2408.c
+++ b/drivers/w1/slaves/w1_ds2408.c
@@ -332,7 +332,6 @@ static struct bin_attribute w1_f29_sysfs_bin_files[NB_SYSFS_BIN_FILES] = {
},
.size = 1,
.read = w1_f29_read_cond_search_mask,
- .write = 0,
},
{
.attr = {
@@ -341,7 +340,6 @@ static struct bin_attribute w1_f29_sysfs_bin_files[NB_SYSFS_BIN_FILES] = {
},
.size = 1,
.read = w1_f29_read_cond_search_polarity,
- .write = 0,
},
{
.attr = {
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] w1: w1_ds2408.c: quite sparse noise about using plaing integer as NULL pointer
2012-05-03 0:02 [PATCH] w1: w1_ds2408.c: quite sparse noise about using plaing integer as NULL pointer H Hartley Sweeten
@ 2012-05-03 18:02 ` Evgeniy Polyakov
2012-05-04 23:24 ` GregKH
0 siblings, 1 reply; 3+ messages in thread
From: Evgeniy Polyakov @ 2012-05-03 18:02 UTC (permalink / raw)
To: H Hartley Sweeten; +Cc: Linux Kernel, GregKH
On Wed, May 02, 2012 at 05:02:07PM -0700, H Hartley Sweeten (hartleys@visionengravers.com) wrote:
> NULL not 0 should be used with pointers. Just remove the offending
> lines since they will default to NULL anyway.
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Evgeniy Polyakov <zbr@ioremap.net>
Looks good, thank you
Greg, please pull it into your tree or should it be forwarded to
janitor list?
--
Evgeniy Polyakov
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] w1: w1_ds2408.c: quite sparse noise about using plaing integer as NULL pointer
2012-05-03 18:02 ` Evgeniy Polyakov
@ 2012-05-04 23:24 ` GregKH
0 siblings, 0 replies; 3+ messages in thread
From: GregKH @ 2012-05-04 23:24 UTC (permalink / raw)
To: Evgeniy Polyakov; +Cc: H Hartley Sweeten, Linux Kernel
On Thu, May 03, 2012 at 10:02:02PM +0400, Evgeniy Polyakov wrote:
> On Wed, May 02, 2012 at 05:02:07PM -0700, H Hartley Sweeten (hartleys@visionengravers.com) wrote:
> > NULL not 0 should be used with pointers. Just remove the offending
> > lines since they will default to NULL anyway.
> >
> > Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> > Cc: Evgeniy Polyakov <zbr@ioremap.net>
>
> Looks good, thank you
> Greg, please pull it into your tree or should it be forwarded to
> janitor list?
I'll take it, thanks.
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-05-04 23:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-05-03 0:02 [PATCH] w1: w1_ds2408.c: quite sparse noise about using plaing integer as NULL pointer H Hartley Sweeten
2012-05-03 18:02 ` Evgeniy Polyakov
2012-05-04 23:24 ` GregKH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).