* [PATCH] vme: vme_tsi148.c: local functions should not be exposed globally
@ 2012-05-03 0:08 H Hartley Sweeten lin
2012-05-03 15:55 ` Martyn Welch
0 siblings, 1 reply; 2+ messages in thread
From: H Hartley Sweeten lin @ 2012-05-03 0:08 UTC (permalink / raw)
To: Linux Kernel; +Cc: gregkh, martyn.welch
Functions not referenced outside of a source file should be marked
static to prevent them from being exposed globally.
Quiets the sparse warnings:
warning: symbol 'tsi148_alloc_consistent' was not declared. Should it be static?
warning: symbol 'tsi148_free_consistent' was not declared. Should it be static?
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Martyn Welch <martyn.welch@ge.com>
---
diff --git a/drivers/vme/bridges/vme_tsi148.c b/drivers/vme/bridges/vme_tsi148.c
index 081e9c4..f6385f7 100644
--- a/drivers/vme/bridges/vme_tsi148.c
+++ b/drivers/vme/bridges/vme_tsi148.c
@@ -2141,7 +2141,7 @@ static int tsi148_slot_get(struct vme_bridge *tsi148_bridge)
return (int)slot;
}
-void *tsi148_alloc_consistent(struct device *parent, size_t size,
+static void *tsi148_alloc_consistent(struct device *parent, size_t size,
dma_addr_t *dma)
{
struct pci_dev *pdev;
@@ -2152,8 +2152,8 @@ void *tsi148_alloc_consistent(struct device *parent, size_t size,
return pci_alloc_consistent(pdev, size, dma);
}
-void tsi148_free_consistent(struct device *parent, size_t size, void *vaddr,
- dma_addr_t dma)
+static void tsi148_free_consistent(struct device *parent, size_t size,
+ void *vaddr, dma_addr_t dma)
{
struct pci_dev *pdev;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] vme: vme_tsi148.c: local functions should not be exposed globally
2012-05-03 0:08 [PATCH] vme: vme_tsi148.c: local functions should not be exposed globally H Hartley Sweeten lin
@ 2012-05-03 15:55 ` Martyn Welch
0 siblings, 0 replies; 2+ messages in thread
From: Martyn Welch @ 2012-05-03 15:55 UTC (permalink / raw)
To: H Hartley Sweeten lin; +Cc: Linux Kernel, gregkh, devel, Manohar Vanga
On 03/05/12 01:08, H Hartley Sweeten lin wrote:
> Functions not referenced outside of a source file should be marked
> static to prevent them from being exposed globally.
>
> Quiets the sparse warnings:
>
> warning: symbol 'tsi148_alloc_consistent' was not declared. Should it be static?
> warning: symbol 'tsi148_free_consistent' was not declared. Should it be static?
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Martyn Welch <martyn.welch@ge.com>
>
Good catch,
Acked-by: Martyn Welch <martyn.welch@ge.com>
Martyn
> ---
>
> diff --git a/drivers/vme/bridges/vme_tsi148.c b/drivers/vme/bridges/vme_tsi148.c
> index 081e9c4..f6385f7 100644
> --- a/drivers/vme/bridges/vme_tsi148.c
> +++ b/drivers/vme/bridges/vme_tsi148.c
> @@ -2141,7 +2141,7 @@ static int tsi148_slot_get(struct vme_bridge *tsi148_bridge)
> return (int)slot;
> }
>
> -void *tsi148_alloc_consistent(struct device *parent, size_t size,
> +static void *tsi148_alloc_consistent(struct device *parent, size_t size,
> dma_addr_t *dma)
> {
> struct pci_dev *pdev;
> @@ -2152,8 +2152,8 @@ void *tsi148_alloc_consistent(struct device *parent, size_t size,
> return pci_alloc_consistent(pdev, size, dma);
> }
>
> -void tsi148_free_consistent(struct device *parent, size_t size, void *vaddr,
> - dma_addr_t dma)
> +static void tsi148_free_consistent(struct device *parent, size_t size,
> + void *vaddr, dma_addr_t dma)
> {
> struct pci_dev *pdev;
>
--
Martyn Welch (Lead Software Engineer) | Registered in England and Wales
GE Intelligent Platforms | (3828642) at 100 Barbirolli Square
T +44(0)1327322748 | Manchester, M2 3AB
E martyn.welch@ge.com | VAT:GB 927559189
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-05-03 15:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-05-03 0:08 [PATCH] vme: vme_tsi148.c: local functions should not be exposed globally H Hartley Sweeten lin
2012-05-03 15:55 ` Martyn Welch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).