From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: Joonsoo Kim <js1304@gmail.com>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
Paul Mackerras <paulus@samba.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH] perf tools: Fix Makefile to clean auto-generated bison/flex files properly
Date: Wed, 2 May 2012 16:12:05 -0300 [thread overview]
Message-ID: <20120502191205.GG5745@infradead.org> (raw)
In-Reply-To: <1336036107-12334-1-git-send-email-js1304@gmail.com>
Em Thu, May 03, 2012 at 02:08:27AM -0700, Joonsoo Kim escreveu:
> The commit 65f3e56e0c81 ("perf tools: Remove auto-generated bison/flex
> files") removed those files from git and modified Makefile to clean
> auto-generated bison/flex files. But, in Makefile, regular expression
> "*-{bison,flex}*" doesn't work. Fix it.
>
> Signed-off-by: Joonsoo Kim <js1304@gmail.com>
>
> diff --git a/tools/perf/Makefile b/tools/perf/Makefile
> index 9bf3fc7..295c477 100644
> --- a/tools/perf/Makefile
> +++ b/tools/perf/Makefile
> @@ -987,7 +987,7 @@ clean:
> $(RM) *.spec *.pyc *.pyo */*.pyc */*.pyo $(OUTPUT)common-cmds.h TAGS tags cscope*
> $(MAKE) -C Documentation/ clean
> $(RM) $(OUTPUT)PERF-VERSION-FILE $(OUTPUT)PERF-CFLAGS
> - $(RM) $(OUTPUT)util/*-{bison,flex}*
> + $(RM) $(OUTPUT)util/*-bison* $(OUTPUT)util/*-flex*
> $(python-clean)
Are you sure?
[acme@sandy perf]$ make -j8 > /dev/null
PERF_VERSION = 3.4.rc2.45.g89290d
* new build flags or prefix
[acme@sandy perf]$ ls -la util/*bison*
-rw-rw-r--. 1 acme acme 51448 May 2 16:10 util/parse-events-bison.c
-rw-rw-r--. 1 acme acme 2553 May 2 16:10 util/parse-events-bison.h
-rw-rw-r--. 1 acme acme 179488 May 2 16:10 util/parse-events-bison.o
-rw-rw-r--. 1 acme acme 12484 May 2 16:10 util/parse-events-bison.output
-rw-rw-r--. 1 acme acme 43849 May 2 16:10 util/pmu-bison.c
-rw-rw-r--. 1 acme acme 2313 May 2 16:10 util/pmu-bison.h
-rw-rw-r--. 1 acme acme 66064 May 2 16:10 util/pmu-bison.o
-rw-rw-r--. 1 acme acme 3416 May 2 16:10 util/pmu-bison.output
[acme@sandy perf]$ make clean > /dev/null
[acme@sandy perf]$ ls -la util/*bison*
ls: cannot access util/*bison*: No such file or directory
[acme@sandy perf]$
[acme@sandy perf]$ grep RM.*bison Makefile
$(RM) $(OUTPUT)util/*-{bison,flex}*
[acme@sandy perf]$
[acme@sandy perf]$ make --version
GNU Make 3.81
Copyright (C) 2006 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.
There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A
PARTICULAR PURPOSE.
This program built for x86_64-redhat-linux-gnu
[acme@sandy perf]$
next prev parent reply other threads:[~2012-05-03 14:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-28 9:50 [PATCH] perf tools: Fix Makefile to clean auto-generated bison/flex files properly Joonsoo Kim
2012-05-03 9:08 ` Joonsoo Kim
2012-05-02 19:12 ` Arnaldo Carvalho de Melo [this message]
2012-05-04 10:25 ` JoonSoo Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120502191205.GG5745@infradead.org \
--to=acme@ghostprotocols.net \
--cc=a.p.zijlstra@chello.nl \
--cc=js1304@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).