* [PATCH] perf tools: Fix Makefile to clean auto-generated bison/flex files properly
@ 2012-01-28 9:50 Joonsoo Kim
2012-05-03 9:08 ` Joonsoo Kim
0 siblings, 1 reply; 4+ messages in thread
From: Joonsoo Kim @ 2012-01-28 9:50 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Ingo Molnar, Paul Mackerras, Peter Zijlstra, Joonsoo Kim
The commit 65f3e56e0c81 ("perf tools: Remove auto-generated bison/flex
files") removed those files from git and modified Makefile to clean
auto-generated bison/flex files. But, in Makefile, regular expression
"*-{bison,flex}*" doesn't work. Fix it.
Signed-off-by: Joonsoo Kim <js1304@gmail.com>
diff --git a/tools/perf/Makefile b/tools/perf/Makefile
index 9bf3fc7..295c477 100644
--- a/tools/perf/Makefile
+++ b/tools/perf/Makefile
@@ -987,7 +987,7 @@ clean:
$(RM) *.spec *.pyc *.pyo */*.pyc */*.pyo $(OUTPUT)common-cmds.h TAGS tags cscope*
$(MAKE) -C Documentation/ clean
$(RM) $(OUTPUT)PERF-VERSION-FILE $(OUTPUT)PERF-CFLAGS
- $(RM) $(OUTPUT)util/*-{bison,flex}*
+ $(RM) $(OUTPUT)util/*-bison* $(OUTPUT)util/*-flex*
$(python-clean)
.PHONY: all install clean strip
--
1.7.0.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] perf tools: Fix Makefile to clean auto-generated bison/flex files properly
2012-05-03 9:08 ` Joonsoo Kim
@ 2012-05-02 19:12 ` Arnaldo Carvalho de Melo
2012-05-04 10:25 ` JoonSoo Kim
0 siblings, 1 reply; 4+ messages in thread
From: Arnaldo Carvalho de Melo @ 2012-05-02 19:12 UTC (permalink / raw)
To: Joonsoo Kim; +Cc: linux-kernel, Ingo Molnar, Paul Mackerras, Peter Zijlstra
Em Thu, May 03, 2012 at 02:08:27AM -0700, Joonsoo Kim escreveu:
> The commit 65f3e56e0c81 ("perf tools: Remove auto-generated bison/flex
> files") removed those files from git and modified Makefile to clean
> auto-generated bison/flex files. But, in Makefile, regular expression
> "*-{bison,flex}*" doesn't work. Fix it.
>
> Signed-off-by: Joonsoo Kim <js1304@gmail.com>
>
> diff --git a/tools/perf/Makefile b/tools/perf/Makefile
> index 9bf3fc7..295c477 100644
> --- a/tools/perf/Makefile
> +++ b/tools/perf/Makefile
> @@ -987,7 +987,7 @@ clean:
> $(RM) *.spec *.pyc *.pyo */*.pyc */*.pyo $(OUTPUT)common-cmds.h TAGS tags cscope*
> $(MAKE) -C Documentation/ clean
> $(RM) $(OUTPUT)PERF-VERSION-FILE $(OUTPUT)PERF-CFLAGS
> - $(RM) $(OUTPUT)util/*-{bison,flex}*
> + $(RM) $(OUTPUT)util/*-bison* $(OUTPUT)util/*-flex*
> $(python-clean)
Are you sure?
[acme@sandy perf]$ make -j8 > /dev/null
PERF_VERSION = 3.4.rc2.45.g89290d
* new build flags or prefix
[acme@sandy perf]$ ls -la util/*bison*
-rw-rw-r--. 1 acme acme 51448 May 2 16:10 util/parse-events-bison.c
-rw-rw-r--. 1 acme acme 2553 May 2 16:10 util/parse-events-bison.h
-rw-rw-r--. 1 acme acme 179488 May 2 16:10 util/parse-events-bison.o
-rw-rw-r--. 1 acme acme 12484 May 2 16:10 util/parse-events-bison.output
-rw-rw-r--. 1 acme acme 43849 May 2 16:10 util/pmu-bison.c
-rw-rw-r--. 1 acme acme 2313 May 2 16:10 util/pmu-bison.h
-rw-rw-r--. 1 acme acme 66064 May 2 16:10 util/pmu-bison.o
-rw-rw-r--. 1 acme acme 3416 May 2 16:10 util/pmu-bison.output
[acme@sandy perf]$ make clean > /dev/null
[acme@sandy perf]$ ls -la util/*bison*
ls: cannot access util/*bison*: No such file or directory
[acme@sandy perf]$
[acme@sandy perf]$ grep RM.*bison Makefile
$(RM) $(OUTPUT)util/*-{bison,flex}*
[acme@sandy perf]$
[acme@sandy perf]$ make --version
GNU Make 3.81
Copyright (C) 2006 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.
There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A
PARTICULAR PURPOSE.
This program built for x86_64-redhat-linux-gnu
[acme@sandy perf]$
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] perf tools: Fix Makefile to clean auto-generated bison/flex files properly
2012-01-28 9:50 [PATCH] perf tools: Fix Makefile to clean auto-generated bison/flex files properly Joonsoo Kim
@ 2012-05-03 9:08 ` Joonsoo Kim
2012-05-02 19:12 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 4+ messages in thread
From: Joonsoo Kim @ 2012-05-03 9:08 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Ingo Molnar, Paul Mackerras, Peter Zijlstra, Joonsoo Kim
The commit 65f3e56e0c81 ("perf tools: Remove auto-generated bison/flex
files") removed those files from git and modified Makefile to clean
auto-generated bison/flex files. But, in Makefile, regular expression
"*-{bison,flex}*" doesn't work. Fix it.
Signed-off-by: Joonsoo Kim <js1304@gmail.com>
diff --git a/tools/perf/Makefile b/tools/perf/Makefile
index 9bf3fc7..295c477 100644
--- a/tools/perf/Makefile
+++ b/tools/perf/Makefile
@@ -987,7 +987,7 @@ clean:
$(RM) *.spec *.pyc *.pyo */*.pyc */*.pyo $(OUTPUT)common-cmds.h TAGS tags cscope*
$(MAKE) -C Documentation/ clean
$(RM) $(OUTPUT)PERF-VERSION-FILE $(OUTPUT)PERF-CFLAGS
- $(RM) $(OUTPUT)util/*-{bison,flex}*
+ $(RM) $(OUTPUT)util/*-bison* $(OUTPUT)util/*-flex*
$(python-clean)
.PHONY: all install clean strip
--
1.7.0.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] perf tools: Fix Makefile to clean auto-generated bison/flex files properly
2012-05-02 19:12 ` Arnaldo Carvalho de Melo
@ 2012-05-04 10:25 ` JoonSoo Kim
0 siblings, 0 replies; 4+ messages in thread
From: JoonSoo Kim @ 2012-05-04 10:25 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Ingo Molnar, Paul Mackerras, Peter Zijlstra
> Are you sure?
>
> [acme@sandy perf]$ make -j8 > /dev/null
> PERF_VERSION = 3.4.rc2.45.g89290d
> * new build flags or prefix
> [acme@sandy perf]$ ls -la util/*bison*
> -rw-rw-r--. 1 acme acme 51448 May 2 16:10 util/parse-events-bison.c
> -rw-rw-r--. 1 acme acme 2553 May 2 16:10 util/parse-events-bison.h
> -rw-rw-r--. 1 acme acme 179488 May 2 16:10 util/parse-events-bison.o
> -rw-rw-r--. 1 acme acme 12484 May 2 16:10 util/parse-events-bison.output
> -rw-rw-r--. 1 acme acme 43849 May 2 16:10 util/pmu-bison.c
> -rw-rw-r--. 1 acme acme 2313 May 2 16:10 util/pmu-bison.h
> -rw-rw-r--. 1 acme acme 66064 May 2 16:10 util/pmu-bison.o
> -rw-rw-r--. 1 acme acme 3416 May 2 16:10 util/pmu-bison.output
> [acme@sandy perf]$ make clean > /dev/null
> [acme@sandy perf]$ ls -la util/*bison*
> ls: cannot access util/*bison*: No such file or directory
> [acme@sandy perf]$
Hmm...
I do more test on 4 types of environment(VM_x86_32_ubuntu10.04,
x86_32_ubuntu10.04,
x86_64_ubuntu11.10, x86_64_ubuntu12.04) and same result is occured.
All the GNU Make version is 3.81.
Below is my log.
So my conclusion is it relate to ubuntu.
js1304@ubuntu:~/Project/linux-torvalds/tools/perf$ make -j4 > /dev/null
Makefile:503: newt not found, disables TUI support. Please install
newt-devel or libnewt-dev
Package gtk+-2.0 was not found in the pkg-config search path.
Perhaps you should add the directory containing `gtk+-2.0.pc'
to the PKG_CONFIG_PATH environment variable
No package 'gtk+-2.0' found
Makefile:533: GTK2 not found, disables GTK2 support. Please install
gtk2-devel or libgtk2.0-dev
Makefile:590: The path '/usr/bin/python-config' is not executable.
Makefile:594: No python-config tool was found
Makefile:594: Python support won't be built
Makefile:663: No bfd.h/libbfd found, install
binutils-dev[el]/zlib-static to gain symbol demangling
PERF_VERSION = 3.4.rc5
Makefile:503: newt not found, disables TUI support. Please install
newt-devel or libnewt-dev
Package gtk+-2.0 was not found in the pkg-config search path.
Perhaps you should add the directory containing `gtk+-2.0.pc'
to the PKG_CONFIG_PATH environment variable
No package 'gtk+-2.0' found
Makefile:533: GTK2 not found, disables GTK2 support. Please install
gtk2-devel or libgtk2.0-dev
Makefile:590: The path '/usr/bin/python-config' is not executable.
Makefile:594: No python-config tool was found
Makefile:594: Python support won't be built
Makefile:663: No bfd.h/libbfd found, install
binutils-dev[el]/zlib-static to gain symbol demangling
* new build flags or prefix
js1304@ubuntu:~/Project/linux-torvalds/tools/perf$ ls -al util/*-bison*
-rw-r--r-- 1 js1304 js1304 51448 2012-05-03 02:47 util/parse-events-bison.c
-rw-r--r-- 1 js1304 js1304 2553 2012-05-03 02:47 util/parse-events-bison.h
-rw-r--r-- 1 js1304 js1304 145340 2012-05-03 02:47 util/parse-events-bison.o
-rw-r--r-- 1 js1304 js1304 12484 2012-05-03 02:47
util/parse-events-bison.output
-rw-r--r-- 1 js1304 js1304 43849 2012-05-03 02:47 util/pmu-bison.c
-rw-r--r-- 1 js1304 js1304 2313 2012-05-03 02:47 util/pmu-bison.h
-rw-r--r-- 1 js1304 js1304 58240 2012-05-03 02:47 util/pmu-bison.o
-rw-r--r-- 1 js1304 js1304 3416 2012-05-03 02:47 util/pmu-bison.output
js1304@ubuntu:~/Project/linux-torvalds/tools/perf$ make clean > /dev/null
Makefile:503: newt not found, disables TUI support. Please install
newt-devel or libnewt-dev
Package gtk+-2.0 was not found in the pkg-config search path.
Perhaps you should add the directory containing `gtk+-2.0.pc'
to the PKG_CONFIG_PATH environment variable
No package 'gtk+-2.0' found
Makefile:533: GTK2 not found, disables GTK2 support. Please install
gtk2-devel or libgtk2.0-dev
Makefile:590: The path '/usr/bin/python-config' is not executable.
Makefile:594: No python-config tool was found
Makefile:594: Python support won't be built
Makefile:663: No bfd.h/libbfd found, install
binutils-dev[el]/zlib-static to gain symbol demangling
Makefile:503: newt not found, disables TUI support. Please install
newt-devel or libnewt-dev
Package gtk+-2.0 was not found in the pkg-config search path.
Perhaps you should add the directory containing `gtk+-2.0.pc'
to the PKG_CONFIG_PATH environment variable
No package 'gtk+-2.0' found
Makefile:533: GTK2 not found, disables GTK2 support. Please install
gtk2-devel or libgtk2.0-dev
Makefile:590: The path '/usr/bin/python-config' is not executable.
Makefile:594: No python-config tool was found
Makefile:594: Python support won't be built
Makefile:663: No bfd.h/libbfd found, install
binutils-dev[el]/zlib-static to gain symbol demangling
js1304@ubuntu:~/Project/linux-torvalds/tools/perf$ ls -al util/*-bison*
-rw-r--r-- 1 js1304 js1304 51448 2012-05-03 02:47 util/parse-events-bison.c
-rw-r--r-- 1 js1304 js1304 2553 2012-05-03 02:47 util/parse-events-bison.h
-rw-r--r-- 1 js1304 js1304 12484 2012-05-03 02:47 util/parse-events-bison.output
-rw-r--r-- 1 js1304 js1304 43849 2012-05-03 02:47 util/pmu-bison.c
-rw-r--r-- 1 js1304 js1304 2313 2012-05-03 02:47 util/pmu-bison.h
-rw-r--r-- 1 js1304 js1304 3416 2012-05-03 02:47 util/pmu-bison.output
js1304@ubuntu:~/Project/linux-torvalds/tools/perf$ grep RM.*bison Makefile
$(RM) $(OUTPUT)util/*-{bison,flex}*
js1304@ubuntu:~/Project/linux-torvalds/tools/perf$ make --version
GNU Make 3.81
Copyright (C) 2006 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.
There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A
PARTICULAR PURPOSE.
This program built for i486-pc-linux-gnu
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-05-04 10:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-01-28 9:50 [PATCH] perf tools: Fix Makefile to clean auto-generated bison/flex files properly Joonsoo Kim
2012-05-03 9:08 ` Joonsoo Kim
2012-05-02 19:12 ` Arnaldo Carvalho de Melo
2012-05-04 10:25 ` JoonSoo Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).