* [patch] xhci: testing sizeof xhci_doorbell_array 2 time
@ 2012-05-06 15:05 girish verma
2012-05-08 0:26 ` Sarah Sharp
0 siblings, 1 reply; 2+ messages in thread
From: girish verma @ 2012-05-06 15:05 UTC (permalink / raw)
To: kernel-janitors; +Cc: linux-kernel, linux-usb
Testing BUILD_BUG_ON xhci_doorbell_array structure 2 time, redundant statement
Signed-off-by: Girish Verma <girish.gcet@gmail.com>
---
drivers/usb/host/xhci.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
index 36641a7..cfcf733 100644
--- a/drivers/usb/host/xhci.c
+++ b/drivers/usb/host/xhci.c
@@ -4090,7 +4090,6 @@ static int __init xhci_hcd_init(void)
BUILD_BUG_ON(sizeof(struct xhci_intr_reg) != 8*32/8);
/* xhci_run_regs has eight fields and embeds 128 xhci_intr_regs */
BUILD_BUG_ON(sizeof(struct xhci_run_regs) != (8+8*128)*32/8);
- BUILD_BUG_ON(sizeof(struct xhci_doorbell_array) != 256*32/8);
return 0;
unreg_pci:
xhci_unregister_pci();
--
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] xhci: testing sizeof xhci_doorbell_array 2 time
2012-05-06 15:05 [patch] xhci: testing sizeof xhci_doorbell_array 2 time girish verma
@ 2012-05-08 0:26 ` Sarah Sharp
0 siblings, 0 replies; 2+ messages in thread
From: Sarah Sharp @ 2012-05-08 0:26 UTC (permalink / raw)
To: girish verma; +Cc: kernel-janitors, linux-kernel, linux-usb
Hi Girish,
Although this is a pretty trivial change, can you please Cc the
maintainer of the driver (me, for the xHCI driver) next time? Either
check the MAINTAINERS file, or run scripts/get_maintainer.pl.
In any case, I see no problem with this patch. Greg's already taken it
anyway. :)
Thanks,
Sarah Sharp
On Sun, May 06, 2012 at 08:35:13PM +0530, girish verma wrote:
> Testing BUILD_BUG_ON xhci_doorbell_array structure 2 time, redundant statement
>
> Signed-off-by: Girish Verma <girish.gcet@gmail.com>
>
> ---
> drivers/usb/host/xhci.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
> index 36641a7..cfcf733 100644
> --- a/drivers/usb/host/xhci.c
> +++ b/drivers/usb/host/xhci.c
> @@ -4090,7 +4090,6 @@ static int __init xhci_hcd_init(void)
> BUILD_BUG_ON(sizeof(struct xhci_intr_reg) != 8*32/8);
> /* xhci_run_regs has eight fields and embeds 128 xhci_intr_regs */
> BUILD_BUG_ON(sizeof(struct xhci_run_regs) != (8+8*128)*32/8);
> - BUILD_BUG_ON(sizeof(struct xhci_doorbell_array) != 256*32/8);
> return 0;
> unreg_pci:
> xhci_unregister_pci();
> --
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-05-08 0:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-05-06 15:05 [patch] xhci: testing sizeof xhci_doorbell_array 2 time girish verma
2012-05-08 0:26 ` Sarah Sharp
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).