linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Johannes Winkelmann <johannes.winkelmann@gmail.com>
Cc: linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org,
	Jean Delvare <khali@linux-fr.org>,
	Johannes Winkelmann <johannes.winkelmann@sensirion.com>
Subject: Re: [RFC][PATCH] hwmon: add support for Sensirion C1 sensor
Date: Thu, 26 Jul 2012 07:14:26 -0700	[thread overview]
Message-ID: <20120726141426.GA15985@roeck-us.net> (raw)
In-Reply-To: <CAEYbzYsTQttoOnkoYqw9RkDO1zUc3qpyg0CzEY11_=oqdk0H-Q@mail.gmail.com>

Hi Johannes,

On Thu, Jul 26, 2012 at 03:53:12PM +0200, Johannes Winkelmann wrote:
> Hi Guenter,
> 
> Thanks a lot for the feedback; I've incorporated most of it in
> preparation for a v2 of the patch; I have some comments on the points
> I'm not certain about:
> 
[ ... ]
> >> +
> >> +The device communicates with the I2C protocol. All sensors are set to the same
> >> +I2C address 0x70, so an entry with I2C_BOARD_INFO("shtc1", 0x70) can be used
> >> +in the board setup code.
> >> +
> > Please also provide a reference to the other means to instantiate the driver.
> 
> I've checked a couple of documentation files and haven't found what
> else I should add, in fact the other sensor documents I checked didn't
> cover this, except for the one from the sht21 after which I modelled
> the document. Could you give me a pointer where to look?
> 
Just add a reference to Documentation/i2c/instantiating-devices.

Thanks,
Guenter

      reply	other threads:[~2012-07-26 14:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-20 12:57 [RFC][PATCH] hwmon: add support for Sensirion C1 sensor Johannes Winkelmann
2012-07-20 14:03 ` Oliver Neukum
2012-07-20 15:13   ` Johannes Winkelmann
2012-07-20 15:14     ` Oliver Neukum
2012-07-20 15:35       ` Johannes Winkelmann
2012-07-21 16:43       ` Guenter Roeck
2012-07-21 17:01 ` Guenter Roeck
2012-07-26 13:53   ` Johannes Winkelmann
2012-07-26 14:14     ` Guenter Roeck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120726141426.GA15985@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=johannes.winkelmann@gmail.com \
    --cc=johannes.winkelmann@sensirion.com \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).