From: Johannes Winkelmann <johannes.winkelmann@gmail.com>
To: Oliver Neukum <oneukum@suse.de>
Cc: linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org,
Jean Delvare <khali@linux-fr.org>,
Guenter Roeck <linux@roeck-us.net>,
Johannes Winkelmann <johannes.winkelmann@sensirion.com>
Subject: Re: [RFC][PATCH] hwmon: add support for Sensirion C1 sensor
Date: Fri, 20 Jul 2012 17:13:51 +0200 [thread overview]
Message-ID: <CAEYbzYsu_xhXJgbYKPj-rz-d26wTTM98+oyEDWbXMO5VNC5sgw@mail.gmail.com> (raw)
In-Reply-To: <6190165.D1PKLQQHEK@linux-lqwf.site>
On Fri, Jul 20, 2012 at 4:03 PM, Oliver Neukum <oneukum@suse.de> wrote:
> On Friday 20 July 2012 14:57:22 Johannes Winkelmann wrote:
>
>> +/* sysfs attributes */
>> +static struct shtc1_data *shtc1_update_client(struct device *dev)
>> +{
>> + struct i2c_client *client = to_i2c_client(dev);
>> + struct shtc1_data *data = i2c_get_clientdata(client);
>> +
>> + char buf[SHTC1_RESPONSE_LENGTH];
>
> Is this used for DMA?
No
>
>> + int val;
>> + int ret;
>> +
>> + mutex_lock(&data->update_lock);
>> +
>> + /*
>> + * initialize 'ret' in case we had a valid result before, but
>> + * read too quickly in which case we return the last values
>> + */
>> + ret = !data->valid;
>> +
>> + if (time_after(jiffies, data->last_updated + HZ / 10)
>> + || !data->valid) {
>> + ret = shtc1_update_values(client, data, buf, sizeof(buf));
>> +
>> + if (ret)
>> + goto out;
>> +
>> + /*
>> + * From datasheet:
>> + * T = -45 + 175 * ST / 2^16
>> + * RH = -10 + 120 * SRH / 2^16
>> + *
>> + * Adapted for integer fixed point (3 digit) arithmetic
>> + */
>> + val = (buf[0] << 8) | buf[1];
>> + data->temperature = ((21875 * val) >> 13) - 45000;
>> + val = (buf[3] << 8) | buf[4];
>
> We have dedicated macros for conversion of endianness.
Like this:
val = swab16p((__le16 *)buf);
data->temperature = ((21875 * val) >> 13) - 45000;
val = swab16p((__le16 *)(buf+2));
data->humidity = ((15000 * val) >> 13) - 10000;
>
>> + data->humidity = ((15000 * val) >> 13) - 10000;
>> +
>> + data->last_updated = jiffies;
>> + data->valid = 1;
>> + }
>> +
>> +out:
>> + mutex_unlock(&data->update_lock);
>> +
>> + return ret == 0 ? data : NULL;
>> +}
> Regards
> Oliver
>
Thanks, Johannes
next prev parent reply other threads:[~2012-07-20 15:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-20 12:57 [RFC][PATCH] hwmon: add support for Sensirion C1 sensor Johannes Winkelmann
2012-07-20 14:03 ` Oliver Neukum
2012-07-20 15:13 ` Johannes Winkelmann [this message]
2012-07-20 15:14 ` Oliver Neukum
2012-07-20 15:35 ` Johannes Winkelmann
2012-07-21 16:43 ` Guenter Roeck
2012-07-21 17:01 ` Guenter Roeck
2012-07-26 13:53 ` Johannes Winkelmann
2012-07-26 14:14 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEYbzYsu_xhXJgbYKPj-rz-d26wTTM98+oyEDWbXMO5VNC5sgw@mail.gmail.com \
--to=johannes.winkelmann@gmail.com \
--cc=johannes.winkelmann@sensirion.com \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lm-sensors@lm-sensors.org \
--cc=oneukum@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).