From: Zhao Chenhui <chenhui.zhao@freescale.com>
To: Tabi Timur-B04825 <B04825@freescale.com>
Cc: Zhao Chenhui-B35336 <B35336@freescale.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"galak@kernel.crashing.org" <galak@kernel.crashing.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Li Yang-R58472 <r58472@freescale.com>, <leoli@freescale.com>
Subject: Re: [PATCH 2/4] fsl_pmc: Add API to enable device as wakeup event source
Date: Tue, 14 Aug 2012 18:01:41 +0800 [thread overview]
Message-ID: <20120814100141.GB21028@localhost.localdomain> (raw)
In-Reply-To: <CAOZdJXXdgS5x2ZkuXb4wHckdqLzSM2xy-eYU3+28d_=JH3euxg@mail.gmail.com>
On Sat, Aug 11, 2012 at 08:19:43AM -0500, Tabi Timur-B04825 wrote:
> On Tue, Aug 7, 2012 at 3:43 AM, Zhao Chenhui <chenhui.zhao@freescale.com> wrote:
>
> > +int mpc85xx_pmc_set_wake(struct device *dev, bool enable)
> > +{
> > + int ret = 0;
> > + struct device_node *clk_np;
> > + const u32 *prop;
> > + u32 pmcdr_mask;
> > +
> > + if (!pmc_regs) {
> > + pr_err("%s: PMC is unavailable\n", __func__);
>
> You have a 'struct device', so please use dev_err instead.
>
> > + return -ENODEV;
> > + }
> > +
> > + if (enable && !device_may_wakeup(dev))
> > + return -EINVAL;
> > +
> > + clk_np = of_parse_phandle(dev->of_node, "fsl,pmc-handle", 0);
> > + if (!clk_np)
> > + return -EINVAL;
> > +
> > + prop = of_get_property(clk_np, "fsl,pmcdr-mask", NULL);
> > + if (!prop) {
> > + ret = -EINVAL;
> > + goto out;
> > + }
> > + pmcdr_mask = be32_to_cpup(prop);
> > +
> > + if (enable)
> > + /* clear to enable clock in low power mode */
> > + clrbits32(&pmc_regs->pmcdr, pmcdr_mask);
> > + else
> > + setbits32(&pmc_regs->pmcdr, pmcdr_mask);
> > +
> > +out:
> > + of_node_put(clk_np);
> > + return ret;
> > +}
> > +EXPORT_SYMBOL_GPL(mpc85xx_pmc_set_wake);
>
> Use EXPORT_SYMBOL, not EXPORT_SYMBOL_GPL.
>
> > +
> > +/**
> > + * mpc85xx_pmc_set_lossless_ethernet - enable lossless ethernet
> > + * in (deep) sleep mode
> > + * @enable: True to enable event generation; false to disable
> > + */
> > +void mpc85xx_pmc_set_lossless_ethernet(int enable)
>
> Should this be 'bool enable'?
>
> > @@ -21,6 +22,17 @@ struct device_node;
> >
> > extern void fsl_rstcr_restart(char *cmd);
> >
> > +#ifdef CONFIG_FSL_PMC
> > +extern int mpc85xx_pmc_set_wake(struct device *dev, bool enable);
> > +extern void mpc85xx_pmc_set_lossless_ethernet(int enable);
>
> Don't use 'extern' for functions.
>
Why? I think there is no difference.
-Chenhui
next prev parent reply other threads:[~2012-08-14 10:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-07 8:43 [PATCH 1/4] powerpc/85xx: add sleep and deep sleep support Zhao Chenhui
2012-08-07 8:43 ` [PATCH 2/4] fsl_pmc: Add API to enable device as wakeup event source Zhao Chenhui
2012-08-11 13:19 ` Tabi Timur-B04825
2012-08-14 9:58 ` Zhao Chenhui
2012-08-14 10:01 ` Zhao Chenhui [this message]
2012-08-14 12:27 ` Tabi Timur-B04825
2012-08-07 8:43 ` [PATCH 3/4] cpu: export cpu hotplug disable/enable functions as global functions Zhao Chenhui
2012-08-07 17:51 ` Kumar Gala
2012-08-08 6:13 ` Srivatsa S. Bhat
2012-08-08 7:11 ` Zhao Chenhui
2012-08-10 9:41 ` Zhao Chenhui
2012-08-07 8:43 ` [PATCH 4/4] powerpc/85xx: add support to JOG feature using cpufreq interface Zhao Chenhui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120814100141.GB21028@localhost.localdomain \
--to=chenhui.zhao@freescale.com \
--cc=B04825@freescale.com \
--cc=B35336@freescale.com \
--cc=galak@kernel.crashing.org \
--cc=leoli@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=r58472@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).