Re: [PATCH 3/4] cpu: export cpu hotplug disable/enable functions as global functions

From: Kumar Gala <galak@kernel.crashing.org>
To: srivatsa.bhat@linux.vnet.ibm.com, rjw@sisk.pl
Cc: Zhao Chenhui <chenhui.zhao@freescale.com>,
	"linuxppc-dev@lists.ozlabs.org list"
	<linuxppc-dev@lists.ozlabs.org>,
	"linux-kernel@vger.kernel.org list"
	<linux-kernel@vger.kernel.org>, Li Yang <leoli@freescale.com>
Subject: Re: [PATCH 3/4] cpu: export cpu hotplug disable/enable functions as global functions
Date: Tue, 7 Aug 2012 12:51:13 -0500	[thread overview]
Message-ID: <B4FC7F5E-EA8F-4FCA-B206-353FE4481DCE@kernel.crashing.org> (raw)
In-Reply-To: <1344329006-10645-3-git-send-email-chenhui.zhao@freescale.com>

On Aug 7, 2012, at 3:43 AM, Zhao Chenhui wrote:

> The cpufreq driver of mpc85xx will disable/enable cpu hotplug temporarily.
> Therefore, the related functions should be exported.
> 
> Signed-off-by: Zhao Chenhui <chenhui.zhao@freescale.com>
> ---
> include/linux/cpu.h |    4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)

Rafael, Srivatsa,

Wanted to get your ack on export these functions for direct calling by arch code.

- k

> 
> diff --git a/include/linux/cpu.h b/include/linux/cpu.h
> index ce7a074..df8f73d 100644
> --- a/include/linux/cpu.h
> +++ b/include/linux/cpu.h
> @@ -146,6 +146,8 @@ void notify_cpu_starting(unsigned int cpu);
> extern void cpu_maps_update_begin(void);
> extern void cpu_maps_update_done(void);
> 
> +extern void cpu_hotplug_disable_before_freeze(void);
> +extern void cpu_hotplug_enable_after_thaw(void);
> #else	/* CONFIG_SMP */
> 
> #define cpu_notifier(fn, pri)	do { (void)(fn); } while (0)
> @@ -167,6 +169,8 @@ static inline void cpu_maps_update_done(void)
> {
> }
> 
> +static inline void cpu_hotplug_disable_before_freeze(void)	{}
> +static inline void cpu_hotplug_enable_after_thaw(void)	{}
> #endif /* CONFIG_SMP */
> extern struct bus_type cpu_subsys;
> 
> -- 
> 1.6.4.1
> 