From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Anthony Olech <anthony.olech.opensource@diasemi.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
Arnd Bergmann <arnd@arndb.de>,
Mauro Carvalho Chehab <mchehab@redhat.com>,
Steven Toth <stoth@kernellabs.com>,
Michael Krufky <mkrufky@kernellabs.com>,
LKML <linux-kernel@vger.kernel.org>,
David Dajun Chen <david.chen@diasemi.com>
Subject: Re: [NEW DRIVER V3 1/8] DA9058 MFD core driver
Date: Wed, 15 Aug 2012 19:53:17 +0100 [thread overview]
Message-ID: <20120815185316.GG15365@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <201208151518.q7FFIN9v011639@latitude.olech.com>
On Wed, Aug 15, 2012 at 04:05:21PM +0100, Anthony Olech wrote:
>
> if HAS_IOMEM
> +
> menu "Multifunction device drivers"
This random change is still present from the first version....
> + /*
> + * the init_board_irq() call-back function should be defined in
> + * the machine driver initialization code and is used to set up
> + * the actual (probably GPIO) line as an interrupt line.
> + */
> + if (pdata->init_board_irq) {
> + ret = pdata->init_board_irq();
> + if (ret)
> + goto failed_to_setup_the_actual_i2c_hw_irq;
> + }
You appear to have ignored my previous review comments about this... it
still shouldn't be needed with modern kernels.
> +static bool da9058_register_volatile(struct device *dev, unsigned int reg)
> +{
> + switch (reg) {
> + case DA9058_ADCMAN_REG:
> + case DA9058_ADCRESH_REG:
> + case DA9058_ADCRESL_REG:
> + case DA9058_ALARMD_REG:
> + case DA9058_ALARMH_REG:
> + case DA9058_ALARMMI_REG:
> + case DA9058_ALARMMO_REG:
> + case DA9058_ALARMS_REG:
> + case DA9058_ALARMY_REG:
Are all the alarm registers really volatile?
> + case DA9058_LDO9_REG:
> + case DA9058_TOFFSET_REG:
> + default:
> + return false;
Just use the default.
> +static struct regulator_consumer_supply platform_vddarm_consumers[] = {
> + {.supply = "vcc",}
> +};
No, this and all your other regulator configuration is board specific.
next prev parent reply other threads:[~2012-08-15 18:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-15 15:05 [NEW DRIVER V3 1/8] DA9058 MFD core driver Anthony Olech
2012-08-15 18:53 ` Mark Brown [this message]
2012-08-16 11:34 ` Opensource [Anthony Olech]
2012-08-16 12:45 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120815185316.GG15365@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=anthony.olech.opensource@diasemi.com \
--cc=arnd@arndb.de \
--cc=david.chen@diasemi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=mkrufky@kernellabs.com \
--cc=sameo@linux.intel.com \
--cc=stoth@kernellabs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).