From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: "Opensource [Anthony Olech]" <anthony.olech.opensource@diasemi.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
Arnd Bergmann <arnd@arndb.de>,
Mauro Carvalho Chehab <mchehab@redhat.com>,
Steven Toth <stoth@kernellabs.com>,
Michael Krufky <mkrufky@kernellabs.com>,
LKML <linux-kernel@vger.kernel.org>,
David Dajun Chen <david.chen@diasemi.com>
Subject: Re: [NEW DRIVER V3 1/8] DA9058 MFD core driver
Date: Thu, 16 Aug 2012 13:45:47 +0100 [thread overview]
Message-ID: <20120816124547.GJ15365@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <24DF37198A1E704D9811D8F72B87EB51032C6702@NB-EX-MBX02.diasemi.com>
On Thu, Aug 16, 2012 at 11:34:56AM +0000, Opensource [Anthony Olech] wrote:
Fix your mail configuration to word wrap at something less than 80
columns within paragraphs, your mails are currently extremely hard to
read.
> The only other interpretation of your comment is that the h/w IRQ line setup code must be done
> in the machine driver, in my case for testing is arch/arm/mach-s3c64xx/mach-smdk6410.c
> But that view is contricted by the init call-backs from the wm8350 and wm1192 drivers.
This board driver is not a modern driver, configuration callbacks used
to be used but this is no longer be something that's needed.
> I am confused, but it does make sense to do the GPIO --> IRQ initialization in the machine driver,
> so I will try to do that. But who would be responsible for changing the wm8350 and wm1192 drivers
> to also follow that philosophy?
If someone has the time and enthusiasm it might be worthwhile, but it's
not clear that this is the case.
prev parent reply other threads:[~2012-08-16 12:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-15 15:05 [NEW DRIVER V3 1/8] DA9058 MFD core driver Anthony Olech
2012-08-15 18:53 ` Mark Brown
2012-08-16 11:34 ` Opensource [Anthony Olech]
2012-08-16 12:45 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120816124547.GJ15365@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=anthony.olech.opensource@diasemi.com \
--cc=arnd@arndb.de \
--cc=david.chen@diasemi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=mkrufky@kernellabs.com \
--cc=sameo@linux.intel.com \
--cc=stoth@kernellabs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).