From: Tejun Heo <tj@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: wei_wang@realsil.com.cn, gregkh@linuxfoundation.org,
devel@linuxdriverproject.org, linux-kernel@vger.kernel.org,
linux-mmc@vger.kernel.org, cjb@laptop.org, sameo@linux.intel.com,
bp@alien8.de
Subject: Re: [PATCH v2 1/2] drivers/mfd: Add realtek pcie card reader driver
Date: Thu, 16 Aug 2012 14:25:48 -0700 [thread overview]
Message-ID: <20120816212548.GI24861@google.com> (raw)
In-Reply-To: <201208150640.54561.arnd@arndb.de>
On Wed, Aug 15, 2012 at 06:40:54AM +0000, Arnd Bergmann wrote:
> On Tuesday 14 August 2012, wei_wang@realsil.com.cn wrote:
> > +
> > +void rtsx_pci_start_run(struct rtsx_pcr *pcr)
> > +{
> > + /* If pci device removed, don't queue idle work any more */
> > + if (pcr->remove_pci)
> > + return;
> > +
> > + if (pcr->state != PDEV_STAT_RUN) {
> > + pcr->state = PDEV_STAT_RUN;
> > + pcr->ops->enable_auto_blink(pcr);
> > + }
> > +
> > + mod_timer(&pcr->idle_timer, jiffies + msecs_to_jiffies(200));
> > +}
> > +EXPORT_SYMBOL_GPL(rtsx_pci_start_run);
>
> One more comment on the mod_timer/queue_work combination: I just saw that
> Tejun Heo posted a series to introduce a new mod_delayed_work() helper.
>
> Once that goes in, it would be best to start using it here.
mod_delayed_work() is now in the following git branch.
git://git.kernel.org/pub/scm/linux/kernel/git/tj/wq.git wq-mod_delayed
The branch is stable and will be pushed during for-3.7 merge window.
Please feel free to pull as necessary.
Thanks.
--
tejun
next prev parent reply other threads:[~2012-08-16 21:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-14 10:40 [PATCH v2 0/2] Add modules to support realtek PCIE card reader wei_wang
2012-08-14 10:40 ` [PATCH v2 1/2] drivers/mfd: Add realtek pcie card reader driver wei_wang
2012-08-15 6:40 ` Arnd Bergmann
2012-08-16 21:25 ` Tejun Heo [this message]
2012-08-14 10:40 ` [PATCH v2 2/2] drivers/mmc: Add realtek pcie sdmmc host driver wei_wang
2012-08-14 15:05 ` [PATCH v2 0/2] Add modules to support realtek PCIE card reader Borislav Petkov
[not found] ` <637A8844983F7F4092120E33EA3F28CD31E74BE133@RSEX1.realsil.com.cn>
2012-08-14 16:14 ` 答复: " Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120816212548.GI24861@google.com \
--to=tj@kernel.org \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=cjb@laptop.org \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=wei_wang@realsil.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).