From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Alan Stern <stern@rowland.harvard.edu>,
Miklos Szeredi <miklos@szeredi.hu>
Cc: Hans de Goede <hdegoede@redhat.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
Tejun Heo <tj@kernel.org>,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
David Miller <davem@davemloft.net>
Subject: Re: [REGRESION] Suspend hangs with 3.6-rc1 on Lenovo T60 notebook
Date: Thu, 16 Aug 2012 22:02:40 +0200 [thread overview]
Message-ID: <201208162202.40929.rjw@sisk.pl> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1208161232001.31195-100000@netrider.rowland.org>
On Thursday, August 16, 2012, Alan Stern wrote:
> On Thu, 16 Aug 2012, Miklos Szeredi wrote:
>
> > Yes, this appears to work. Following patch fixes the suspend oops.
> >
> > Thanks,
> > Miklos
OK
Miklos, can you please send that to Dave with a proper changelog and
sign-off (please add my ACK too)? Please make it clear that this is a
regression fix and which commit has introduced the regression.
> > ---
> > drivers/ide/ide-pm.c | 4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/ide/ide-pm.c b/drivers/ide/ide-pm.c
> > index 9240609..8d1e32d 100644
> > --- a/drivers/ide/ide-pm.c
> > +++ b/drivers/ide/ide-pm.c
> > @@ -4,7 +4,7 @@
> >
> > int generic_ide_suspend(struct device *dev, pm_message_t mesg)
> > {
> > - ide_drive_t *drive = dev_get_drvdata(dev);
> > + ide_drive_t *drive = to_ide_device(dev);
> > ide_drive_t *pair = ide_get_pair_dev(drive);
> > ide_hwif_t *hwif = drive->hwif;
> > struct request *rq;
> > @@ -40,7 +40,7 @@ int generic_ide_suspend(struct device *dev, pm_message_t mesg)
> >
> > int generic_ide_resume(struct device *dev)
> > {
> > - ide_drive_t *drive = dev_get_drvdata(dev);
> > + ide_drive_t *drive = to_ide_device(dev);
> > ide_drive_t *pair = ide_get_pair_dev(drive);
> > ide_hwif_t *hwif = drive->hwif;
> > struct request *rq;
>
> And now you can get rid of the useless dev_set_drvdata() call.
That was in the other patch I think.
Thanks,
Rafael
next prev parent reply other threads:[~2012-08-16 19:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87a9xwivqb.fsf@tucsk.pomaz.szeredi.hu>
2012-08-15 6:41 ` [REGRESION] Suspend hangs with 3.6-rc1 on Lenovo T60 notebook Hans de Goede
2012-08-15 19:59 ` Rafael J. Wysocki
2012-08-16 11:34 ` Hans de Goede
2012-08-16 15:13 ` Alan Stern
2012-08-16 16:29 ` Miklos Szeredi
2012-08-16 16:32 ` Alan Stern
2012-08-16 20:02 ` Rafael J. Wysocki [this message]
2012-08-17 9:23 ` Hans de Goede
2012-08-17 14:22 ` Alan Stern
2012-08-17 14:27 ` Alan Stern
2012-08-17 15:32 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201208162202.40929.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=stern@rowland.harvard.edu \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).