From: Hans de Goede <hdegoede@redhat.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
Miklos Szeredi <miklos@szeredi.hu>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Tejun Heo <tj@kernel.org>,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
David Miller <davem@davemloft.net>
Subject: Re: [REGRESION] Suspend hangs with 3.6-rc1 on Lenovo T60 notebook
Date: Fri, 17 Aug 2012 17:32:00 +0200 [thread overview]
Message-ID: <502E63F0.8050406@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1208171025330.25520-100000@netrider.rowland.org>
Hi,
On 08/17/2012 04:27 PM, Alan Stern wrote:
> On Fri, 17 Aug 2012, Alan Stern wrote:
>
>> On Fri, 17 Aug 2012, Hans de Goede wrote:
>>
>>> No my patch was a hack to undo the results of the commit causing
>>> the regression in the IDE case. But Alan's approach clearly is
>>> much better! Once we are sure drvdata is not used anywhere the
>>> dev_set_drvdata call could be removed in the place where my
>>> hack added a second call to it. Note that there are likely
>>> actual ide drivers using it, without setting it themselves since
>>> the ide core was setting it. So removing it will require even more
>>> auditing / checking.
>>
>> I did search for dev_get_drvdata() calls in drivers/ide; there were no
>> other calls that retrieved an ide_drive_t value. But I didn't check
>> anywhere else in the kernel. In fact, I'm not sure where else to look.
>
> After a little more checking: Among all the .c files in the kernel
> which match the pattern '[^a-z]ide_', the only occurrences of
> dev_get_drvdata() which retrieve an ide_drive_t value are the two in
> ide-pm.c.
Thanks, good work! That means we should move forward with submitting
Miklos' patch to the ide subsystem maintainer asap.
Also if someone feels like it we still could do the 2 follow up / clean
up patches:
1) Removin the set_drvdata call from hwif_register_devices()
in ide-prove.c
2) Fixup ide-generic.c ide_remove to not dereference a NULL dev->driver
Regards,
Hans
prev parent reply other threads:[~2012-08-17 15:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87a9xwivqb.fsf@tucsk.pomaz.szeredi.hu>
2012-08-15 6:41 ` [REGRESION] Suspend hangs with 3.6-rc1 on Lenovo T60 notebook Hans de Goede
2012-08-15 19:59 ` Rafael J. Wysocki
2012-08-16 11:34 ` Hans de Goede
2012-08-16 15:13 ` Alan Stern
2012-08-16 16:29 ` Miklos Szeredi
2012-08-16 16:32 ` Alan Stern
2012-08-16 20:02 ` Rafael J. Wysocki
2012-08-17 9:23 ` Hans de Goede
2012-08-17 14:22 ` Alan Stern
2012-08-17 14:27 ` Alan Stern
2012-08-17 15:32 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502E63F0.8050406@redhat.com \
--to=hdegoede@redhat.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=rjw@sisk.pl \
--cc=stern@rowland.harvard.edu \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).