* [PATCH] snd-als100: fix suspend/resume
@ 2012-08-20 19:50 Ondrej Zary
2012-08-21 8:00 ` [alsa-devel] " Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Ondrej Zary @ 2012-08-20 19:50 UTC (permalink / raw)
To: Massimo Piccioni; +Cc: alsa-devel, Kernel development list
snd_card_als100_probe() does not set pcm field in struct snd_sb.
As a result, PCM is not suspended and applications don't know that they need
to resume the playback.
Tested with Labway A381-F20 card (ALS120).
Signed-off-by: Ondrej Zary <linux@rainbow-software.org>
--- a/sound/isa/als100.c
+++ b/sound/isa/als100.c
@@ -233,7 +233,7 @@ static int __devinit snd_card_als100_probe(int dev,
irq[dev], dma8[dev], dma16[dev]);
}
- if ((error = snd_sb16dsp_pcm(chip, 0, NULL)) < 0) {
+ if ((error = snd_sb16dsp_pcm(chip, 0, &chip->pcm)) < 0) {
snd_card_free(card);
return error;
}
--
Ondrej Zary
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [alsa-devel] [PATCH] snd-als100: fix suspend/resume
2012-08-20 19:50 [PATCH] snd-als100: fix suspend/resume Ondrej Zary
@ 2012-08-21 8:00 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2012-08-21 8:00 UTC (permalink / raw)
To: Ondrej Zary; +Cc: Massimo Piccioni, alsa-devel, Kernel development list
At Mon, 20 Aug 2012 21:50:13 +0200,
Ondrej Zary wrote:
>
> snd_card_als100_probe() does not set pcm field in struct snd_sb.
> As a result, PCM is not suspended and applications don't know that they need
> to resume the playback.
>
> Tested with Labway A381-F20 card (ALS120).
>
> Signed-off-by: Ondrej Zary <linux@rainbow-software.org>
Applied now. Thanks.
Takashi
>
> --- a/sound/isa/als100.c
> +++ b/sound/isa/als100.c
> @@ -233,7 +233,7 @@ static int __devinit snd_card_als100_probe(int dev,
> irq[dev], dma8[dev], dma16[dev]);
> }
>
> - if ((error = snd_sb16dsp_pcm(chip, 0, NULL)) < 0) {
> + if ((error = snd_sb16dsp_pcm(chip, 0, &chip->pcm)) < 0) {
> snd_card_free(card);
> return error;
> }
>
>
>
>
> --
> Ondrej Zary
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-08-21 8:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-08-20 19:50 [PATCH] snd-als100: fix suspend/resume Ondrej Zary
2012-08-21 8:00 ` [alsa-devel] " Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).