[PATCH] watchdog: fix a compiler warning of test program

[PATCH] watchdog: fix a compiler warning of test program

[yan]

This patch fixs the following compiler warning:

Documentation/watchdog/src/watchdog-test.c:34:6: \
warning: no previous prototype for ‘term’ [-Wmissing-prototypes]

Signed-off-by: yan <clouds.yan@gmail.com>
---
 Documentation/watchdog/src/watchdog-test.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/watchdog/src/watchdog-test.c b/Documentation/watchdog/src/watchdog-test.c
index 73ff5cc..3da8229 100644
--- a/Documentation/watchdog/src/watchdog-test.c
+++ b/Documentation/watchdog/src/watchdog-test.c
@@ -31,7 +31,7 @@ static void keep_alive(void)
  * or "-e" to enable the card.
  */
 
-void term(int sig)
+static void term(int sig)
 {
     close(fd);
     fprintf(stderr, "Stopping watchdog ticks...\n");
-- 
1.7.9.5

Re: [PATCH] watchdog: fix a compiler warning of test program

[Randy Dunlap]

On 08/29/2012 06:39 AM, yan wrote:

> This patch fixs the following compiler warning:
> 


Hi,
This is already fixed in the watchdog git tree.

Thanks.

> Documentation/watchdog/src/watchdog-test.c:34:6: \
> warning: no previous prototype for ‘term’ [-Wmissing-prototypes]
> 
> Signed-off-by: yan <clouds.yan@gmail.com>
> ---
>  Documentation/watchdog/src/watchdog-test.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/watchdog/src/watchdog-test.c b/Documentation/watchdog/src/watchdog-test.c
> index 73ff5cc..3da8229 100644
> --- a/Documentation/watchdog/src/watchdog-test.c
> +++ b/Documentation/watchdog/src/watchdog-test.c
> @@ -31,7 +31,7 @@ static void keep_alive(void)
>   * or "-e" to enable the card.
>   */
>  
> -void term(int sig)
> +static void term(int sig)
>  {
>      close(fd);
>      fprintf(stderr, "Stopping watchdog ticks...\n");



-- 
~Randy

Re: [PATCH] watchdog: fix a compiler warning of test program

[Wim Van Sebroeck]

And the fix is in Linus his tree also now.

Kind regards,
Wim.

> On 08/29/2012 06:39 AM, yan wrote:
> 
> > This patch fixs the following compiler warning:
> > 
> 
> 
> Hi,
> This is already fixed in the watchdog git tree.
> 
> Thanks.
> 
> > Documentation/watchdog/src/watchdog-test.c:34:6: \
> > warning: no previous prototype for ‘term’ [-Wmissing-prototypes]
> > 
> > Signed-off-by: yan <clouds.yan@gmail.com>
> > ---
> >  Documentation/watchdog/src/watchdog-test.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/watchdog/src/watchdog-test.c b/Documentation/watchdog/src/watchdog-test.c
> > index 73ff5cc..3da8229 100644
> > --- a/Documentation/watchdog/src/watchdog-test.c
> > +++ b/Documentation/watchdog/src/watchdog-test.c
> > @@ -31,7 +31,7 @@ static void keep_alive(void)
> >   * or "-e" to enable the card.
> >   */
> >  
> > -void term(int sig)
> > +static void term(int sig)
> >  {
> >      close(fd);
> >      fprintf(stderr, "Stopping watchdog ticks...\n");
> 
> 
> 
> -- 
> ~Randy