From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
STEricsson_nomadik_linux@list.st.com,
linus.walleij@stericsson.com, arnd@arndb.de,
broonie@opensource.wolfsonmicro.com, linux-input@vger.kernel.org
Subject: Re: [PATCH 8/8] input: ab8500-ponkey: Rely on MFD core to convert IRQs to virtual
Date: Thu, 30 Aug 2012 16:02:21 -0700 [thread overview]
Message-ID: <20120830230221.GD21501@core.coreip.homeip.net> (raw)
In-Reply-To: <20120830131202.GG14145@gmail.com>
On Thu, Aug 30, 2012 at 02:12:04PM +0100, Lee Jones wrote:
> > Sorry for the delay. Yes, this shoudl be fine, but since it is
> > essentially a revert of the original patch it should be pushed in as
> > such.
>
> How's this?
>
Excellent.
> Author: Lee Jones <lee.jones@linaro.org>
> Date: Thu Aug 30 14:08:19 2012 +0100
>
> Revert "input: ab8500-ponkey: Create AB8500 domain IRQ mapping"
>
> This reverts commit ca3b3faf9bee4dc5df4f10eae2d1e48f7de0a8ad.
>
> There was a plan to place ab8500_irq_get_virq() calls in each AB8500
> child device prior to requesting an IRQ, but as we're no longer using
> Device Tree to collect our IRQ numbers, it's actually better to allow
> the core to do this during device registration time. So the IRQ number
> we pull from its resource has already been converted to a virtual IRQ.
>
> CC: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> CC: linux-input@vger.kernel.org
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
>
> diff --git a/drivers/input/misc/ab8500-ponkey.c b/drivers/input/misc/ab8500-ponkey.c
> index f06231b..84ec691 100644
> --- a/drivers/input/misc/ab8500-ponkey.c
> +++ b/drivers/input/misc/ab8500-ponkey.c
> @@ -74,8 +74,8 @@ static int __devinit ab8500_ponkey_probe(struct platform_device *pdev)
>
> ponkey->idev = input;
> ponkey->ab8500 = ab8500;
> - ponkey->irq_dbf = ab8500_irq_get_virq(ab8500, irq_dbf);
> - ponkey->irq_dbr = ab8500_irq_get_virq(ab8500, irq_dbr);
> + ponkey->irq_dbf = irq_dbf;
> + ponkey->irq_dbr = irq_dbr;
>
> input->name = "AB8500 POn(PowerOn) Key";
> input->dev.parent = &pdev->dev;
--
Dmitry
next prev parent reply other threads:[~2012-08-30 23:02 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-09 15:53 [PATCH 0/8] Changes surrounding IRQs and IRQ domains Lee Jones
2012-08-09 15:53 ` [PATCH 1/8] of/irq: Create stub for of_irq_find_parent when !CONFIG_OF Lee Jones
2012-08-09 16:20 ` Rob Herring
2012-08-09 19:44 ` Lee Jones
2012-08-09 19:53 ` Rob Herring
2012-08-14 8:17 ` Linus Walleij
2012-08-09 15:53 ` [PATCH 2/8] irqdomain: Take interrupt-parent property into account if specified Lee Jones
2012-08-14 8:19 ` Linus Walleij
2012-08-31 9:44 ` Lee Jones
2012-08-31 13:58 ` Rob Herring
2012-08-09 15:53 ` [PATCH 3/8] ARM: ux500: Identify the PRCMU as an interrupt controller Lee Jones
2012-08-14 8:19 ` Linus Walleij
2012-08-09 15:53 ` [PATCH 4/8] ARM: ux500: Force AB8500 to use the GIC as its " Lee Jones
2012-08-14 8:20 ` Linus Walleij
2012-08-09 15:53 ` [PATCH 5/8] mfd: Provide the PRCMU with its own IRQ domain Lee Jones
2012-08-14 8:29 ` Linus Walleij
2012-08-14 9:42 ` Arnd Bergmann
2012-08-14 10:44 ` Linus Walleij
2012-08-20 8:36 ` Lee Jones
2012-08-20 12:10 ` Mark Brown
2012-08-20 12:55 ` Lee Jones
2012-08-20 16:29 ` Mark Brown
2012-08-20 16:49 ` Lee Jones
2012-08-20 17:51 ` Mark Brown
2012-08-21 8:56 ` Lee Jones
2012-08-21 9:50 ` Mark Brown
2012-08-21 10:54 ` Lee Jones
2012-08-21 11:03 ` Mark Brown
2012-08-21 12:02 ` Lee Jones
2012-08-21 16:52 ` Mark Brown
2012-08-22 8:17 ` Lee Jones
2012-08-22 11:19 ` Mark Brown
2012-08-22 11:55 ` Lee Jones
2012-08-22 15:48 ` Mark Brown
2012-08-20 9:36 ` Lee Jones
2012-08-20 10:49 ` Lee Jones
2012-08-09 15:53 ` [PATCH 6/8] mfd: Use interrupt-parent as IRQ controller if specified in DT Lee Jones
2012-08-14 8:22 ` Linus Walleij
2012-08-09 15:53 ` [PATCH 7/8] mfd: Use the AB8500's IRQ domain to convert hwirq to virq Lee Jones
2012-08-14 8:25 ` Linus Walleij
2012-09-19 0:00 ` Samuel Ortiz
2012-08-09 15:53 ` [PATCH 8/8] input: ab8500-ponkey: Rely on MFD core to convert IRQs to virtual Lee Jones
2012-08-14 8:31 ` Linus Walleij
2012-08-21 9:23 ` Lee Jones
2012-08-21 16:42 ` Dmitry Torokhov
2012-08-30 13:12 ` Lee Jones
2012-08-30 23:02 ` Dmitry Torokhov [this message]
2012-08-30 23:03 ` Dmitry Torokhov
2012-08-31 7:31 ` Lee Jones
2012-08-31 14:50 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120830230221.GD21501@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=STEricsson_nomadik_linux@list.st.com \
--cc=arnd@arndb.de \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).