* [PATCH] [Signed-off] kconfig: document oldnoconfig to what it really does in conf.c
@ 2012-08-17 6:57 Adam Lee
2012-08-22 13:45 ` Adam Lee
0 siblings, 1 reply; 3+ messages in thread
From: Adam Lee @ 2012-08-17 6:57 UTC (permalink / raw)
To: linux-kernel; +Cc: Michal Marek, Eric W. Biederman, open list:KCONFIG
As 67d34a6a391369269a2e5dba8a5f42cc4cd50231 said, the make target
'oldnoconfig' is a misnomer. It doesn't set new symbols to 'n', but
instead sets it to their default values.
This patch fixes the document in conf.c, and will submit another patch
to replace 'oldnoconfig' to 'olddefconfig'
Signed-off-by: Adam Lee <adam8157@gmail.com>
---
scripts/kconfig/conf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/kconfig/conf.c b/scripts/kconfig/conf.c
index 0dc4a2c..6875680 100644
--- a/scripts/kconfig/conf.c
+++ b/scripts/kconfig/conf.c
@@ -467,7 +467,7 @@ static void conf_usage(const char *progname)
printf(" --oldaskconfig Start a new configuration using a line-oriented program\n");
printf(" --oldconfig Update a configuration using a provided .config as base\n");
printf(" --silentoldconfig Same as oldconfig, but quietly, additionally update deps\n");
- printf(" --oldnoconfig Same as silentoldconfig but set new symbols to no\n");
+ printf(" --oldnoconfig Same as silentoldconfig but sets new symbols to their default value\n");
printf(" --defconfig <file> New config with default defined in <file>\n");
printf(" --savedefconfig <file> Save the minimal current configuration to <file>\n");
printf(" --allnoconfig New config where all options are answered with no\n");
--
1.7.11.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] [Signed-off] kconfig: document oldnoconfig to what it really does in conf.c
2012-08-17 6:57 [PATCH] [Signed-off] kconfig: document oldnoconfig to what it really does in conf.c Adam Lee
@ 2012-08-22 13:45 ` Adam Lee
2012-08-31 14:57 ` Michal Marek
0 siblings, 1 reply; 3+ messages in thread
From: Adam Lee @ 2012-08-22 13:45 UTC (permalink / raw)
To: linux-kernel
Cc: Michal Marek, Sam Ravnborg, Eric W. Biederman, open list:KCONFIG
On Fri, Aug 17, 2012 at 02:57:28PM +0800, Adam Lee wrote:
> As 67d34a6a391369269a2e5dba8a5f42cc4cd50231 said, the make target
> 'oldnoconfig' is a misnomer. It doesn't set new symbols to 'n', but
> instead sets it to their default values.
>
> This patch fixes the document in conf.c, and will submit another patch
> to replace 'oldnoconfig' to 'olddefconfig'
>
> Signed-off-by: Adam Lee <adam8157@gmail.com>
> ---
> scripts/kconfig/conf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Hi,
I think we should apply this patch, any comment?
I was confused by the different documents of `make help` and usage of
"scripts/kconfig/conf.c" before I got through conf.c and checked the git
log. Others maybe confused too. So I think we really should apply this
patch at least.
As regards whether that target should be renamed to 'olddefconfig', we
can discuss it at another thread.
Thank you.
--
Regards,
Adam Lee
http://adam8157.info
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] [Signed-off] kconfig: document oldnoconfig to what it really does in conf.c
2012-08-22 13:45 ` Adam Lee
@ 2012-08-31 14:57 ` Michal Marek
0 siblings, 0 replies; 3+ messages in thread
From: Michal Marek @ 2012-08-31 14:57 UTC (permalink / raw)
To: Adam Lee; +Cc: linux-kernel, Sam Ravnborg, Eric W. Biederman, open list:KCONFIG
On Wed, Aug 22, 2012 at 09:45:19PM +0800, Adam Lee wrote:
> On Fri, Aug 17, 2012 at 02:57:28PM +0800, Adam Lee wrote:
> > As 67d34a6a391369269a2e5dba8a5f42cc4cd50231 said, the make target
> > 'oldnoconfig' is a misnomer. It doesn't set new symbols to 'n', but
> > instead sets it to their default values.
> >
> > This patch fixes the document in conf.c, and will submit another patch
> > to replace 'oldnoconfig' to 'olddefconfig'
> >
> > Signed-off-by: Adam Lee <adam8157@gmail.com>
> > ---
> > scripts/kconfig/conf.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Hi,
>
> I think we should apply this patch, any comment?
Sorry for the delay. I applied it to kbuild.git#kconfig now.
Michal
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-08-31 14:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-08-17 6:57 [PATCH] [Signed-off] kconfig: document oldnoconfig to what it really does in conf.c Adam Lee
2012-08-22 13:45 ` Adam Lee
2012-08-31 14:57 ` Michal Marek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).