From: Dong Aisheng <b29396@freescale.com>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linus.walleij@stericsson.com" <linus.walleij@stericsson.com>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"grant.likely@secretlab.ca" <grant.likely@secretlab.ca>,
"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
"sameo@linux.intel.com" <sameo@linux.intel.com>,
"lrg@ti.com" <lrg@ti.com>,
"broonie@opensource.wolfsonmicro.com"
<broonie@opensource.wolfsonmicro.com>,
Zhao Richard-B20223 <B20223@freescale.com>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>,
"swarren@wwwdotorg.org" <swarren@wwwdotorg.org>
Subject: Re: [PATCH v4 2/7] ARM: imx6q: add iomuxc gpr support into syscon
Date: Mon, 3 Sep 2012 10:46:06 +0800 [thread overview]
Message-ID: <20120903024606.GC11891@shlinux2.ap.freescale.net> (raw)
In-Reply-To: <20120831020247.GC7726@r65073-Latitude-D630>
On Fri, Aug 31, 2012 at 10:02:48AM +0800, Shawn Guo wrote:
> On Wed, Aug 29, 2012 at 06:56:53PM +0800, Dong Aisheng wrote:
> > From: Dong Aisheng <dong.aisheng@linaro.org>
> >
> > Include headfile for easy using.
> >
> > Acked-by: Stephen Warren <swarren@wwwdotorg.org>
> > Signed-off-by: Dong Aisheng <dong.aisheng@linaro.org>
> > ---
> > arch/arm/boot/dts/imx6q.dtsi | 5 +
> > include/linux/fsl/imx6q-iomuxc-gpr.h | 319 ++++++++++++++++++++++++++++++++++
>
> I assume that all the users of this header file are imx6q syscon
> clients. In that case, this header belongs to mfd/syscon subsystem.
>
> I have been told by people that it was a mistake to create
> include/linux/fsl. Each header in include/linux should go to
> respective subsystem sub-directory. For this particular case,
> it should be include/linux/mfd or include/linux/mfd/syscon even
> better, IMO.
>
I like the later one if not put in include/linux/fsl. :)
> > +#define IMX6Q_GPR13_SATA_PHY_1_MED (0x1 << 0)
> > +#define IMX6Q_GPR13_SATA_PHY_1_SLOW (0x2 << 0)
> > +
> > +#endif /* !__LINUX_IMX6Q_IOMUXC_GPR_H */
>
> Nit: why do we have a "!" there?
>
You're right.
We do not need a '!' for such macro.
Sorry for my mistake.
Regards
Dong Aisheng
next prev parent reply other threads:[~2012-09-03 3:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-29 10:56 [PATCH v4 0/7] add syscon driver based on regmap for general registers access Dong Aisheng
2012-08-29 10:56 ` [PATCH v4 1/7] mfd: add syscon driver based on regmap Dong Aisheng
2012-08-31 1:26 ` Shawn Guo
2012-09-03 2:31 ` Dong Aisheng
2012-09-03 3:09 ` Shawn Guo
2012-09-03 8:02 ` Dong Aisheng
2012-08-29 10:56 ` [PATCH v4 2/7] ARM: imx6q: add iomuxc gpr support into syscon Dong Aisheng
2012-08-31 2:02 ` Shawn Guo
2012-09-03 2:46 ` Dong Aisheng [this message]
2012-08-29 10:56 ` [PATCH v4 3/7] ARM: imx6q: add anatop " Dong Aisheng
2012-08-29 10:56 ` [PATCH v4 4/7] regulator: anatop-regulator: convert to use syscon to access anatop register Dong Aisheng
2012-08-29 10:56 ` [PATCH v4 5/7] ARM: imx6q: convert to use syscon to access anatop registers Dong Aisheng
2012-08-29 10:56 ` [PATCH v4 6/7] ARM: dts: imx6q: add simple-bus compatible string for anatop Dong Aisheng
2012-08-29 10:56 ` [PATCH v4 7/7] mfd: anatop-mfd: remove anatop driver Dong Aisheng
2012-08-31 1:39 ` Shawn Guo
2012-09-03 2:34 ` Dong Aisheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120903024606.GC11891@shlinux2.ap.freescale.net \
--to=b29396@freescale.com \
--cc=B20223@freescale.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=kernel@pengutronix.de \
--cc=linus.walleij@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=rob.herring@calxeda.com \
--cc=s.hauer@pengutronix.de \
--cc=sameo@linux.intel.com \
--cc=shawn.guo@linaro.org \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).