Re: [PATCH 11/13] perf tools: replace mempcpy with memcpy

Re: [PATCH 11/13] perf tools: replace mempcpy with memcpy

[Arnaldo Carvalho de Melo]

Em Wed, Aug 29, 2012 at 01:06:04AM +0300, Irina Tirdea escreveu:
>    mempcpy is not supported by bionic in Android
>    and will lead to compilation errors.
> 
>    Replacing mempcpy with memcpy so it will work in Android.
> 
>    Signed-off-by: Irina Tirdea <irina.tirdea@intel.com>
>    ---
>     tools/perf/util/target.c |    4 ++--
>     1 file changed, 2 insertions(+), 2 deletions(-)
> 
>    diff --git a/tools/perf/util/target.c b/tools/perf/util/target.c
>    index 051eaa6..065528b 100644
>    --- a/tools/perf/util/target.c
>    +++ b/tools/perf/util/target.c
>    @@ -117,8 +117,8 @@ int perf_target__strerror(struct perf_target *target,
>    int errnum,
>     
>             if (err != buf) {
>                 size_t len = strlen(err);
>    -            char *c = mempcpy(buf, err, min(buflen - 1, len));
>    -            *c = '\0';
>    +            memcpy(buf, err, min(buflen - 1, len));
>    +            *(buf + min(buflen - 1, len)) = '\0';
>             }
>     

Can you resubmit this in txt form? I applied some other patches from you
but  you need to try to do it yourself, i.e. send just to you, then try
to save the patch and apply it...

- Arnaldo

Re: [PATCH 11/13] perf tools: replace mempcpy with memcpy

[Irina Tirdea]

>
> Can you resubmit this in txt form? I applied some other patches from you
> but  you need to try to do it yourself, i.e. send just to you, then try
> to save the patch and apply it...

Sorry about this... I will check this myself from now on.
I've seen you already merged this one, but I'll resubmit the others
and make sure they apply properly.

Thanks,
Irina

[PATCH 11/13] perf tools: replace mempcpy with memcpy

[Irina Tirdea]

mempcpy is not supported by bionic in Android
and will lead to compilation errors.

Replacing mempcpy with memcpy so it will work in Android.

Signed-off-by: Irina Tirdea <irina.tirdea@intel.com>
---
 tools/perf/util/target.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/perf/util/target.c b/tools/perf/util/target.c
index 051eaa6..065528b 100644
--- a/tools/perf/util/target.c
+++ b/tools/perf/util/target.c
@@ -117,8 +117,8 @@ int perf_target__strerror(struct perf_target
*target, int errnum,

 		if (err != buf) {
 			size_t len = strlen(err);
-			char *c = mempcpy(buf, err, min(buflen - 1, len));
-			*c = '\0';
+			memcpy(buf, err, min(buflen - 1, len));
+			*(buf + min(buflen - 1, len)) = '\0';
 		}

 		return 0;
-- 
1.7.9.5

Re: [PATCH 11/13] perf tools: replace mempcpy with memcpy

[Namhyung Kim]

On Wed, 29 Aug 2012 01:22:16 +0300, Irina Tirdea wrote:
> mempcpy is not supported by bionic in Android
> and will lead to compilation errors.
>
> Replacing mempcpy with memcpy so it will work in Android.

Unfortunately I've added another instance of the mempcpy in a
libtraceevent code. :-/

Thanks,
Namhyung


>
> Signed-off-by: Irina Tirdea <irina.tirdea@intel.com>
> ---
>  tools/perf/util/target.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/util/target.c b/tools/perf/util/target.c
> index 051eaa6..065528b 100644
> --- a/tools/perf/util/target.c
> +++ b/tools/perf/util/target.c
> @@ -117,8 +117,8 @@ int perf_target__strerror(struct perf_target
> *target, int errnum,
>
>  		if (err != buf) {
>  			size_t len = strlen(err);
> -			char *c = mempcpy(buf, err, min(buflen - 1, len));
> -			*c = '\0';
> +			memcpy(buf, err, min(buflen - 1, len));
> +			*(buf + min(buflen - 1, len)) = '\0';
>  		}
>
>  		return 0;

Re: [PATCH 11/13] perf tools: replace mempcpy with memcpy

[Irina Tirdea]

On Mon, Sep 3, 2012 at 4:09 AM, Namhyung Kim <namhyung@kernel.org> wrote:
> On Wed, 29 Aug 2012 01:22:16 +0300, Irina Tirdea wrote:
>> mempcpy is not supported by bionic in Android
>> and will lead to compilation errors.
>>
>> Replacing mempcpy with memcpy so it will work in Android.
>
> Unfortunately I've added another instance of the mempcpy in a
> libtraceevent code. :-/
>

Thanks for the heads-up. I'll fix it.

Irina

> Thanks,
> Namhyung
>