From: "Michael S. Tsirkin" <mst@redhat.com>
To: Kent Overstreet <koverstreet@google.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] virtio-blk: Fix kconfig option
Date: Thu, 6 Sep 2012 13:18:43 +0300 [thread overview]
Message-ID: <20120906101842.GB32325@redhat.com> (raw)
In-Reply-To: <20120906100247.GA27355@koverstreet-glaptop>
On Thu, Sep 06, 2012 at 03:02:48AM -0700, Kent Overstreet wrote:
> On Thu, Sep 06, 2012 at 12:49:56PM +0300, Michael S. Tsirkin wrote:
> > On Thu, Sep 06, 2012 at 02:25:12AM -0700, Kent Overstreet wrote:
> > > On Thu, Sep 06, 2012 at 11:44:03AM +0300, Michael S. Tsirkin wrote:
> > > > On Thu, Sep 06, 2012 at 12:41:13AM -0700, Kent Overstreet wrote:
> > > > > On Tue, Sep 04, 2012 at 03:53:53PM +0930, Rusty Russell wrote:
> > > > > > Kent Overstreet <koverstreet@google.com> writes:
> > > > > >
> > > > > > > CONFIG_VIRTIO isn't exposed, everything else is supposed to select it
> > > > > > > instead.
> > > > > >
> > > > > > This is a slight mis-understanding. It's supposed to be selected by
> > > > > > the particular driver, probably virtio_pci in your case.
> > > > >
> > > > > So are you saying virtio-blk depends on virtio-pci? If so, the kconfig
> > > > > should have that.
> > > > >
> > > > > As is, VIRTIO_BLK just has:
> > > > > depends on EXPERIMENTAL && VIRTIO
> > > > >
> > > > > which is flat out broken.
> > > >
> > > > I don't think anything is broken.
> > > > Can you show an example of a broken configuration?
> > >
> > > Do you not understand the difference between depends an selects?
> > > Or did you not read my original mail?
> > > Flip off everything in drivers -> virtio
> > >
> > > Now go to drivers -> block and try to turn on virtio-blk.
> > >
> > > It's not listed!
> >
> > Yes. Because you disabled all virtio backends.
> > It does not make sense to have any frontends.
>
> How's a user - or even another kernel developer who isn't familiar with
> virtio - supposed to know that?
>
> I still don't know what exactly a virtio backend is - the term isn't
> even mentioned anywhere that I've seen.
>
> Whatever it is though virtio-blk should be depending on _that_, not a
> config option that _isn't exposed in the menu_!
>
> > > Now go back to drivers -> virtio and turn on (randomly) balloon.
> > >
> > > Go back to drivers -> block, and now you can turn on virtio-blk!
> > >
> > > Do you see what's wrong with this picture?
> >
> > Yes. You got unlucky with your random guess.
> > It's a bug in balloon kconfig: it should not
> > select virtio.
> > I sent a patch to fix that yesterday.
>
> Then it's also a bug in the comments at the top of
> drivers/virtio/Kconfig.
>
> And besides that, how the _hell_ is a user supposed to know to turn on
> VIRTIO_PCI before VIRTIO_BLK? It's not documented anywhere (if that is
> what's supposed to happen! I still don't know)
Well, what kind of device do you have? Tell us :)
If it's a virtio pci device,
you need to enable virtio-pci and virtio-blk.
> and even if it was
> documented, having one kconfig option depend on something that's exposed
> in a _completely different menu_ is just made of fail.
Fine, but why pick on virtio?
This is extremely common in kconfig.
For example, a ton of network drivers depend
on PCI, it's exactly the same thing.
--
MST
next prev parent reply other threads:[~2012-09-06 10:17 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-03 4:41 [PATCH] virtio-blk: Fix kconfig option Kent Overstreet
2012-09-03 4:46 ` Kent Overstreet
2012-09-04 6:23 ` Rusty Russell
2012-09-04 23:12 ` Kent Overstreet
2012-09-05 4:22 ` Asias He
2012-09-05 5:48 ` Michael S. Tsirkin
2012-09-05 5:54 ` Asias He
2012-09-05 6:04 ` Michael S. Tsirkin
2012-09-05 6:12 ` Michael S. Tsirkin
2012-09-06 1:46 ` Rusty Russell
2012-09-06 7:41 ` Kent Overstreet
2012-09-06 8:44 ` Michael S. Tsirkin
2012-09-06 9:25 ` Kent Overstreet
2012-09-06 9:49 ` Michael S. Tsirkin
2012-09-06 10:02 ` Kent Overstreet
2012-09-06 10:18 ` Michael S. Tsirkin [this message]
2012-09-06 10:31 ` Kent Overstreet
2012-09-06 11:09 ` Michael S. Tsirkin
2012-09-06 23:40 ` Rusty Russell
2012-09-07 0:25 ` Kent Overstreet
2012-09-07 2:57 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120906101842.GB32325@redhat.com \
--to=mst@redhat.com \
--cc=koverstreet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).