From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>, Jiri Olsa <jolsa@redhat.com>
Subject: Re: [PATCHSET RESEND 0/5] perf tools: Cleanup hist printing code (v4)
Date: Sat, 8 Sep 2012 08:08:39 -0700 [thread overview]
Message-ID: <20120908150839.GH20401@ghostprotocols.net> (raw)
In-Reply-To: <87ipboaa2j.fsf@kernel.org>
Em Sat, Sep 08, 2012 at 11:00:36PM +0900, Namhyung Kim escreveu:
> On Fri, 7 Sep 2012 17:48:54 -0700, Arnaldo Carvalho de Melo wrote:
> > Please try with:
> > perf record -a usleep 1
> > perf record -a usleep 1
> > perf diff
> > it will use perf.data.old and perf.data and will segfault in that branch.
> I see the problem. I overlooked he->pair can be NULL when perf diff is
> running. So the fix will be adding a NULL check before the line. In
> case of NULL, it will default to 0, so no problem.
Ok, now it doesn't segfaults, but the diff results seems bogus:
Withour this patch + your fix:
[root@sandy ~]# perf diff
# Event 'cycles'
#
# Baseline Delta Shared Object Symbol
# ........ .......... ................. ......................................
#
0.00% +39.61% [kernel.kallsyms] [k] __alloc_pages_nodemask
19.82% +6.10% [kernel.kallsyms] [k] intel_idle
0.00% +8.61% [kernel.kallsyms] [k] generic_exec_single
0.00% +6.39% [kernel.kallsyms] [k] list_del
0.00% +6.15% [kernel.kallsyms] [k] nr_iowait_cpu
0.00% +5.98% [kernel.kallsyms] [k] selinux_inode_permission
0.00% +5.23% libc-2.12.so [.] _dl_addr
0.00% +0.76% [kernel.kallsyms] [k] group_sched_in
0.10% +0.32% [kernel.kallsyms] [k] native_write_msr_safe
0.00% +0.40% [kernel.kallsyms] [k] smp_call_function_single_interrupt
0.14% +0.19% [kernel.kallsyms] [k] csd_unlock
0.00% +0.20% [kernel.kallsyms] [k] perf_pmu_enable
With your patch:
[root@sandy ~]# perf diff
# Event 'cycles'
#
# Baseline Delta Shared Object Symbol
# ........ ....... ................. ......................................
#
39.61% +39.61% [kernel.kallsyms] [k] __alloc_pages_nodemask
25.92% +6.10% [kernel.kallsyms] [k] intel_idle
8.61% +8.61% [kernel.kallsyms] [k] generic_exec_single
6.39% +6.39% [kernel.kallsyms] [k] list_del
6.15% +6.15% [kernel.kallsyms] [k] nr_iowait_cpu
5.98% +5.98% [kernel.kallsyms] [k] selinux_inode_permission
5.23% +5.23% libc-2.12.so [.] _dl_addr
0.76% +0.76% [kernel.kallsyms] [k] group_sched_in
0.42% +0.32% [kernel.kallsyms] [k] native_write_msr_safe
0.40% +0.40% [kernel.kallsyms] [k] smp_call_function_single_interrupt
0.33% +0.19% [kernel.kallsyms] [k] csd_unlock
0.20% +0.20% [kernel.kallsyms] [k] perf_pmu_enable
[root@sandy ~]#
The deltas are the same, but the baseline completely changed and are bogus.
So please try again and make sure that the results are kept.
- Arnaldo
prev parent reply other threads:[~2012-09-08 15:08 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-03 2:53 [PATCHSET RESEND 0/5] perf tools: Cleanup hist printing code (v4) Namhyung Kim
2012-09-03 2:53 ` [PATCH 1/5] perf hists: Introduce perf_hpp for hist period printing Namhyung Kim
2012-09-09 8:54 ` [tip:perf/core] " tip-bot for Namhyung Kim
2012-09-12 17:26 ` Robert Richter
2012-09-12 18:48 ` Arnaldo Carvalho de Melo
2012-09-13 2:43 ` Namhyung Kim
2012-09-13 3:51 ` Arnaldo Carvalho de Melo
2012-09-13 4:14 ` [PATCH] perf record: Add missing perf_hpp__init for pipe-mode Namhyung Kim
2012-09-13 4:21 ` Namhyung Kim
2012-09-13 9:48 ` Robert Richter
2012-09-19 15:25 ` [tip:perf/core] perf report: " tip-bot for Namhyung Kim
2012-09-03 2:53 ` [PATCH 2/5] perf hists: Handle field separator properly Namhyung Kim
2012-09-09 8:55 ` [tip:perf/core] " tip-bot for Namhyung Kim
2012-09-03 2:53 ` [PATCH 3/5] perf hists: Use perf_hpp__format->width to calculate the column widths Namhyung Kim
2012-09-09 8:56 ` [tip:perf/core] perf hists: Use perf_hpp__format-> width " tip-bot for Namhyung Kim
2012-09-03 2:53 ` [PATCH 4/5] perf ui/browser: Use perf_hpp__format functions Namhyung Kim
2012-09-08 0:32 ` Arnaldo Carvalho de Melo
2012-09-08 14:05 ` Namhyung Kim
2012-09-12 6:25 ` Namhyung Kim
2012-09-09 8:57 ` [tip:perf/core] perf hists browser: " tip-bot for Namhyung Kim
2012-09-03 2:53 ` [PATCH 5/5] perf gtk/browser: " Namhyung Kim
2012-09-09 8:58 ` [tip:perf/core] " tip-bot for Namhyung Kim
2012-09-08 0:48 ` [PATCHSET RESEND 0/5] perf tools: Cleanup hist printing code (v4) Arnaldo Carvalho de Melo
2012-09-08 14:00 ` Namhyung Kim
2012-09-08 15:08 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120908150839.GH20401@ghostprotocols.net \
--to=acme@ghostprotocols.net \
--cc=a.p.zijlstra@chello.nl \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).