linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Robert Richter <robert.richter@amd.com>,
	mingo@kernel.org, hpa@zytor.com, paulus@samba.org,
	linux-kernel@vger.kernel.org, a.p.zijlstra@chello.nl,
	namhyung.kim@lge.com, tglx@linutronix.de,
	linux-tip-commits@vger.kernel.org
Subject: Re: [tip:perf/core] perf hists: Introduce perf_hpp for hist period printing
Date: Thu, 13 Sep 2012 11:43:08 +0900	[thread overview]
Message-ID: <87y5ke8wxv.fsf@sejong.aot.lge.com> (raw)
In-Reply-To: <20120912184815.GC557@infradead.org> (Arnaldo Carvalho de Melo's message of "Wed, 12 Sep 2012 15:48:15 -0300")

Hi Arnaldo and Robert,

On Wed, 12 Sep 2012 15:48:15 -0300, Arnaldo Carvalho de Melo wrote:
> Em Wed, Sep 12, 2012 at 07:26:41PM +0200, Robert Richter escreveu:
>> On 09.09.12 01:54:39, tip-bot for Namhyung Kim wrote:
>> 
>>  # perf record -e cycles -aq sleep 1 ; perf report -n --sort comm,dso | sed '/%/q;d' ; \
>>    perf record -e cycles -aq sleep 1 | perf report -n --sort comm,dso | sed '/%/q;d'
>>      99.86%        11804       swapper  [kernel.kallsyms]
>>      91.57%      swapper  [kernel.kallsyms]
>>            ^^^^^^
>>            number of samples missing
>> 
>> Moving and changing the code at the same time make the patch
>> unreviewable. So no clue that's the problem here.
>
> Yeah, that was unfortunate (movind and changing), we need to try hard
> not to do that...

Okay, will be careful next time.


>
> Anyway, Namhyung, can you take a look at this?

Sure, I'll take a look.

Thanks,
Namhyung

  reply	other threads:[~2012-09-13  2:50 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-03  2:53 [PATCHSET RESEND 0/5] perf tools: Cleanup hist printing code (v4) Namhyung Kim
2012-09-03  2:53 ` [PATCH 1/5] perf hists: Introduce perf_hpp for hist period printing Namhyung Kim
2012-09-09  8:54   ` [tip:perf/core] " tip-bot for Namhyung Kim
2012-09-12 17:26     ` Robert Richter
2012-09-12 18:48       ` Arnaldo Carvalho de Melo
2012-09-13  2:43         ` Namhyung Kim [this message]
2012-09-13  3:51           ` Arnaldo Carvalho de Melo
2012-09-13  4:14           ` [PATCH] perf record: Add missing perf_hpp__init for pipe-mode Namhyung Kim
2012-09-13  4:21             ` Namhyung Kim
2012-09-13  9:48             ` Robert Richter
2012-09-19 15:25             ` [tip:perf/core] perf report: " tip-bot for Namhyung Kim
2012-09-03  2:53 ` [PATCH 2/5] perf hists: Handle field separator properly Namhyung Kim
2012-09-09  8:55   ` [tip:perf/core] " tip-bot for Namhyung Kim
2012-09-03  2:53 ` [PATCH 3/5] perf hists: Use perf_hpp__format->width to calculate the column widths Namhyung Kim
2012-09-09  8:56   ` [tip:perf/core] perf hists: Use perf_hpp__format-> width " tip-bot for Namhyung Kim
2012-09-03  2:53 ` [PATCH 4/5] perf ui/browser: Use perf_hpp__format functions Namhyung Kim
2012-09-08  0:32   ` Arnaldo Carvalho de Melo
2012-09-08 14:05     ` Namhyung Kim
2012-09-12  6:25       ` Namhyung Kim
2012-09-09  8:57   ` [tip:perf/core] perf hists browser: " tip-bot for Namhyung Kim
2012-09-03  2:53 ` [PATCH 5/5] perf gtk/browser: " Namhyung Kim
2012-09-09  8:58   ` [tip:perf/core] " tip-bot for Namhyung Kim
2012-09-08  0:48 ` [PATCHSET RESEND 0/5] perf tools: Cleanup hist printing code (v4) Arnaldo Carvalho de Melo
2012-09-08 14:00   ` Namhyung Kim
2012-09-08 15:08     ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y5ke8wxv.fsf@sejong.aot.lge.com \
    --to=namhyung@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@redhat.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung.kim@lge.com \
    --cc=paulus@samba.org \
    --cc=robert.richter@amd.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).