* [char-misc-next 1/3] mei: add error messages for open count errors
@ 2012-09-10 21:43 Tomas Winkler
2012-09-10 21:43 ` [char-misc-next 2/3] mei: struct mei_message_data doesn't have to be packed Tomas Winkler
2012-09-10 21:43 ` [char-misc-next 3/3] mei: don't print buffer as a string Tomas Winkler
0 siblings, 2 replies; 4+ messages in thread
From: Tomas Winkler @ 2012-09-10 21:43 UTC (permalink / raw)
To: gregkh; +Cc: arnd, alan, linux-kernel, Tomas Winkler
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
---
drivers/misc/mei/main.c | 10 ++++++++--
1 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/misc/mei/main.c b/drivers/misc/mei/main.c
index ae2cd0d..e8b0858 100644
--- a/drivers/misc/mei/main.c
+++ b/drivers/misc/mei/main.c
@@ -239,12 +239,18 @@ static int mei_open(struct inode *inode, struct file *file)
goto out_unlock;
}
err = -EMFILE;
- if (dev->open_handle_count >= MEI_MAX_OPEN_HANDLE_COUNT)
+ if (dev->open_handle_count >= MEI_MAX_OPEN_HANDLE_COUNT) {
+ dev_err(&dev->pdev->dev, "open_handle_count exceded %d",
+ MEI_MAX_OPEN_HANDLE_COUNT);
goto out_unlock;
+ }
cl_id = find_first_zero_bit(dev->host_clients_map, MEI_CLIENTS_MAX);
- if (cl_id >= MEI_CLIENTS_MAX)
+ if (cl_id >= MEI_CLIENTS_MAX) {
+ dev_err(&dev->pdev->dev, "client_id exceded %d",
+ MEI_CLIENTS_MAX) ;
goto out_unlock;
+ }
cl->host_client_id = cl_id;
--
1.7.4.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [char-misc-next 2/3] mei: struct mei_message_data doesn't have to be packed
2012-09-10 21:43 [char-misc-next 1/3] mei: add error messages for open count errors Tomas Winkler
@ 2012-09-10 21:43 ` Tomas Winkler
2012-09-10 23:24 ` Alan Cox
2012-09-10 21:43 ` [char-misc-next 3/3] mei: don't print buffer as a string Tomas Winkler
1 sibling, 1 reply; 4+ messages in thread
From: Tomas Winkler @ 2012-09-10 21:43 UTC (permalink / raw)
To: gregkh; +Cc: arnd, alan, linux-kernel, Tomas Winkler
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
---
drivers/misc/mei/mei_dev.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/misc/mei/mei_dev.h b/drivers/misc/mei/mei_dev.h
index 96d3e79..adb35fb 100644
--- a/drivers/misc/mei/mei_dev.h
+++ b/drivers/misc/mei/mei_dev.h
@@ -140,7 +140,7 @@ enum mei_cb_major_types {
struct mei_message_data {
u32 size;
unsigned char *data;
-} __packed;
+};
struct mei_cl_cb {
--
1.7.4.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [char-misc-next 3/3] mei: don't print buffer as a string
2012-09-10 21:43 [char-misc-next 1/3] mei: add error messages for open count errors Tomas Winkler
2012-09-10 21:43 ` [char-misc-next 2/3] mei: struct mei_message_data doesn't have to be packed Tomas Winkler
@ 2012-09-10 21:43 ` Tomas Winkler
1 sibling, 0 replies; 4+ messages in thread
From: Tomas Winkler @ 2012-09-10 21:43 UTC (permalink / raw)
To: gregkh; +Cc: arnd, alan, linux-kernel, Tomas Winkler
non readable junk was printed to the logs
we will add proper buffer dumping mechanism later if needed
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
---
drivers/misc/mei/interrupt.c | 9 +--------
1 files changed, 1 insertions(+), 8 deletions(-)
diff --git a/drivers/misc/mei/interrupt.c b/drivers/misc/mei/interrupt.c
index 0900a71..3533edd 100644
--- a/drivers/misc/mei/interrupt.c
+++ b/drivers/misc/mei/interrupt.c
@@ -221,17 +221,10 @@ static int mei_irq_thread_read_client_message(struct mei_io_list *complete_list,
cl->status = 0;
list_del(&cb_pos->cb_list);
dev_dbg(&dev->pdev->dev,
- "completed read host client = %d,"
- "ME client = %d, "
- "data length = %lu\n",
+ "completed read H cl = %d, ME cl = %d, length = %lu\n",
cl->host_client_id,
cl->me_client_id,
cb_pos->information);
-
- *(cb_pos->response_buffer.data +
- cb_pos->information) = '\0';
- dev_dbg(&dev->pdev->dev, "cb_pos->res_buffer - %s\n",
- cb_pos->response_buffer.data);
list_add_tail(&cb_pos->cb_list,
&complete_list->mei_cb.cb_list);
}
--
1.7.4.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [char-misc-next 2/3] mei: struct mei_message_data doesn't have to be packed
2012-09-10 21:43 ` [char-misc-next 2/3] mei: struct mei_message_data doesn't have to be packed Tomas Winkler
@ 2012-09-10 23:24 ` Alan Cox
0 siblings, 0 replies; 4+ messages in thread
From: Alan Cox @ 2012-09-10 23:24 UTC (permalink / raw)
To: Tomas Winkler; +Cc: gregkh, arnd, alan, linux-kernel
On Tue, 11 Sep 2012 00:43:21 +0300
Tomas Winkler <tomas.winkler@intel.com> wrote:
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> ---
> drivers/misc/mei/mei_dev.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/misc/mei/mei_dev.h b/drivers/misc/mei/mei_dev.h
> index 96d3e79..adb35fb 100644
> --- a/drivers/misc/mei/mei_dev.h
> +++ b/drivers/misc/mei/mei_dev.h
> @@ -140,7 +140,7 @@ enum mei_cb_major_types {
> struct mei_message_data {
> u32 size;
> unsigned char *data;
> -} __packed;
> +};
Explanation would be useful especially for this one. The others are
obvious although a one line comment would still be good form perhaps.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-09-10 23:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-09-10 21:43 [char-misc-next 1/3] mei: add error messages for open count errors Tomas Winkler
2012-09-10 21:43 ` [char-misc-next 2/3] mei: struct mei_message_data doesn't have to be packed Tomas Winkler
2012-09-10 23:24 ` Alan Cox
2012-09-10 21:43 ` [char-misc-next 3/3] mei: don't print buffer as a string Tomas Winkler
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).