From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Samuel Iglesias Gonsálvez" <siglesias@igalia.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org,
Jens Taprogge <jens.taprogge@taprogge.org>,
linux-kernel@vger.kernel.org,
industrypack-devel@lists.sourceforge.net
Subject: Re: [PATCH 04/20] Staging: ipack: Obtain supported speeds from ID ROM.
Date: Tue, 11 Sep 2012 11:47:27 +0300 [thread overview]
Message-ID: <20120911084727.GN19396@mwanda> (raw)
In-Reply-To: <1347267118-9580-4-git-send-email-siglesias@igalia.com>
On Mon, Sep 10, 2012 at 10:51:42AM +0200, Samuel Iglesias Gonsálvez wrote:
> From: Jens Taprogge <jens.taprogge@taprogge.org>
>
> Signed-off-by: Jens Taprogge <jens.taprogge@taprogge.org>
> Signed-off-by: Samuel Iglesias Gonsálvez <siglesias@igalia.com>
> ---
> drivers/staging/ipack/ipack.c | 6 ++++++
> drivers/staging/ipack/ipack.h | 2 ++
> 2 files changed, 8 insertions(+)
>
> diff --git a/drivers/staging/ipack/ipack.c b/drivers/staging/ipack/ipack.c
> index b3736c0..521ff55 100644
> --- a/drivers/staging/ipack/ipack.c
> +++ b/drivers/staging/ipack/ipack.c
> @@ -261,15 +261,21 @@ static void ipack_parse_id1(struct ipack_device *dev)
>
> dev->id_vendor = id[4];
> dev->id_device = id[5];
> + dev->speed_8mhz = 1;
> + dev->speed_32mhz = (id[7] == 'H');
> }
>
> static void ipack_parse_id2(struct ipack_device *dev)
> {
> __be16 *id = (__be16 *) dev->id;
> + u16 flags;
>
> dev->id_vendor = ((be16_to_cpu(id[3]) & 0xff) << 16)
> + be16_to_cpu(id[4]);
> dev->id_device = be16_to_cpu(id[5]);
> + flags = be16_to_cpu(id[10]);
> + dev->speed_8mhz = ((flags & 2) != 0);
> + dev->speed_32mhz = ((flags & 4) != 0);
I really dislike "!= 0" double negatives. I would prefer this:
dev->speed_8mhz = !!(flags & 2);
dev->speed_32mhz = !!(flags & 4);
For me the !! is idiomatic and means turn this into a bool. I don't
know if maybe I'm the only person who feels this way.
regards,
dan carpenter
next prev parent reply other threads:[~2012-09-11 8:48 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-10 8:51 [PATCH 01/20] Staging: ipack/bridges/tpci200: Put the TPCI200 control registers into a struct Samuel Iglesias Gonsálvez
2012-09-10 8:51 ` [PATCH 02/20] Staging: ipack: Provide several carrier callbacks Samuel Iglesias Gonsálvez
2012-09-10 8:51 ` [PATCH 03/20] Staging: ipack/bridges/tpci200: provide new callbacks to tpci200 Samuel Iglesias Gonsálvez
2012-09-11 8:47 ` Dan Carpenter
2012-09-12 9:28 ` Jens Taprogge
2012-09-12 11:13 ` Dan Carpenter
2012-09-12 11:21 ` Samuel Iglesias Gonsálvez
2012-09-12 11:59 ` Dan Carpenter
2012-09-12 12:28 ` Jens Taprogge
2012-09-12 12:47 ` Samuel Iglesias Gonsálvez
2012-09-12 11:58 ` Jens Taprogge
2012-09-10 8:51 ` [PATCH 04/20] Staging: ipack: Obtain supported speeds from ID ROM Samuel Iglesias Gonsálvez
2012-09-11 8:47 ` Dan Carpenter [this message]
2012-09-10 8:51 ` [PATCH 05/20] Staging: ipack: Choose the optimum bus speed by default Samuel Iglesias Gonsálvez
2012-09-11 8:47 ` Dan Carpenter
2012-09-10 8:51 ` [PATCH 06/20] Staging: ipack: remove field driver from struct ipack_device Samuel Iglesias Gonsálvez
2012-09-10 8:51 ` [PATCH 07/20] Staging: ipack/bridges/tpci200: remove struct list_head Samuel Iglesias Gonsálvez
2012-09-10 8:51 ` [PATCH 08/20] Staging: ipack: Switch to 8MHz operation before reading ID Samuel Iglesias Gonsálvez
2012-09-11 8:48 ` Dan Carpenter
2012-09-11 11:31 ` Samuel Iglesias Gonsálvez
2012-09-11 11:39 ` Jens Taprogge
2012-09-11 14:39 ` Samuel Iglesias Gonsálvez
2012-09-11 15:33 ` Dan Carpenter
2012-09-10 8:51 ` [PATCH 09/20] Staging: ipack: reset previous timeouts during device registration Samuel Iglesias Gonsálvez
2012-09-11 8:48 ` Dan Carpenter
2012-09-10 8:51 ` [PATCH 10/20] Staging: ipack: check the device ID space CRC Samuel Iglesias Gonsálvez
2012-09-10 8:51 ` [PATCH 11/20] Staging: ipack/bridges/tpci200: reorder the iounmap and pci_release_region Samuel Iglesias Gonsálvez
2012-09-11 8:49 ` Dan Carpenter
2012-09-10 8:51 ` [PATCH 12/20] Staging: ipack/bridges/tpci200: increment the reference counter of the pci_dev Samuel Iglesias Gonsálvez
2012-09-10 8:51 ` [PATCH 13/20] Staging: ipack/bridges/tpci200: fix the uninstall the ipack device Samuel Iglesias Gonsálvez
2012-09-10 8:51 ` [PATCH 14/20] Staging: ipack/devices/ipoctal: change exiting procedure Samuel Iglesias Gonsálvez
2012-09-10 8:51 ` [PATCH 15/20] Staging: ipack/devices/ipoctal: free the IRQ Samuel Iglesias Gonsálvez
2012-09-10 8:51 ` [PATCH 16/20] Staging: ipack: unregister devices when uninstall the carrier device Samuel Iglesias Gonsálvez
2012-09-10 8:51 ` [PATCH 17/20] Staging: ipack/bridges/tpci200: delete ipack_device_unregister calls when exiting Samuel Iglesias Gonsálvez
2012-09-10 8:51 ` [PATCH 18/20] Staging: ipack/bridges/tpci200: remove tpci200_slot_unregister Samuel Iglesias Gonsálvez
2012-09-10 8:51 ` [PATCH 19/20] Staging: ipack: delete .remove_device() callback Samuel Iglesias Gonsálvez
2012-09-10 8:51 ` [PATCH 20/20] Staging: ipack/bridges/tpci200: Store the irq holder in slot_irq Samuel Iglesias Gonsálvez
2012-09-11 8:51 ` Dan Carpenter
2012-09-11 9:05 ` Samuel Iglesias Gonsálvez
2012-09-11 9:57 ` Dan Carpenter
2012-09-10 18:29 ` [PATCH 01/20] Staging: ipack/bridges/tpci200: Put the TPCI200 control registers into a struct Greg Kroah-Hartman
2012-09-11 7:01 ` Samuel Iglesias Gonsálvez
2012-09-11 7:42 ` Miguel Gómez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120911084727.GN19396@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=industrypack-devel@lists.sourceforge.net \
--cc=jens.taprogge@taprogge.org \
--cc=linux-kernel@vger.kernel.org \
--cc=siglesias@igalia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).