Re: [PATCH 05/20] Staging: ipack: Choose the optimum bus speed by default.

[Dan Carpenter <dan.carpenter@oracle.com>]

On Mon, Sep 10, 2012 at 10:51:43AM +0200, Samuel Iglesias Gonsálvez wrote:
> From: Jens Taprogge <jens.taprogge@taprogge.org>
> 
> Signed-off-by: Jens Taprogge <jens.taprogge@taprogge.org>
> Signed-off-by: Samuel Iglesias Gonsálvez <siglesias@igalia.com>
> ---
>  drivers/staging/ipack/ipack.c |    5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/staging/ipack/ipack.c b/drivers/staging/ipack/ipack.c
> index 521ff55..6e0b441 100644
> --- a/drivers/staging/ipack/ipack.c
> +++ b/drivers/staging/ipack/ipack.c
> @@ -386,6 +386,11 @@ struct ipack_device *ipack_device_register(struct ipack_bus_device *bus,
>  		return NULL;
>  	}
>  
> +	/* if the device supports 32 MHz operation, use it. */
> +	ret = bus->ops->set_clockrate(dev, dev->speed_32mhz ? 32 : 8);
> +	if (ret < 0)
> +		dev_err(&dev->dev, "failed to switch to 32 MHz operation.\n");

It's strange that we don't test the ->speed_8mhz flag.  Do we even
need that flag?  It might be better to write it like this:

	if (dev->speed_32mhz) {
		ret = bus->ops->set_clockrate(dev, 32);
		 if (ret < 0) {
		 	dev_err(&dev->dev,
			        "failed to switch to 32 MHz operation.\n");
		}
	}

The error message is not accurate in the original code because it
says 32 even if you tried to set it to 8.

regards,
dan carpenter