From: Jean Delvare <khali@linux-fr.org>
To: Samuel Ortiz <sameo@linux.intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Grant Likely <grant.likely@secretlab.ca>,
Peter Tyser <ptyser@xes-inc.com>,
Aaron Sierra <asierra@xes-inc.com>
Subject: Re: [PATCH] gpio-ich: Share ownership of GPIO groups
Date: Tue, 11 Sep 2012 12:56:08 +0200 [thread overview]
Message-ID: <20120911125608.385356fc@endymion.delvare> (raw)
In-Reply-To: <20120911104116.GR3647@sortiz-mobl>
On Tue, 11 Sep 2012 12:41:16 +0200, Samuel Ortiz wrote:
> Hi Jean,
>
> On Mon, Jul 23, 2012 at 05:34:15PM +0200, Jean Delvare wrote:
> > The ICH chips have their GPIO pins organized in 2 or 3 independent
> > groups of 32 GPIO pins. It can happen that the ACPI BIOS wants to make
> > use of pins in one group, preventing the OS to access these. This does
> > not prevent the OS from accessing the other group(s).
> >
> > This is the case for example on my Asus Z8NA-D6 board. The ACPI BIOS
> > wants to control GPIO 18 (group 1), while I (the OS) need to control
> > GPIO 52 and 53 (group 2) for SMBus multiplexing.
> >
> > So instead of checking for ACPI resource conflict on the whole I/O
> > range, check on a per-group basis, and consider it a success if at
> > least one of the groups is available for the OS to use.
> >
> > Signed-off-by: Jean Delvare <khali@linux-fr.org>
> > Cc: Peter Tyser <ptyser@xes-inc.com>
> > Cc: Aaron Sierra <asierra@xes-inc.com>
> > Cc: Grant Likely <grant.likely@secretlab.ca>
> > Cc: Samuel Ortiz <sameo@linux.intel.com>
> > ---
> > That's probably not the nicest code you've seen, but everything else I
> > could think of either couldn't work or was looking worse. If anyone can
> > think of a better approach, I'm all ears.
> >
> > drivers/gpio/gpio-ich.c | 79 +++++++++++++++++++++++++++++++++++++------
> > drivers/mfd/lpc_ich.c | 29 ++++++++++++++-
> > include/linux/mfd/lpc_ich.h | 1
> > 3 files changed, 97 insertions(+), 12 deletions(-)
> Applied (finally) to my for-next branch, thanks.
Excellent, thank you!
--
Jean Delvare
prev parent reply other threads:[~2012-09-11 10:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-23 15:34 [PATCH] gpio-ich: Share ownership of GPIO groups Jean Delvare
2012-08-01 9:13 ` Jean Delvare
2012-08-01 10:16 ` Samuel Ortiz
2012-08-01 10:41 ` Jean Delvare
2012-09-04 11:36 ` Jean Delvare
2012-09-04 17:35 ` Linus Walleij
2012-08-05 10:02 ` Linus Walleij
2012-09-11 10:41 ` Samuel Ortiz
2012-09-11 10:56 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120911125608.385356fc@endymion.delvare \
--to=khali@linux-fr.org \
--cc=asierra@xes-inc.com \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=ptyser@xes-inc.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).