* [PATCH 8/9] sound/soc/soc-core.c: Remove useless kfree
@ 2012-09-12 15:06 Peter Senna Tschudin
2012-09-13 4:30 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Peter Senna Tschudin @ 2012-09-12 15:06 UTC (permalink / raw)
To: Liam Girdwood
Cc: kernel-janitors, Mark Brown, Jaroslav Kysela, Takashi Iwai,
alsa-devel, linux-kernel
From: Peter Senna Tschudin <peter.senna@gmail.com>
Remove useless kfree() and clean up code related to the removal.
The semantic patch that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r exists@
position p1,p2;
expression x;
@@
if (x@p1 == NULL) { ... kfree@p2(x); ... return ...; }
@unchanged exists@
position r.p1,r.p2;
expression e <= r.x,x,e1;
iterator I;
statement S;
@@
if (x@p1 == NULL) { ... when != I(x,...) S
when != e = e1
when != e += e1
when != e -= e1
when != ++e
when != --e
when != e++
when != e--
when != &e
kfree@p2(x); ... return ...; }
@ok depends on unchanged exists@
position any r.p1;
position r.p2;
expression x;
@@
... when != true x@p1 == NULL
kfree@p2(x);
@depends on !ok && unchanged@
position r.p2;
expression x;
@@
*kfree@p2(x);
// </smpl>
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
---
sound/soc/soc-core.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index 2a4c7bb..6b29c73 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -4052,8 +4052,6 @@ int snd_soc_register_codec(struct device *dev,
return 0;
fail:
- kfree(codec->reg_def_copy);
- codec->reg_def_copy = NULL;
kfree(codec->name);
kfree(codec);
return ret;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 8/9] sound/soc/soc-core.c: Remove useless kfree
2012-09-12 15:06 [PATCH 8/9] sound/soc/soc-core.c: Remove useless kfree Peter Senna Tschudin
@ 2012-09-13 4:30 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2012-09-13 4:30 UTC (permalink / raw)
To: Peter Senna Tschudin
Cc: Liam Girdwood, kernel-janitors, Jaroslav Kysela, Takashi Iwai,
alsa-devel, linux-kernel
On Wed, Sep 12, 2012 at 05:06:46PM +0200, Peter Senna Tschudin wrote:
> From: Peter Senna Tschudin <peter.senna@gmail.com>
>
> Remove useless kfree() and clean up code related to the removal.
>
> The semantic patch that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-09-13 4:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-09-12 15:06 [PATCH 8/9] sound/soc/soc-core.c: Remove useless kfree Peter Senna Tschudin
2012-09-13 4:30 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).